Issues in index.php - All Issues - Inspection of "Merge pull request #7 from codingneko/scrutinizer-..." - codingneko/nerve - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (d18bd7)

by Cody

created 2018-04-07 20:25 UTC

index.php (3 issues)

Severity

Unknown 3

<html>
  <head>
    <meta charset="utf-8" />
    <title>Nerve</title>
    <link rel="stylesheet" type="text/css" href="style.css">
    <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>
    <script src="scripts/script.js"></script>
    <noscript>
      Javascript is recommended and needed if you want to Nerve to automatically refresh messages.<br />
    </noscript>
  </head>
<?php
  session_start();

  //Configuration
  $file = "database.json";
  $max_file_size = "4000000";
  $password = ""; //leave it as is for no password
  $max_messages = 10; //set this to 0 for unlimited
  $auto_remove_files = true;

  if (!isset($_SESSION['logged_in'])) {
    $_SESSION['logged_in'] = false;
  }
  $logged_in = false;

  if (!$_SESSION['logged_in'] && $password != "") {

    require_once("functions/login.php");
  }else if ($_SESSION['logged_in'] || $password == "") {

    // display messages
    require_once("functions/display_messages.php");
    $messages = get_messages($file);
    $logged_in = true;
    //get last message
    $last_msg = show_messages($messages, "last_msg");
    if (count($messages['messages']) > $max_messages && $max_messages != 0) {
      array_shift($messages['messages']);
      $jsondata = json_encode($messages, JSON_PRETTY_PRINT);
      file_put_contents($file, $jsondata);
      $file_to_remove = "images/" . $messages['messages'][0]['file'];
      unlink($file_to_remove);
    }
    // post messages
    require_once("functions/post_messages.php");

    ?>
      <body>
        <div id="messages-container-php">
          <?php
          echo show_messages($messages, "messages");
          ?>
        </div>
        <?php
          if ($logged_in) {

            ?>
            <div id="messages"></div>
            <?php
          }
        ?>
        <form action="" enctype="multipart/form-data" method="post">
          <textarea name="message" placeholder="type in a message" cols="42"></textarea><br /><br />
          <input type="file" name="file" id="uploadFile">
          <input type="submit" name="submit" />
        </form>
      </body>
    </html>
    <?php
  }
?>


1			<html>
2			<head>
3			<meta charset="utf-8" />
4			<title>Nerve</title>
5			<link rel="stylesheet" type="text/css" href="style.css">
6			<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.3.1/jquery.min.js"></script>
7			<script src="scripts/script.js"></script>
8			<noscript>
9			Javascript is recommended and needed if you want to Nerve to automatically refresh messages.<br />
10			</noscript>
11			</head>
12			<?php
13			session_start();
14
15			//Configuration
16			$file = "database.json";
17			$max_file_size = "4000000";
18			$password = ""; //leave it as is for no password
19			$max_messages = 10; //set this to 0 for unlimited
20			$auto_remove_files = true;
21
22			if (!isset($_SESSION['logged_in'])) {
23			$_SESSION['logged_in'] = false;
24			}
25			$logged_in = false;
26
27			if (!$_SESSION['logged_in'] && $password != "") {
			1 ignored issue – show introduced 2018-04-04 18:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this The condition `$password != ''` is always `false`. Loading history...
28			require_once("functions/login.php");
29			}else if ($_SESSION['logged_in'] \|\| $password == "") {
			1 ignored issue – show introduced 2018-04-04 18:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this The condition `$password == ''` is always `true`. Loading history...
30			// display messages
31			require_once("functions/display_messages.php");
32			$messages = get_messages($file);
33			$logged_in = true;
34			//get last message
35			$last_msg = show_messages($messages, "last_msg");
36			if (count($messages['messages']) > $max_messages && $max_messages != 0) {
37			array_shift($messages['messages']);
38			$jsondata = json_encode($messages, JSON_PRETTY_PRINT);
39			file_put_contents($file, $jsondata);
40			$file_to_remove = "images/" . $messages['messages'][0]['file'];
41			unlink($file_to_remove);
42			}
43			// post messages
44			require_once("functions/post_messages.php");
45
46			?>
47			<body>
48			<div id="messages-container-php">
49			<?php
50			echo show_messages($messages, "messages");
51			?>
52			</div>
53			<?php
54			if ($logged_in) {
			1 ignored issue – show introduced 2018-04-04 18:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this The condition `$logged_in` is always `true`. Loading history...
55			?>
56			<div id="messages"></div>
57			<?php
58			}
59			?>
60			<form action="" enctype="multipart/form-data" method="post">
61			<textarea name="message" placeholder="type in a message" cols="42"></textarea><br /><br />
62			<input type="file" name="file" id="uploadFile">
63			<input type="submit" name="submit" />
64			</form>
65			</body>
66			</html>
67			<?php
68			}
69			?>
70

codingneko / nerve

Branch — master (d18bd7)

index.php (3 issues)

Severity

Introduced By

Duplication Side-by-Side

Filter issues like