TranslateCompiler::getOutputFilename() - Code Metrics - Inspection of "Atualização dos arquivos do Scaffolder" - codificar/scaffolder - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 63d8d6...28be9d )

by Raphael

created 2017-03-30 19:20 UTC

TranslateCompiler::getOutputFilename() A

↳ Parent: TranslateCompiler

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	0

<?php

namespace Scaffolder\Compilers\AngularJs;

use Illuminate\Support\Facades\File;
use Scaffolder\Compilers\AbstractCompiler;
use Scaffolder\Compilers\Support\FileToCompile;
use Scaffolder\Compilers\Support\PathParser;
use Scaffolder\Support\Directory;
use Scaffolder\Support\CamelCase;
use stdClass ;


class TranslateCompiler extends AbstractCompiler
{
	protected $cachePrefix 	= 'translate_';
	protected $stubFilename = 'Translate.js' ;

	public function __construct($scaffolderConfig, $modelData = null)
	{
		$this->stubsDirectory = __DIR__ . '/../../../../stubs/AngularJs/';
		parent::__construct($scaffolderConfig, $modelData);
	}

	/**
	 * Replace and store the Stub.
	 *
	 * @return string
	 */
	public function replaceAndStore()
	{
		
		return $this->replaceColumns()
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
					->replaceArea()
					->store(new FileToCompile(false, $this->modelData->modelHash));
		
	}

	/**
	 * replace columns
	 *
	 * @return $this
	 */
	public function replaceArea(){
		$this->stub = str_replace('{{singular}}', ucwords($this->modelData->tableName), $this->stub); 
		$this->stub = str_replace('{{plural}}', ucwords(CamelCase::pluralize($this->modelData->tableName)), $this->stub); 
		return $this;
	}

	/**
	 * replace columns
	 *
	 * @return $this
	 */
	public function replaceColumns(){

		$columns = [];

		foreach ($this->modelData->fields as $field)
		{
			array_push($columns,  "\t\t".sprintf('"%s" : "%s"',  $field->name,  CamelCase::convertToCamelCase($field->name) ));
		}

		$this->stub = str_replace('{{columns}}', join(",\n", $columns), $this->stub); 

		return $this ;

	}
	
	/**
	 * Get output filename
	 *
	 *
	 * @return $this
	 */
	protected function getOutputFilename()
	{
		$folder = PathParser::parse($this->scaffolderConfig->generator->paths->pages).$this->modelData->tableName.'/i18n/' ;

		Directory::createIfNotExists($folder, 0755, true);

		return $folder . 'en.json';
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
	}

}

1			<?php
2
3			namespace Scaffolder\Compilers\AngularJs;
4
5			use Illuminate\Support\Facades\File;
6			use Scaffolder\Compilers\AbstractCompiler;
7			use Scaffolder\Compilers\Support\FileToCompile;
8			use Scaffolder\Compilers\Support\PathParser;
9			use Scaffolder\Support\Directory;
10			use Scaffolder\Support\CamelCase;
11			use stdClass ;
12
13
14			class TranslateCompiler extends AbstractCompiler
15			{
16			protected $cachePrefix = 'translate_';
17			protected $stubFilename = 'Translate.js' ;
18
19			public function __construct($scaffolderConfig, $modelData = null)
20			{
21			$this->stubsDirectory = __DIR__ . '/../../../../stubs/AngularJs/';
22			parent::__construct($scaffolderConfig, $modelData);
23			}
24
25			/**
26			* Replace and store the Stub.
27			*
28			* @return string
29			*/
30			public function replaceAndStore()
31			{
32
33			return $this->replaceColumns()
			0 ignored issues – show Bug Best Practice introduced 2017-03-30 19:31 UTC by Report Bug Copy Issue Report The return type of `return $this->replaceCol...modelData->modelHash));` (`Scaffolder\Compilers\AngularJs\TranslateCompiler`) is incompatible with the return type declared by the abstract method `Scaffolder\Compilers\Abs...mpiler::replaceAndStore` of type `string`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
34			->replaceArea()
35			->store(new FileToCompile(false, $this->modelData->modelHash));
36
37			}
38
39			/**
40			* replace columns
41			*
42			* @return $this
43			*/
44			public function replaceArea(){
45			$this->stub = str_replace('{{singular}}', ucwords($this->modelData->tableName), $this->stub);
46			$this->stub = str_replace('{{plural}}', ucwords(CamelCase::pluralize($this->modelData->tableName)), $this->stub);
47			return $this;
48			}
49
50			/**
51			* replace columns
52			*
53			* @return $this
54			*/
55			public function replaceColumns(){
56
57			$columns = [];
58
59			foreach ($this->modelData->fields as $field)
60			{
61			array_push($columns, "\t\t".sprintf('"%s" : "%s"', $field->name, CamelCase::convertToCamelCase($field->name) ));
62			}
63
64			$this->stub = str_replace('{{columns}}', join(",\n", $columns), $this->stub);
65
66			return $this ;
67
68			}
69
70			/**
71			* Get output filename
72			*
73			*
74			* @return $this
75			*/
76			protected function getOutputFilename()
77			{
78			$folder = PathParser::parse($this->scaffolderConfig->generator->paths->pages).$this->modelData->tableName.'/i18n/' ;
79
80			Directory::createIfNotExists($folder, 0755, true);
81
82			return $folder . 'en.json';
			0 ignored issues – show Bug Best Practice introduced 2017-03-30 19:31 UTC by Report Bug Copy Issue Report The return type of `return $folder . 'en.json';` (`string`) is incompatible with the return type declared by the abstract method `Scaffolder\Compilers\Abs...iler::getOutputFilename` of type `Scaffolder\Compilers\AbstractCompiler`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
83			}
84
85			}

codificar / scaffolder

Push — master ( 63d8d6...28be9d )

TranslateCompiler::getOutputFilename() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like