coderius / yii2-hit-counter

src/controllers/HitCounterController.php

<?php
/*
 * @copyright Copyright (C) 2019 Sergio coderius <coderius>
 * @license This program is free software: the MIT License (MIT)
 */

namespace coderius\hitCounter\controllers;

use yii\web\Controller;
use Yii;
use yii\web\Response;
use yii\web\ServerErrorHttpException;
use coderius\hitCounter\services\HitCounterService;
use coderius\hitCounter\models\HitCounterModel;

/**
 * Default controller.
 */
class HitCounterController extends Controller
{
    private $service;

    public function __construct($id, $module, HitCounterService $service, $config = [])
    {
        $this->service = $service;
        parent::__construct($id, $module, $config);
    }
    
    public function actionIndex()
    {
        $request = Yii::$app->request;

It seems like Yii::app->request can also be of type yii\web\Request. However, the property $request is declared as type yii\console\Request. Maybe add an additional type check?

        $modelHitCounter = $this->service->loadModel($request);

It seems like $request can also be of type yii\console\Request; however, parameter $request of coderius\hitCounter\services\HitCounterService::loadModel() does only seem to accept yii\web\Request, maybe add an additional type check?

        if ($modelHitCounter && $modelHitCounter->validate()) {
            try {
                $hit = $this->service->create($modelHitCounter);

The assignment to $hit is dead and can be removed.

                \Yii::$app->response->format = \yii\web\Response::FORMAT_JSON;
                return ['status' => 'success'];
            } catch (\DomainException $e) {
                Yii::$app->errorHandler->logException($e);
                \Yii::$app->response->format = \yii\web\Response::FORMAT_JSON;
                return [
                    'status' => 'error',
                    // 'errors' => $e->getMessage(),
                ];
            }
        }

        \Yii::$app->response->format = \yii\web\Response::FORMAT_JSON;
        return $modelHitCounter->errors;
        // return $modelHitCounter->getAttributes();
    }

}