Contract - Code Metrics - codenix-sv/coingecko-api - Measure and Improve Code Quality continuously with Scrutinizer

Contract A
last analyzed 2020-07-28 05:38 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	50
Duplicated Lines	24 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	3
lcom	1
cbo	1
dl	12
loc	50
ccs	10
cts	10
cp	1
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getContract()	0	4	1
A	getMarketChart()	0	6	1
A	getMarketChartRange()	12	12	1

How to fix Duplicated Code

<?php

declare(strict_types=1);

namespace Codenixsv\CoinGeckoApi\Api;

use Exception;

class Contract extends Api
{
    /**
     * @param string $id
     * @param string $contractAddress
     * @return array
     * @throws Exception
     */
    public function getContract(string $id, string $contractAddress): array
    {
        return $this->get('/coins/' . $id . '/contract/' . $contractAddress);
    }

    /**
     * @param string $id
     * @param string $contractAddress
     * @param string $vsCurrency
     * @param string $days
     * @return array
     * @throws Exception
     */
    public function getMarketChart(string $id, string $contractAddress, string $vsCurrency, string $days): array
    {
        $params = ['days' => $days, 'vs_currency' => $vsCurrency];

        return $this->get('/coins/' . $id . '/contract/' . $contractAddress . '/market_chart', $params);
    }

    /**
     * @param string $id
     * @param string $contractAddress
     * @param string $vsCurrency
     * @param string $from
     * @param string $to
     * @return array
     * @throws Exception
     */
    public function getMarketChartRange(

        string $id,
        string $contractAddress,
        string $vsCurrency,
        string $from,
        string $to
    ): array {
        $params['vs_currency'] = $vsCurrency;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $params['from'] = $from;
        $params['to'] = $to;
        return $this->get('/coins/' . $id . '/contract/' . $contractAddress . '/market_chart/range', $params);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Codenixsv\CoinGeckoApi\Api;
6
7			use Exception;
8
9			class Contract extends Api
10			{
11			/**
12			* @param string $id
13			* @param string $contractAddress
14			* @return array
15			* @throws Exception
16			*/
17	1		public function getContract(string $id, string $contractAddress): array
18			{
19	1		return $this->get('/coins/' . $id . '/contract/' . $contractAddress);
20			}
21
22			/**
23			* @param string $id
24			* @param string $contractAddress
25			* @param string $vsCurrency
26			* @param string $days
27			* @return array
28			* @throws Exception
29			*/
30	1		public function getMarketChart(string $id, string $contractAddress, string $vsCurrency, string $days): array
31			{
32	1		$params = ['days' => $days, 'vs_currency' => $vsCurrency];
33
34	1		return $this->get('/coins/' . $id . '/contract/' . $contractAddress . '/market_chart', $params);
35			}
36
37			/**
38			* @param string $id
39			* @param string $contractAddress
40			* @param string $vsCurrency
41			* @param string $from
42			* @param string $to
43			* @return array
44			* @throws Exception
45			*/
46	1	View Code Duplication	public function getMarketChartRange(
			0 ignored issues – show Duplication introduced 2020-03-25 09:21 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
47			string $id,
48			string $contractAddress,
49			string $vsCurrency,
50			string $from,
51			string $to
52			): array {
53	1		$params['vs_currency'] = $vsCurrency;
			0 ignored issues – show Coding Style Comprehensibility introduced 2020-03-25 09:21 UTC by Report Bug Copy Issue Report `$params` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$params = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
54	1		$params['from'] = $from;
55	1		$params['to'] = $to;
56	1		return $this->get('/coins/' . $id . '/contract/' . $contractAddress . '/market_chart/range', $params);
57			}
58			}
59

codenix-sv / coingecko-api

Contract A last analyzed 2020-07-28 05:38 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

Contract A
last analyzed 2020-07-28 05:38 UTC