TransactionManager::commit() - Code Metrics - codeliner/php-ddd-cargo-sample - Measure and Improve Code Quality continuously with Scrutinizer

TransactionManager::commit() A
last analyzed 2016-03-14 22:33 UTC

↳ Parent: TransactionManager

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php
/*
 * This file is part of the prooph/php-ddd-cargo-sample.
 * (c) Alexander Miertsch <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 * 
 * Date: 27.03.14 - 20:22
 */

namespace Codeliner\CargoBackend\Infrastructure\Persistence\Transaction;

use Doctrine\ORM\EntityManager;

/**
 * Class TransactionManager
 *
 * @package Codeliner\CargoBackend\Infrastructure\Persistence\Transaction
 * @author Alexander Miertsch <[email protected]>
 */
class TransactionManager 
{
    /**
     * @var EntityManager
     */
    private $entityManager;

    /**
     * @param EntityManager $anEntityManager
     */
    public function __construct(EntityManager $anEntityManager)
function someFunction(ManagerRegistry $registry) {
    $em = $registry->getManager();
    $em->getConnection()->beginTransaction();
    try {
        // Do something.
        $em->getConnection()->commit();
    } catch (\Exception $ex) {
        $em->getConnection()->rollback();
        $em->close();

        throw $ex;
    }
}
    {
        $this->entityManager = $anEntityManager;
    }

    /**
     * @return void
     */
    public function beginTransaction()
    {
        $this->entityManager->beginTransaction();
    }

    /**
     * @return void
     */
    public function commit()
    {
        $this->entityManager->commit();
    }

    /**
     * @return void
     */
    public function rollback()
    {
        $this->entityManager->rollback();
    }
}
 

1			<?php
2			/*
3			* This file is part of the prooph/php-ddd-cargo-sample.
4			* (c) Alexander Miertsch <[email protected]>
5			*
6			* For the full copyright and license information, please view the LICENSE
7			* file that was distributed with this source code.
8			*
9			* Date: 27.03.14 - 20:22
10			*/
11
12			namespace Codeliner\CargoBackend\Infrastructure\Persistence\Transaction;
13
14			use Doctrine\ORM\EntityManager;
15
16			/**
17			* Class TransactionManager
18			*
19			* @package Codeliner\CargoBackend\Infrastructure\Persistence\Transaction
20			* @author Alexander Miertsch <[email protected]>
21			*/
22			class TransactionManager
23			{
24			/**
25			* @var EntityManager
26			*/
27			private $entityManager;
28
29			/**
30			* @param EntityManager $anEntityManager
31			*/
32			public function __construct(EntityManager $anEntityManager)
			0 ignored issues – show Bug introduced 2015-12-07 22:25 UTC by Report Bug Copy Issue Report You have injected the EntityManager via parameter `$anEntityManager`. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via `getManager()` each time you need it. The `EntityManager` might become unusable for example if a transaction is rolled back and it gets closed. Let’s assume that somewhere in your application, or in a third-party library, there is code such as the following: function someFunction(ManagerRegistry $registry) { $em = $registry->getManager(); $em->getConnection()->beginTransaction(); try { // Do something. $em->getConnection()->commit(); } catch (\Exception $ex) { $em->getConnection()->rollback(); $em->close(); throw $ex; } } If that code throws an exception and the `EntityManager` is closed. Any other code which depends on the same instance of the `EntityManager` during this request will fail. On the other hand, if you instead inject the `ManagerRegistry`, the `getManager()` method guarantees that you will always get a usable manager instance. Loading history...
33			{
34			$this->entityManager = $anEntityManager;
35			}
36
37			/**
38			* @return void
39			*/
40			public function beginTransaction()
41			{
42			$this->entityManager->beginTransaction();
43			}
44
45			/**
46			* @return void
47			*/
48			public function commit()
49			{
50			$this->entityManager->commit();
51			}
52
53			/**
54			* @return void
55			*/
56			public function rollback()
57			{
58			$this->entityManager->rollback();
59			}
60			}
61

codeliner / php-ddd-cargo-sample

GitHub Access Token became invalid

TransactionManager::commit() A last analyzed 2016-03-14 22:33 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

TransactionManager::commit() A
last analyzed 2016-03-14 22:33 UTC