| Conditions | 1 |
| Paths | 1 |
| Total Lines | 65 |
| Code Lines | 42 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 10 | * @package Subway |
||
| 11 | */ |
||
| 12 | |||
| 13 | if ( ! defined( 'ABSPATH' ) ) { |
||
| 14 | return; |
||
| 15 | } |
||
| 16 | |||
| 17 | add_action( 'admin_menu', 'subway_admin_menu' ); |
||
| 18 | |||
| 19 | add_action( 'admin_init', 'subway_register_settings' ); |
||
| 20 | |||
| 21 | /** |
||
| 22 | * Display 'Subway' link under 'Settings' |
||
| 23 | * @return void |
||
| 24 | */ |
||
| 25 | function subway_admin_menu() { |
||
| 26 | |||
| 27 | add_options_page( 'Subway Settings', 'Subway', 'manage_options', 'subway', 'subway_options_page' ); |
||
| 28 | |||
| 29 | return; |
||
| 30 | } |
||
| 31 | |||
| 32 | |||
| 33 | function subway_register_settings() { |
||
| 34 | |||
| 35 | // Register our settings section. |
||
| 36 | add_settings_section( 'subway-page-visibility-section', __( 'Pages Visibility', 'subway' ), 'subway_section_cb', 'subway-settings-section' ); |
||
| 37 | add_settings_section( 'subway-redirect-section', __( 'Redirect Options', 'subway' ), 'subway_redirect_cb', 'subway-settings-section' ); |
||
| 38 | |||
| 39 | // Register the fields. |
||
| 40 | $fields = array( |
||
| 41 | array( |
||
| 42 | 'id' => 'subway_is_public', |
||
| 43 | 'label' => __( 'Public Website', 'subway' ), |
||
| 44 | 'callback' => 'subway_is_public_form', |
||
| 45 | 'section' => 'subway-settings-section', |
||
| 46 | 'group' => 'subway-page-visibility-section' |
||
| 47 | ), |
||
| 48 | |||
| 49 | array( |
||
| 50 | 'id' => 'subway_login_page', |
||
| 51 | 'label' => __( 'Private Login Page', 'subway' ), |
||
| 52 | 'callback' => 'subway_login_page_form', |
||
| 53 | 'section' => 'subway-settings-section', |
||
| 54 | 'group' => 'subway-page-visibility-section' |
||
| 55 | ), |
||
| 56 | array( |
||
| 57 | 'id' => 'subway_public_post', |
||
| 58 | 'label' => __( 'Public Posts IDs', 'subway' ), |
||
| 59 | 'callback' => 'subway_public_post', |
||
| 60 | 'section' => 'subway-settings-section', |
||
| 61 | 'group' => 'subway-page-visibility-section' |
||
| 62 | ), |
||
| 63 | |||
| 64 | array( |
||
| 65 | 'id' => 'subway_redirect_type', |
||
| 66 | 'label' => __( 'Redirect Type', 'subway' ), |
||
| 67 | 'callback' => 'subway_redirect_option_form', |
||
| 68 | 'section' => 'subway-settings-section', |
||
| 69 | 'group' => 'subway-redirect-section' |
||
| 70 | ), |
||
| 71 | array( |
||
| 72 | 'id' => 'subway_redirect_wp_admin', |
||
| 73 | 'label' => __( 'Block <em>wp-admin</em> Access', 'subway' ), |
||
| 74 | 'callback' => 'subway_lock_wp_admin', |
||
| 75 | 'section' => 'subway-settings-section', |
||
| 114 | } |