Subway\Metabox

Complexity

Total Complexity

30

Size/Duplication

Total Lines	306
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	3
Bugs	0	Features	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	17	1
A	initMetabox()	0	4	1
A	addMetabox()	0	15	2
A	visibilityMetabox()	0	43	2
B	saveVisibilityMetabox()	0	60	10
A	saveMetaboxValues()	0	5	1
A	getPostTypes()	0	13	2
A	isNonceValid()	0	8	3
A	isPostPrivate()	0	23	5
A	isPostPublic()	0	12	3

<?php
/**
 * This file is part of the Subway WordPress Plugin Package.
 * This file contains the class which handles the metabox of the plugin.
 *
 * (c) Jasper Jardin <jasper@useissuestabinstead.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * PHP Version 5.4
 *
 * @category Subway\Metabox
 * @package  Subway
 * @author   Jasper J. <emailnotdisplayed@domain.tld>
 * @license  http://opensource.org/licenses/gpl-license.php GNU Public License
 * @version  GIT:github.com/codehaiku/subway
 * @link     github.com/codehaiku/subway The Plugin Repository
 */

namespace Subway;

if (! defined('ABSPATH') ) {
    return;
}

/**
 * Subway Metabox methods.
 *
 * @category Subway\Metabox
 * @package  Subway
 * @author   Jasper J. <emailnotdisplayed@domain.tld>
 * @license  http://opensource.org/licenses/gpl-license.php GNU Public License
 * @link     github.com/codehaiku/subway The Plugin Repository
 * @since    2.0.9
 */
final class Metabox
{

    /**
     * Subway visibility meta value,
     *
     * @since 2.0.9
     * @const string VISIBILITY_METAKEY
     */
    const VISIBILITY_METAKEY = 'subway_visibility_meta_key';

    /**
     * Registers and update metabox with its intended method below.
     *
     * @since  2.0.9
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct()
    {
        add_action(
            'add_meta_boxes',
            array(
            $this,
            'addMetabox'
            )
        );
        add_action(
            'save_post',
            array(
            $this,
            'saveMetaboxValues'
            )
        );
    }

    /**
     * Initialize metabox
     *
     * @since  2.0.9
     * @access public
     * @return void
     */
    public static function initMetabox()
    {
        new Metabox();
    }

    /**
     * Initialize metabox
     *
     * @since  2.0.9
     * @access public
     * @return void
     */
    public function addMetabox()
    {
        $post_types = $this->getPostTypes();

Are you sure the assignment to $post_types is correct as $this->getPostTypes() (which targets Subway\Metabox::getPostTypes()) seems to always return null.

        foreach ( $post_types as $post_type => $value ) {

The expression $post_types of type null is not traversable.

            add_meta_box(
                'subway_visibility_metabox',
                esc_html__('Subway: Visibility Option', 'subway'),
                array( $this, 'visibilityMetabox' ),
                $post_type,
                'side',
                'low'
            );
        }
    }

    /**
     * This method displays the Subway Visibility checkbox.
     *
     * @param object $post Contains data from the current post.
     *
     * @since  2.0.9
     * @access public
     * @return void
     */
    public function visibilityMetabox( $post )
    {
        $howto = __(
            'Choose the accessibility of this page from the options above.',
            'subway'
        );
      
        $private_setting_label = __( 'Members Only', 'subway'  );

$private_setting_label is not used, you could remove the assignment.

        $is_post_public          = self::isPostPublic($post->ID);

$is_post_public is not used, you could remove the assignment.

        $is_post_private         = self::isPostPrivate($post->ID);

        // Make sure the form request comes from WordPress
        wp_nonce_field(  basename(__FILE__),  'subway_post_visibility_nonce' );

        // Disable the options (radio) when site is selected as public
        ?>
        
        <?php if ( ! Options::isPublicSite() ):  ?>
        <?php // Site is private. Give them some Beer! ?>
            <p>
                <label class="subway-visibility-settings-checkbox-label" for="subway-visibility-public">
                    <input type="radio" class="subway-visibility-settings-radio" id="subway-visibility-public" name="subway-visibility-settings" value="public" <?php echo checked( false, $is_post_private, false); ?>>
                    <?php esc_html_e( 'Public','subway') ?>
                </label>
            </p>
            <p>
                <label class="subway-visibility-settings-checkbox-label" for="subway-visibility-private">
                    <input type="radio" class="subway-visibility-settings-radio" id="subway-visibility-private" name="subway-visibility-settings"
                    value="private" <?php echo checked( true, $is_post_private, false); ?>>
                    <?php esc_html_e( 'Members Only','subway') ?>
                 </label>
            </p>
            <p class="howto"><?php echo esc_html($howto); ?></p>
        <?php else: ?>
            <?php // Site is public! Explain to them ?>
            <p><em>
                <?php esc_html_e('You have chosen to make your site public inside Settings > Subway. Make your site private so that you can select visibility options.', 'subway'); ?>
            </em>
            </p>
        <?php endif; ?>
        <?php
    }

    /**
     * This method verify if nonce is valid then updates a post_meta.
     *
     * @param integer $post_id Contains ID of the current post.
     *
     * @since  2.0.9
     * @access public
     * @return boolean false Returns false if nonce is not valid.
     */
    public function saveVisibilityMetabox( $post_id = '' )
    {

        $public_posts     = Options::getPublicPostsIdentifiers();

        $posts_implode    = '';

$posts_implode is not used, you could remove the assignment.

        $visibility_field = 'subway-visibility-settings';

        $visibility_nonce = filter_input(
            INPUT_POST,
            'subway_post_visibility_nonce',
            FILTER_SANITIZE_STRING
        );

        $post_visibility = filter_input(
            INPUT_POST,
            $visibility_field,
            FILTER_SANITIZE_STRING
        );

        $is_valid_visibility_nonce = self::isNonceValid(
            $visibility_nonce
        );

        // verify taxonomies meta box nonce
        if (false === $is_valid_visibility_nonce ) {
            return;
        }

        if (! empty($post_visibility) ) {
            if (! empty($post_id) ) {
                if ('public' === $post_visibility ) {
                    if (! in_array($post_id, $public_posts) ) {
                        array_push($public_posts, $post_id);
                    }
                }
                if ('private' === $post_visibility ) {
                    unset($public_posts[ array_search($post_id, $public_posts) ]);
                }
            }
        }

        if (! empty($post_id) ) {
            $posts_implode = implode(", ", $public_posts);

            if ('inherit' !== get_post_status($post_id) ) {

                if (true === $is_valid_visibility_nonce ) {
                    update_option('subway_public_post', $posts_implode);
                    update_post_meta(
                        $post_id,
                        self::VISIBILITY_METAKEY,
                        $post_visibility
                    );
                }

            }
        }
    }

    /**
     * This method runs the methods that handles the update for a post_meta.
     *
     * @param integer $post_id Contains ID of the current post.
     *
     * @since  2.0.9
     * @access public
     * @return boolean false Returns false if nonce is not valid.
     */
    public function saveMetaboxValues( $post_id )
    {
        $this->saveVisibilityMetabox($post_id);
        return;
    }

    /**
     * Initialize metabox arguments.
     *
     * @param array  $args   The arguments for the get_post_types().
     * @param string $output Your desired output for the data.
     *
     * @since  2.0.9
     * @access public
     * @return void
     */
    public static function getPostTypes( $args = '', $output = '' )
    {
        if (empty($args) ) {
            $args = array(
            'public'   => true,
            );
            $output = 'names';
        }

        $post_types = get_post_types($args, $output);

        return $post_types;
    }

    /**
     * This method verify if nonce is valid.
     *
     * @param mixed $nonce the name of a metabox nonce.
     *
     * @since  2.0.9
     * @access public
     * @return boolean true Returns true if nonce is valid.
     */
    public function isNonceValid( $nonce )
    {
        if (!isset($nonce) || !wp_verify_nonce($nonce, basename(__FILE__)) ) {
            return;
        }

        return true;
    }

    /**
     * Checks if a post is set to private.
     *
     * @param integer $post_id Contains ID of the current post.
     *
     * @since  2.0.9
     * @access public
     * @return boolean true Returns true if post is private. Otherwise false.
     */
    public static function isPostPrivate( $post_id )
    {
        $meta_value = '';

$meta_value is not used, you could remove the assignment.

        if ( ! empty( $post_id ) ) {
            $meta_value = get_post_meta($post_id, self::VISIBILITY_METAKEY, true);

            // New page or old pages that don't have Subway'\ Visibility Options
            if ( empty ( $meta_value ) ) {
                // Get the value from the general settings (Settings > Subway)
                $is_site_public = Options::isPublicSite();
                if ( ! $is_site_public ) {
                    // It's private.
                    return true;
                }
            }
            if ('private' === $meta_value ) {
                return true;
            }
        }

        return false;
    }

    /**
     * Checks if a post is set to public.
     *
     * @param integer $post_id Contains ID of the current post.
     *
     * @since  2.0.9
     * @access public
     * @return boolean true Returns true if post is public. Otherwise false.
     */
    public static function isPostPublic( $post_id )
    {
        $public_post = Options::getPublicPostsIdentifiers();

        if (! empty($post_id) ) {
            if (! in_array($post_id, $public_post, true) ) {
                return true;
            }
        }

        return false;
    }

}