| Conditions | 3 |
| Paths | 4 |
| Total Lines | 110 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 74 | public function registerSettings() |
||
| 75 | { |
||
| 76 | |||
| 77 | // Register our settings section. |
||
| 78 | add_settings_section( |
||
| 79 | 'subway-page-visibility-section', __('Pages Visibility', 'subway'), |
||
| 80 | array( $this, 'sectionCallback' ), 'subway-settings-section' |
||
| 81 | ); |
||
| 82 | |||
| 83 | // Register Redirect Options pages. |
||
| 84 | add_settings_section( |
||
| 85 | 'subway-redirect-section', __('Redirect Options', 'subway'), |
||
| 86 | array( $this, 'redirectCallback' ), 'subway-settings-section' |
||
| 87 | ); |
||
| 88 | |||
| 89 | $is_public_site = Options::isPublicSite(); |
||
| 90 | $hidden_class = ''; |
||
| 91 | |||
| 92 | if ( $is_public_site ) { |
||
| 93 | $hidden_class = 'hidden'; |
||
| 94 | } |
||
| 95 | |||
| 96 | // Register the fields. |
||
| 97 | $fields = array( |
||
| 98 | |||
| 99 | array( |
||
| 100 | 'id' => 'subway_login_page', |
||
| 101 | 'label' => __('Login Page', 'subway'), |
||
| 102 | 'callback' => 'subway_login_page_form', |
||
| 103 | 'section' => 'subway-settings-section', |
||
| 104 | 'group' => 'subway-page-visibility-section', |
||
| 105 | 'args' => array( |
||
| 106 | 'label_for' => 'subway_login_page', |
||
| 107 | 'class' => 'subway_login_page-option', |
||
| 108 | ), |
||
| 109 | ), |
||
| 110 | array( |
||
| 111 | 'id' => 'subway_public_post_deprecated', |
||
| 112 | 'label' => __('Public Posts IDs', 'subway'), |
||
| 113 | 'callback' => 'subway_public_post', |
||
| 114 | 'section' => 'subway-settings-section', |
||
| 115 | 'group' => 'subway-page-visibility-section', |
||
| 116 | 'args' => array( |
||
| 117 | 'label_for' => 'subway_public_post_deprecated', |
||
| 118 | 'class' => 'subway_public_post_deprecated-option ' . $hidden_class, |
||
| 119 | ), |
||
| 120 | ), |
||
| 121 | array( |
||
| 122 | 'id' => 'subway_is_public', |
||
| 123 | 'label' => __('Public Website', 'subway'), |
||
| 124 | 'callback' => 'subway_is_public_form', |
||
| 125 | 'section' => 'subway-settings-section', |
||
| 126 | 'group' => 'subway-page-visibility-section', |
||
| 127 | 'args' => array( |
||
| 128 | 'label_for' => 'subway_is_public', |
||
| 129 | 'class' => 'subway_is_public-option', |
||
| 130 | ), |
||
| 131 | ), |
||
| 132 | |||
| 133 | array( |
||
| 134 | 'id' => 'subway_redirect_type', |
||
| 135 | 'label' => __('Redirect Type', 'subway'), |
||
| 136 | 'callback' => 'subway_redirect_option_form', |
||
| 137 | 'section' => 'subway-settings-section', |
||
| 138 | 'group' => 'subway-redirect-section', |
||
| 139 | 'args' => array( |
||
| 140 | 'label_for' => 'subway_redirect_type', |
||
| 141 | 'class' => 'subway_redirect_type-option ', |
||
| 142 | ), |
||
| 143 | ), |
||
| 144 | array( |
||
| 145 | 'id' => 'subway_redirect_wp_admin', |
||
| 146 | 'label' => __('WP Login Link', 'subway'), |
||
| 147 | 'callback' => 'subway_lock_wp_admin', |
||
| 148 | 'section' => 'subway-settings-section', |
||
| 149 | 'group' => 'subway-redirect-section', |
||
| 150 | 'args' => array( |
||
| 151 | 'label_for' => 'subway_redirect_wp_admin', |
||
| 152 | 'class' => 'subway_redirect_wp_admin-option ', |
||
| 153 | ), |
||
| 154 | ), |
||
| 155 | ); |
||
| 156 | |||
| 157 | foreach ( $fields as $field ) { |
||
| 158 | |||
| 159 | add_settings_field( |
||
| 160 | $field['id'], $field['label'], |
||
| 161 | $field['callback'], $field['section'], |
||
| 162 | $field['group'], $field['args'] |
||
| 163 | ); |
||
| 164 | |||
| 165 | register_setting('subway-settings-group', $field['id']); |
||
| 166 | |||
| 167 | $file = str_replace('_', '-', $field['callback']); |
||
| 168 | |||
| 169 | include_once trailingslashit(SUBWAY_DIR_PATH) . |
||
| 170 | 'settings-fields/field-' . sanitize_title($file) . '.php'; |
||
| 171 | |||
| 172 | } |
||
| 173 | |||
| 174 | // Register Redirect Page ID Settings. |
||
| 175 | register_setting('subway-settings-group', 'subway_redirect_page_id'); |
||
| 176 | |||
| 177 | // Register Redirect Custom URL Settings. |
||
| 178 | register_setting('subway-settings-group', 'subway_redirect_custom_url'); |
||
| 179 | |||
| 180 | $this->registerSettingsScripts(); |
||
| 181 | |||
| 182 | return; |
||
| 183 | } |
||
| 184 | |||
| 265 |