RegistryManager - Code Metrics - codeconsortium/CCDNForumForumBundle - Measure and Improve Code Quality continuously with Scrutinizer

RegistryManager A
last analyzed 2016-02-10 18:35 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Metric	Value
wmc	2
lcom	1
cbo	1
dl	0
loc	25
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	createRegistry()	0	4	1
A	saveRegistry()	0	6	1

<?php

/*
 * This file is part of the CCDNForum ForumBundle
 *
 * (c) CCDN (c) CodeConsortium <http://www.codeconsortium.com/>
 *
 * Available on github <http://www.github.com/codeconsortium/>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace CCDNForum\ForumBundle\Model\Component\Manager;

use CCDNForum\ForumBundle\Model\Component\Manager\ManagerInterface;
use CCDNForum\ForumBundle\Model\Component\Manager\BaseManager;
use CCDNForum\ForumBundle\Entity\Registry;

/**
 *
 * @category CCDNForum
 * @package  ForumBundle
 *
 * @author   Reece Fowell <[email protected]>
 * @license  http://opensource.org/licenses/MIT MIT
 * @version  Release: 2.0
 * @link     https://github.com/codeconsortium/CCDNForumForumBundle
 *
 */
class RegistryManager extends BaseManager implements ManagerInterface
{
    /**
     *
     * @access public
     * @return \CCDNForum\ForumBundle\Entity\Registry
     */
    public function createRegistry()
    {
        return $this->gateway->createRegistry();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    /**
     *
     * @access public
     * @param  \CCDNForum\ForumBundle\Entity\Registry                         $registry
     * @return \CCDNForum\ForumBundle\Model\Component\Manager\RegistryManager
     */
    public function saveRegistry(Registry $registry)
    {
        $this->gateway->saveRegistry($registry);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        return $this;
    }
}


1			<?php
2
3			/*
4			* This file is part of the CCDNForum ForumBundle
5			*
6			* (c) CCDN (c) CodeConsortium <http://www.codeconsortium.com/>
7			*
8			* Available on github <http://www.github.com/codeconsortium/>
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace CCDNForum\ForumBundle\Model\Component\Manager;
15
16			use CCDNForum\ForumBundle\Model\Component\Manager\ManagerInterface;
17			use CCDNForum\ForumBundle\Model\Component\Manager\BaseManager;
18			use CCDNForum\ForumBundle\Entity\Registry;
19
20			/**
21			*
22			* @category CCDNForum
23			* @package ForumBundle
24			*
25			* @author Reece Fowell <[email protected]>
26			* @license http://opensource.org/licenses/MIT MIT
27			* @version Release: 2.0
28			* @link https://github.com/codeconsortium/CCDNForumForumBundle
29			*
30			*/
31			class RegistryManager extends BaseManager implements ManagerInterface
32			{
33			/**
34			*
35			* @access public
36			* @return \CCDNForum\ForumBundle\Entity\Registry
37			*/
38			public function createRegistry()
39			{
40			return $this->gateway->createRegistry();
			0 ignored issues – show Bug introduced 2016-02-10 18:28 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CCDNForum\ForumBundle\Mo...ateway\GatewayInterface` as the method `createRegistry()` does only exist in the following implementations of said interface: `CCDNForum\ForumBundle\Mo...Gateway\RegistryGateway`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
41			}
42
43			/**
44			*
45			* @access public
46			* @param \CCDNForum\ForumBundle\Entity\Registry $registry
47			* @return \CCDNForum\ForumBundle\Model\Component\Manager\RegistryManager
48			*/
49			public function saveRegistry(Registry $registry)
50			{
51			$this->gateway->saveRegistry($registry);
			0 ignored issues – show Bug introduced 2016-02-10 18:28 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CCDNForum\ForumBundle\Mo...ateway\GatewayInterface` as the method `saveRegistry()` does only exist in the following implementations of said interface: `CCDNForum\ForumBundle\Mo...Gateway\RegistryGateway`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
52
53			return $this;
54			}
55			}
56

codeconsortium / CCDNForumForumBundle

GitHub Access Token became invalid

RegistryManager A last analyzed 2016-02-10 18:35 UTC

Complexity

Size/Duplication

Coupling/Cohesion

2 Methods

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

RegistryManager A
last analyzed 2016-02-10 18:35 UTC