Complex classes like Container often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Container, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
29 | class Container implements ContainerInterface |
||
30 | { |
||
31 | |||
32 | /** |
||
33 | * Holds all resolved or resolvable instances into the container. |
||
34 | * |
||
35 | * @var array |
||
36 | */ |
||
37 | |||
38 | protected $collection; |
||
39 | |||
40 | /** |
||
41 | * Class specific defined dependencies. |
||
42 | * |
||
43 | * @var array |
||
44 | */ |
||
45 | |||
46 | protected $dependencies; |
||
47 | |||
48 | /** |
||
49 | * Cache of classes inspector and resolver. |
||
50 | * |
||
51 | * @var array |
||
52 | */ |
||
53 | |||
54 | protected $resolving; |
||
55 | |||
56 | /** |
||
57 | * Cache of classes dependencies in callbacks ready for resolution. |
||
58 | * |
||
59 | * @var array |
||
60 | */ |
||
61 | |||
62 | protected $resolved; |
||
63 | |||
64 | /** |
||
65 | * Call a user function injecting the dependencies. |
||
66 | * |
||
67 | * @param string|Closure $function The function or the user function name. |
||
68 | * @param array $parameters The predefined dependencies. |
||
69 | * |
||
70 | * @return mixed |
||
71 | */ |
||
72 | |||
73 | 3 | public function call($function, array $parameters = []) |
|
91 | |||
92 | /** |
||
93 | * Makes an element or class injecting automatically all the dependencies. |
||
94 | * |
||
95 | * @param string $abstract The class name or container element name to make. |
||
96 | * @param array $parameters Specific parameters definition. |
||
97 | * @param bool $force Specify if a new element must be given and the dependencies must have be recalculated. |
||
98 | * |
||
99 | * @throws \Psr\Container\Exception\ContainerException |
||
100 | * @return object|null |
||
101 | */ |
||
102 | |||
103 | 18 | public function make($abstract, array $parameters = [], bool $force = false) |
|
115 | |||
116 | /** |
||
117 | * Construct a class and all the dependencies using the reflection library of PHP. |
||
118 | * |
||
119 | * @param string $abstract The class name or container element name to make. |
||
120 | * @param bool $force Specify if a new element must be given and the dependencies must have be recalculated. |
||
121 | * |
||
122 | * @throws ReflectionException |
||
123 | * @return Closure |
||
124 | */ |
||
125 | |||
126 | 18 | protected function construct(string $abstract, bool $force) : Closure |
|
150 | |||
151 | /** |
||
152 | * Resolve all the given class reflected dependencies. |
||
153 | * |
||
154 | * @param string $abstract The class name or container element name to resolve dependencies. |
||
155 | * @param ReflectionParameter $dependency The class dependency to be resolved. |
||
156 | * @param bool $force Specify if the dependencies must be recalculated. |
||
157 | * |
||
158 | * @return Object |
||
159 | */ |
||
160 | |||
161 | 7 | protected function resolve(string $abstract, ReflectionParameter $dependency, bool $force) |
|
171 | |||
172 | /** |
||
173 | * Generate the dependencies callbacks to jump some conditions in every dependency creation. |
||
174 | * |
||
175 | * @param string $abstract The class name or container element name to resolve dependencies. |
||
176 | * @param ReflectionParameter $dependency The class dependency to be resolved. |
||
177 | * |
||
178 | * @return Closure |
||
179 | */ |
||
180 | |||
181 | 7 | protected function generate(string $abstract, ReflectionParameter $dependency) : Closure |
|
198 | |||
199 | /** |
||
200 | * Reset the container, removing all the elements, cache and options. |
||
201 | * |
||
202 | * @return void |
||
203 | */ |
||
204 | |||
205 | 1 | public function flush() |
|
212 | |||
213 | /** |
||
214 | * Finds an entry of the container by its identifier and returns it. |
||
215 | * |
||
216 | * @param string $abstract Identifier of the entry to look for. |
||
217 | * |
||
218 | * @throws \Psr\Container\Exception\NotFoundException No entry was found for this identifier. |
||
219 | * @throws \Psr\Container\Exception\ContainerException Error while retrieving the entry. |
||
220 | * |
||
221 | * @return mixed Entry. |
||
222 | */ |
||
223 | 6 | public function get($abstract) |
|
239 | |||
240 | /** |
||
241 | * Returns true if the container can return an entry for the given identifier. |
||
242 | * Returns false otherwise. |
||
243 | * |
||
244 | * `has($abstract)` returning true does not mean that `get($abstract)` will not throw an exception. |
||
245 | * It does however mean that `get($abstract)` will not throw a `NotFoundException`. |
||
246 | * |
||
247 | * @param string $abstract Identifier of the entry to look for. |
||
248 | * |
||
249 | * @return boolean |
||
250 | */ |
||
251 | |||
252 | 2 | public function has($abstract) |
|
256 | |||
257 | /** |
||
258 | * Verify if an element has a singleton instance. |
||
259 | * |
||
260 | * @param string The class name or container element name to resolve dependencies. |
||
261 | * @return bool |
||
262 | */ |
||
263 | |||
264 | 5 | public function isSingleton(string $abstract) : bool |
|
268 | |||
269 | /** |
||
270 | * Bind a new element to the container. |
||
271 | * |
||
272 | * @param string $abstract The alias name that will be used to call the element. |
||
273 | * @param string|closure $concrete The element class name, or an closure that makes the element. |
||
274 | * @param bool $shared Define if the element will be a singleton instance. |
||
275 | * |
||
276 | * @return \Codeburner\Container\Container |
||
277 | */ |
||
278 | |||
279 | 12 | public function set(string $abstract, $concrete, bool $shared = false) : self |
|
293 | |||
294 | /** |
||
295 | * Bind a new element to the container IF the element name not exists in the container. |
||
296 | * |
||
297 | * @param string $abstract The alias name that will be used to call the element. |
||
298 | * @param string|closure $concrete The element class name, or an closure that makes the element. |
||
299 | * @param bool $shared Define if the element will be a singleton instance. |
||
300 | * |
||
301 | * @return \Codeburner\Container\Container |
||
302 | */ |
||
303 | |||
304 | 1 | public function setIf(string $abstract, $concrete, bool $shared = false) : self |
|
312 | |||
313 | /** |
||
314 | * Bind an specific instance to a class dependency. |
||
315 | * |
||
316 | * @param string $class The class full name. |
||
317 | * @param string $dependencyName The dependency full name. |
||
318 | * @param string|closure $dependency The specific object class name or a classure that makes the element. |
||
319 | * |
||
320 | * @return \Codeburner\Container\Container |
||
321 | */ |
||
322 | |||
323 | 3 | public function setTo(string $class, string $dependencyName, $dependency) : self |
|
341 | |||
342 | /** |
||
343 | * Bind an element that will be construct only one time, and every call for the element, |
||
344 | * the same instance will be given. |
||
345 | * |
||
346 | * @param string $abstract The alias name that will be used to call the element. |
||
347 | * @param string|closure $concrete The element class name, or an closure that makes the element. |
||
348 | * |
||
349 | * @return \Codeburner\Container\Container |
||
350 | */ |
||
351 | |||
352 | 3 | public function singleton(string $abstract, $concrete) : self |
|
358 | |||
359 | /** |
||
360 | * Bind an object to the container. |
||
361 | * |
||
362 | * @param string $abstract The alias name that will be used to call the object. |
||
363 | * @param object $instance The object that will be inserted. |
||
364 | * |
||
365 | * @throws \Psr\Container\Exception\ContainerException When $instance is not an object. |
||
366 | * @return \Codeburner\Container\Container |
||
367 | */ |
||
368 | |||
369 | 1 | public function instance(string $abstract, $instance) : self |
|
379 | |||
380 | /** |
||
381 | * Modify an element with a given function that receive the old element as argument. |
||
382 | * |
||
383 | * @param string $abstract The alias name that will be used to call the element. |
||
384 | * @param closure $extension The function that receives the old element and return a new or modified one. |
||
385 | * |
||
386 | * @throws \Psr\Container\Exception\NotFoundException When no element was found with $abstract key. |
||
387 | * @return \Codeburner\Container\Container |
||
388 | */ |
||
389 | |||
390 | 2 | public function extend(string $abstract, closure $extension) : self |
|
408 | |||
409 | /** |
||
410 | * Makes an resolvable element an singleton. |
||
411 | * |
||
412 | * @param string $abstract The alias name that will be used to call the element. |
||
413 | * |
||
414 | * @throws \Psr\Container\Exception\NotFoundException When no element was found with $abstract key. |
||
415 | * @throws \Psr\Container\Exception\ContainerException When the element on $abstract key is not resolvable. |
||
416 | * |
||
417 | * @return \Codeburner\Container\Container |
||
418 | */ |
||
419 | |||
420 | 1 | public function share(string $abstract) : self |
|
434 | |||
435 | } |
||
436 |