UserManagement\Forms\ProfileForm

Complexity

Total Complexity

8

Size/Duplication

Total Lines	75
Duplicated Lines	0 %

Test Coverage

Coverage

96.55%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getFormActions()	0	4	1
A	getFormFields()	0	9	1
A	getCustomMessage()	0	3	1
A	doSubmitProfile()	0	13	3
A	setsiteConfig()	0	3	1

<?php
namespace UserManagement\Forms;

use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\Form;
use SilverStripe\Forms\ReadOnlyField;
use SilverStripe\Forms\FormAction;
use SilverStripe\SiteConfig\SiteConfig;
use SilverStripe\Security\Security;

/**
 * Class ProfileForm
 *
 * @package user-management
 */
class ProfileForm extends SignUpForm
{
    /**
     * @var \SilverStripe\SiteConfig\SiteConfig
     */
    protected $siteConfig;

    public function __construct($controller, $name)
    {
        $this->setAttribute('id', 'ProfileForm');
        $this->setsiteConfig();
        parent::__construct($controller, $name, $this->getFormFields($controller), $this->getFormActions());

The call to UserManagement\Forms\SignUpForm::__construct() has too many arguments starting with $this->getFormFields($controller).

    }

    /**
     * Required FieldList creation on a ProfileForm
     *
     * @return \SilverStripe\Forms\FieldList
     */
    protected function getFormFields($controller = null)
    {
        $member = Security::getCurrentUser();
        $fieldList = parent::getFormFields();
        $fieldList->removeByName('Password');
        $fieldList->removeByName('Email');
        $this->setAttribute('id', 'ProfileForm');
        $fieldList->insertBefore(ReadOnlyField::create("Email", "Email", $member->Email), "Mobile");

'Mobile' of type string is incompatible with the type SilverStripe\Forms\FormField expected by parameter $item of SilverStripe\Forms\FieldList::insertBefore().

        return $fieldList;
    }

    /**
     * Returns the Form action
     * @return FieldList Actions for this form.
     */
    protected function getFormActions()
    {
        return FieldList::create(
            FormAction::create("doSubmitProfile", "Submit")
        );
    }

    /**
     * Form action, updates the user profile.
     * @return \SilverStripe\Control\HTTPResponse
     */
    public function doSubmitProfile($data, Form $form)

The parameter $data is not used and could be removed.

    {
        $member = Security::getCurrentUser();
        if ($member) {

$member is of type SilverStripe\Security\Member, thus it always evaluated to true.

                $form->saveInto($member);
                $member->write();
                $msg = $this->getCustomMessage('ProfileUpdateSuccess') != ""
                    ? $this->getCustomMessage('ProfileUpdateSuccess') : "Profile updated!";
                $form->sessionMessage($msg, 'good');
        } else {
            return $this->controller->redirect($this->siteConfig->LoginUrl()->URLSegment);
        }
        return $this->controller->redirectBack();
    }

    /**
     * Return the Message from siteconfig
     * @return string
     */
    public function getCustomMessage($field)
    {
        return $this->siteConfig->$field;
    }
   
    /**
     * Assign siteconfig object
     */
    protected function setsiteConfig()
    {
        $this->siteConfig = SiteConfig::current_site_config();
    }
}