codeat3 / foaas-client

src/ResponseFormatValidator.php

<?php

namespace Codeat3\FoaasClient;

use Codeat3\FoaasClient\Exceptions\InvalidResponse;
use Codeat3\FoaasClient\Response\FoaasResponse;

class ResponseFormatValidator
{
    /**
     * Validates and returns the arrays.
     *
     * @param array $responseFormats
     *
     * @return array
     */
    public static function validate(array $responseFormats): array
    {
        if (
            $responseFormats

The expression $responseFormats of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            && is_array($responseFormats)
            && count($responseFormats) > 0
        ) {
            return array_map(static function (string $class) {
                if (! is_a($class, FoaasResponse::class, true)) {
                    throw new InvalidResponse('A class needs to implement \'Codeat3\FoaasClient\Response\FoaasResponse\'');
                }

                return $class;
            }, $responseFormats);
        }

        return [];
    }
}