Issues in checkedTrait.php (master) - Issues in master - code4interactive/forms - Measure and Improve Code Quality continuously with Scrutinizer

Issues (21)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Traits/checkedTrait.php (7 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Code4\Forms\Traits;

trait checkedTrait
{
    protected $checked = false;

    /**
     * Sprawdza czy pole powinno być zaznaczone
     * @param string|array $value
     * @param string $oKey
     * @return $this
     */
    public function checked($value = null, $oKey = null) {

        if (is_null($value)) {
            return $this;
        }

        //Checkboxy $this->value powinny mieć wyłącznie jako "string"
        if (is_array($this->value)) {
            $this->value = $this->value[0];
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }

        $this->checked = false;

        if (is_array($value)) {
            if (isAssoc($value)) {
                //W przypadku tablicy asocjacyjnej ($key=>$val) jeśli $val jest typu bool to znaczy że $key == $this->value
                if (is_bool(array_values($value)[0])) {
                    if (array_key_exists($this->value, $value)) {
                        $this->checked = $value[$this->value];
                        return $this;
                    }
                } else {
                    //W przeciwnym przypdaku uznajemy że tablica przechowuje pary klucz => wartosc odpowiadające $this->name => $this->value
                    if (array_key_exists($this->name, $value)) {
                        $this->checked = $value[$this->name] == $this->value;
class MyClass { }

$x = new MyClass();
$x->foo = true;
                        return $this;
                    }
                }
            } else {
                $this->checked = in_array($this->value, $value);
                return $this;
            }

            return $this;
        }

        //Jeżeli jest kolekcją obiektów to obowiązkowo należy podać drugi parametr jakim jest nazwa pola
        if (is_object($value) && $oKey) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            foreach($value as $v)
            {
                if (property_exists($v, $oKey))
                {
                    $prop = $v->$oKey;
                    if (is_bool($prop))
                    {
                        $this->checked = $prop;
                    } else
                    {
                        $this->checked = $prop == $this->value;
                    }
                }
            }
            return $this;
        }

        //Jeżeli jest obiektem
        if (is_object($value) && $oKey) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            if (property_exists($value, $oKey))
            {
                $prop = $value->$oKey;
                if (is_bool($prop))
                {
                    $this->checked = $prop;
                } else
                {
                    $this->checked = $prop == $this->value;
                }
            }
        }

        if (is_bool($value)) {
            $this->checked = $value;
            return $this;
        }

        $this->checked = $this->value == $value;

        return $this;
    }

    /**
     * Pobiera atrybut checked dla html
     * @return string
     */
    public function getChecked() {
        return $this->checked ? 'checked' : '';
    }

    /**
     * Dla pól checkbox value powinno ustawiać checked na true lub false a nie zastepowac warość
     * @param null $value
     * @param null $key
     * @return null|string
     */
    public function value($value = null, $key = null) {
        if (is_null($value)) {
            return parent::value();
        }
        return $this->checked($value, $key);
    }

    /**
     * Jeżeli chcemy zastąpić wartość
     * @param null $value
     * @param null $key
     */
    public function setValue($value = null, $key = null) {
        return parent::value($value, $key);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

}

1		<?php
2		namespace Code4\Forms\Traits;
3
4		trait checkedTrait
5		{
6		protected $checked = false;
7
8		/**
9		* Sprawdza czy pole powinno być zaznaczone
10		* @param string\|array $value
11		* @param string $oKey
12		* @return $this
13		*/
14		public function checked($value = null, $oKey = null) {
15
16		if (is_null($value)) {
17		return $this;
18		}
19
20		//Checkboxy $this->value powinny mieć wyłącznie jako "string"
21		if (is_array($this->value)) {
22		$this->value = $this->value[0];
		0 ignored issues – show Bug introduced 2015-11-23 16:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `value` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
23		}
24
25		$this->checked = false;
26
27		if (is_array($value)) {
28		if (isAssoc($value)) {
29		//W przypadku tablicy asocjacyjnej ($key=>$val) jeśli $val jest typu bool to znaczy że $key == $this->value
30		if (is_bool(array_values($value)[0])) {
31		if (array_key_exists($this->value, $value)) {
32		$this->checked = $value[$this->value];
33		return $this;
34		}
35		} else {
36		//W przeciwnym przypdaku uznajemy że tablica przechowuje pary klucz => wartosc odpowiadające $this->name => $this->value
37		if (array_key_exists($this->name, $value)) {
38		$this->checked = $value[$this->name] == $this->value;
		0 ignored issues – show Bug introduced 2015-11-23 16:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `name` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
39		return $this;
40		}
41		}
42		} else {
43		$this->checked = in_array($this->value, $value);
44		return $this;
45		}
46
47		return $this;
48		}
49
50		//Jeżeli jest kolekcją obiektów to obowiązkowo należy podać drugi parametr jakim jest nazwa pola
51	View Code Duplication	if (is_object($value) && $oKey) {
		0 ignored issues – show Bug Best Practice introduced 2015-11-23 16:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$oKey` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history... Duplication introduced 2015-11-23 16:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
52		foreach($value as $v)
53		{
54		if (property_exists($v, $oKey))
55		{
56		$prop = $v->$oKey;
57		if (is_bool($prop))
58		{
59		$this->checked = $prop;
60		} else
61		{
62		$this->checked = $prop == $this->value;
63		}
64		}
65		}
66		return $this;
67		}
68
69		//Jeżeli jest obiektem
70	View Code Duplication	if (is_object($value) && $oKey) {
		0 ignored issues – show Bug Best Practice introduced 2015-11-23 16:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$oKey` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history... Duplication introduced 2015-11-23 16:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
71		if (property_exists($value, $oKey))
72		{
73		$prop = $value->$oKey;
74		if (is_bool($prop))
75		{
76		$this->checked = $prop;
77		} else
78		{
79		$this->checked = $prop == $this->value;
80		}
81		}
82		}
83
84		if (is_bool($value)) {
85		$this->checked = $value;
86		return $this;
87		}
88
89		$this->checked = $this->value == $value;
90
91		return $this;
92		}
93
94		/**
95		* Pobiera atrybut checked dla html
96		* @return string
97		*/
98		public function getChecked() {
99		return $this->checked ? 'checked' : '';
100		}
101
102		/**
103		* Dla pól checkbox value powinno ustawiać checked na true lub false a nie zastepowac warość
104		* @param null $value
105		* @param null $key
106		* @return null\|string
107		*/
108		public function value($value = null, $key = null) {
109		if (is_null($value)) {
110		return parent::value();
111		}
112		return $this->checked($value, $key);
113		}
114
115		/**
116		* Jeżeli chcemy zastąpić wartość
117		* @param null $value
118		* @param null $key
119		*/
120		public function setValue($value = null, $key = null) {
121		return parent::value($value, $key);
		0 ignored issues – show Comprehensibility Bug introduced 2015-11-25 10:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you call parent on a different method (`value()` instead of `setValue()`). Are you sure this is correct? If so, you might want to change this to `$this->value()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
122		}
123
124		}

code4interactive / forms

Issues (21)

Security Analysis no request data

src/Traits/checkedTrait.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like