checkedTrait - Code Metrics - Inspection of "Fixed displaying value for fields" - code4interactive/forms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 11675b...1688ee )

by A

created 2015-11-26 14:55 UTC

checkedTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	122
Duplicated Lines	19.67 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	5
Bugs	2	Features	1

Metric	Value
wmc	26
c	5
b	2
f	1
lcom	1
cbo	0
dl	24
loc	122
rs	10

4 Methods

Rating	Name	Duplication	Size	Complexity
C	checked()	24	79	19
A	getChecked()	0	3	2
A	value()	0	6	2
A	setValue()	0	3	1

How to fix Duplicated Code

<?php
namespace Code4\Forms\Traits;

trait checkedTrait
{
    protected $checked = false;

    /**
     * Sprawdza czy pole powinno być zaznaczone
     * @param string|array $value
     * @param string $oKey
     * @param string $oName ????
     * @return $this
     */
    public function checked($value = null, $oKey = null, $oName = null) {

        if (is_null($value)) {
            return $this->getChecked();
        }

        //Checkboxy $this->value powinny mieć wyłącznie jako "string"
        if (is_array($this->value)) {
            $this->value = $this->value[0];
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }

        $this->checked = false;

        if (is_array($value)) {
            if (isAssoc($value)) {
                //W przypadku tablicy asocjacyjnej ($key=>$val) jeśli $val jest typu bool to znaczy że $key == $this->value
                if (is_bool(array_values($value)[0])) {
                    if (array_key_exists($this->value, $value)) {
                        $this->checked = $value[$this->value];
                        return $this;
                    }
                } else {
                    //W przeciwnym przypdaku uznajemy że tablica przechowuje pary klucz => wartosc odpowiadające $this->name => $this->value
                    if (array_key_exists($this->name, $value)) {
                        $this->checked = $value[$this->name] == $this->value;
class MyClass { }

$x = new MyClass();
$x->foo = true;
                        return $this;
                    }
                }
            } else {
                $this->checked = in_array($this->value, $value);
                return $this;
            }

            return $this;
        }

        //Jeżeli jest obiektem to obowiązkowo należy podać drugi parametr jakim jest nazwa pola
        if (is_object($value) && $oKey && $oName) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            foreach($value as $v)
            {
                if (property_exists($v, $oKey))

                {
                    $prop = $v->$oKey;
                    if (is_bool($prop))
                    {
                        $this->checked = $prop;
                    } else
                    {
                        $this->checked = $prop == $this->value;
                    }
                }
            }
            return $this;
        }


        if (is_object($value) && $oKey) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            if (property_exists($value, $oKey))
            {
                $prop = $value->$oKey;
                if (is_bool($prop))
                {
                    $this->checked = $prop;
                } else
                {
                    $this->checked = $prop == $this->value;
                }
            }
        }

        if (is_bool($value)) {
            $this->checked = $value;
            return $this;
        }

        $this->checked = $this->value == $value;

        return $this;
    }

    /**
     * Pobiera atrybut checked dla html
     * @return string
     */
    public function getChecked() {
        return $this->checked ? 'checked' : '';
    }

    /**
     * Dla pól checkbox value powinno ustawiać checked na true lub false a nie zastepowac warość
     * @param null $value
     * @param null $key
     * @return null|string
     */
    public function value($value = null, $key = null) {

        if (is_null($value)) {
            return parent::value();
        }
        $this->checked($value);
    }

    /**
     * Jeżeli chcemy zastąpić wartość
     * @param null $value
     * @param null $key
     */
    public function setValue($value = null, $key = null) {
        return parent::value($value, $key);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

}

1		<?php
2		namespace Code4\Forms\Traits;
3
4		trait checkedTrait
5		{
6		protected $checked = false;
7
8		/**
9		* Sprawdza czy pole powinno być zaznaczone
10		* @param string\|array $value
11		* @param string $oKey
12		* @param string $oName ????
13		* @return $this
14		*/
15		public function checked($value = null, $oKey = null, $oName = null) {
16
17		if (is_null($value)) {
18		return $this->getChecked();
19		}
20
21		//Checkboxy $this->value powinny mieć wyłącznie jako "string"
22		if (is_array($this->value)) {
23		$this->value = $this->value[0];
		0 ignored issues – show Bug introduced 2015-11-23 16:14 UTC by Report Bug Copy Issue Report The property `value` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
24		}
25
26		$this->checked = false;
27
28		if (is_array($value)) {
29		if (isAssoc($value)) {
30		//W przypadku tablicy asocjacyjnej ($key=>$val) jeśli $val jest typu bool to znaczy że $key == $this->value
31		if (is_bool(array_values($value)[0])) {
32		if (array_key_exists($this->value, $value)) {
33		$this->checked = $value[$this->value];
34		return $this;
35		}
36		} else {
37		//W przeciwnym przypdaku uznajemy że tablica przechowuje pary klucz => wartosc odpowiadające $this->name => $this->value
38		if (array_key_exists($this->name, $value)) {
39		$this->checked = $value[$this->name] == $this->value;
		0 ignored issues – show Bug introduced 2015-11-23 16:14 UTC by Report Bug Copy Issue Report The property `name` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
40		return $this;
41		}
42		}
43		} else {
44		$this->checked = in_array($this->value, $value);
45		return $this;
46		}
47
48		return $this;
49		}
50
51		//Jeżeli jest obiektem to obowiązkowo należy podać drugi parametr jakim jest nazwa pola
52		if (is_object($value) && $oKey && $oName) {
		0 ignored issues – show Bug Best Practice introduced 2015-11-23 16:14 UTC by Report Bug Copy Issue Report The expression `$oKey` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history... Bug Best Practice introduced 2015-11-23 16:14 UTC by Report Bug Copy Issue Report The expression `$oName` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
53		foreach($value as $v)
54		{
55	View Code Duplication	if (property_exists($v, $oKey))
		0 ignored issues – show Duplication introduced 2015-11-23 16:14 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
56		{
57		$prop = $v->$oKey;
58		if (is_bool($prop))
59		{
60		$this->checked = $prop;
61		} else
62		{
63		$this->checked = $prop == $this->value;
64		}
65		}
66		}
67		return $this;
68		}
69
70
71	View Code Duplication	if (is_object($value) && $oKey) {
		0 ignored issues – show Bug Best Practice introduced 2015-11-23 16:14 UTC by Report Bug Copy Issue Report The expression `$oKey` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history... Duplication introduced 2015-11-23 16:14 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
72		if (property_exists($value, $oKey))
73		{
74		$prop = $value->$oKey;
75		if (is_bool($prop))
76		{
77		$this->checked = $prop;
78		} else
79		{
80		$this->checked = $prop == $this->value;
81		}
82		}
83		}
84
85		if (is_bool($value)) {
86		$this->checked = $value;
87		return $this;
88		}
89
90		$this->checked = $this->value == $value;
91
92		return $this;
93		}
94
95		/**
96		* Pobiera atrybut checked dla html
97		* @return string
98		*/
99		public function getChecked() {
100		return $this->checked ? 'checked' : '';
101		}
102
103		/**
104		* Dla pól checkbox value powinno ustawiać checked na true lub false a nie zastepowac warość
105		* @param null $value
106		* @param null $key
107		* @return null\|string
108		*/
109		public function value($value = null, $key = null) {
		0 ignored issues – show Unused Code introduced 2015-11-26 14:59 UTC by Report Bug Copy Issue Report The parameter `$key` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
110		if (is_null($value)) {
111		return parent::value();
112		}
113		$this->checked($value);
114		}
115
116		/**
117		* Jeżeli chcemy zastąpić wartość
118		* @param null $value
119		* @param null $key
120		*/
121		public function setValue($value = null, $key = null) {
122		return parent::value($value, $key);
		0 ignored issues – show Comprehensibility Bug introduced 2015-11-25 10:46 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`value()` instead of `setValue()`). Are you sure this is correct? If so, you might want to change this to `$this->value()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
123		}
124
125		}

code4interactive / forms

Push — master ( 11675b...1688ee )

checkedTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like