ApiClient::processErrorResponse() - Code Metrics - Inspection of "Test improvements" - code-bushido/api-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c2702c...cb72d6 )

by Wojciech

created 2020-08-18 18:37 UTC

ApiClient::processErrorResponse() A

↳ Parent: ApiClient

Complexity

Conditions	3
Paths	2

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	3.1406

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	3
c	1
b	0
f	0
dl	0
loc	6
ccs	3
cts	4
cp	0.75
rs	10
cc	3
nc	2
nop	2
crap	3.1406

<?php declare(strict_types=1);
/*
 * This file is part of the Bushido\ApiClient package.
 *
 * (c) Wojciech Nowicki <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE.md
 * file that was distributed with this source code.
 */

namespace Bushido\ApiClient;

use Bushido\ApiClient\Exceptions\ErrorResponseException;
use Bushido\ApiClient\Exceptions\WrongResponseException;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;

class ApiClient extends AbstractApiClient
{
    protected function processRequestBody(array $body): array
    {
        return ['json' => $body];
    }

    protected function processResponse(ResponseInterface $response, RequestInterface $request): array
    {
        if ($response->getStatusCode() == 204) {
            return [];
        }

        $responseBody = json_decode($response->getBody()->getContents(), true);

        if (is_array($responseBody)) {
            return $responseBody;
        }

        throw new WrongResponseException('Response body was malformed JSON', $response->getStatusCode());
    }

    protected function processErrorResponse(ResponseInterface $response, RequestInterface $request): void
    {
        if (($responseBody = json_decode($response->getBody()->getContents(), true)) &&
            array_key_exists('message', $responseBody)
        ) {
            throw new ErrorResponseException($responseBody['message'], $response->getStatusCode());
        }
    }
}


1		<?php declare(strict_types=1);
2		/*
3		* This file is part of the Bushido\ApiClient package.
4		*
5		* (c) Wojciech Nowicki <[email protected]>
6		*
7		* For the full copyright and license information, please view the LICENSE.md
8		* file that was distributed with this source code.
9		*/
10
11		namespace Bushido\ApiClient;
12
13		use Bushido\ApiClient\Exceptions\ErrorResponseException;
14		use Bushido\ApiClient\Exceptions\WrongResponseException;
15		use Psr\Http\Message\RequestInterface;
16		use Psr\Http\Message\ResponseInterface;
17
18		class ApiClient extends AbstractApiClient
19		{
20	33	protected function processRequestBody(array $body): array
21		{
22	33	return ['json' => $body];
23		}
24
25	24	protected function processResponse(ResponseInterface $response, RequestInterface $request): array
26		{
27	24	if ($response->getStatusCode() == 204) {
28	3	return [];
29		}
30
31	21	$responseBody = json_decode($response->getBody()->getContents(), true);
32
33	21	if (is_array($responseBody)) {
34	18	return $responseBody;
35		}
36
37	3	throw new WrongResponseException('Response body was malformed JSON', $response->getStatusCode());
38		}
39
40	3	protected function processErrorResponse(ResponseInterface $response, RequestInterface $request): void
41		{
42	3	if (($responseBody = json_decode($response->getBody()->getContents(), true)) &&
43	3	array_key_exists('message', $responseBody)
44		) {
45		throw new ErrorResponseException($responseBody['message'], $response->getStatusCode());
46		}
47	3	}
48		}
49

code-bushido / api-client

Push — master ( c2702c...cb72d6 )

ApiClient::processErrorResponse() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like