Issues in Diff.php - All Issues - Inspection of "Merge pull request #29 from silvadanilo/feature/fi..." - cocur/chain - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6731e6...94ee55 )

by Florian

created 2018-11-09 07:05 UTC

src/Link/Diff.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Cocur\Chain\Link;

use Cocur\Chain\Chain;

/**
 * Diff.
 *
 * @author    Florian Eckerstorfer
 * @copyright 2015 Florian Eckerstorfer
 */
trait Diff
{
    /**
     * Computes the difference of arrays.
     *
     * Compares the array to another array or instance of `Cocur\Chain\Chain` and will set the array of elements that
     * are not present in the other array.
     *
     * @param Chain|array $array2 An array or instance of `Cocur\Chain\Chain` to compare against.
     *
     * @return Chain

     */
    public function diff($array2)
    {
        $this->array = array_diff(
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $this->array,
            $array2 instanceof Chain ? $array2->array : $array2
        );

        return $this;
    }
}


1		<?php
2
3		namespace Cocur\Chain\Link;
4
5		use Cocur\Chain\Chain;
6
7		/**
8		* Diff.
9		*
10		* @author Florian Eckerstorfer
11		* @copyright 2015 Florian Eckerstorfer
12		*/
13		trait Diff
14		{
15		/**
16		* Computes the difference of arrays.
17		*
18		* Compares the array to another array or instance of `Cocur\Chain\Chain` and will set the array of elements that
19		* are not present in the other array.
20		*
21		* @param Chain\|array $array2 An array or instance of `Cocur\Chain\Chain` to compare against.
22		*
23		* @return Chain
		0 ignored issues – show Documentation introduced 2016-02-12 02:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `Diff`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
24		*/
25	2	public function diff($array2)
26		{
27	2	$this->array = array_diff(
		0 ignored issues – show Bug introduced 2016-02-12 02:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `array` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
28	2	$this->array,
29	2	$array2 instanceof Chain ? $array2->array : $array2
30		);
31
32	2	return $this;
33		}
34		}
35

cocur / chain

Push — master ( 6731e6...94ee55 )

src/Link/Diff.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like