Cocur\Chain\Link\Sort::sort()

Complexity

Conditions	4
Paths	4

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function sort($sortBy = SORT_REGULAR, array $options = []): self
    {
        if (!$sortBy) {
            $sortBy = SORT_REGULAR;
        }
        if ($sortBy && is_callable($sortBy)) {
            $this->sortWithCallback($sortBy, $options);

It seems like $sortBy can also be of type integer; however, parameter $callback of Cocur\Chain\Link\Sort::sortWithCallback() does only seem to accept callable, maybe add an additional type check?

        } else {
            $this->sortWithFlags($sortBy, $options);

It seems like $sortBy can also be of type callable; however, parameter $sortFlags of Cocur\Chain\Link\Sort::sortWithFlags() does only seem to accept integer, maybe add an additional type check?

        }

        return $this;
    }