Cocur\Chain\Link\SortKeys

Complexity

Total Complexity

5

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	1	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	sortKeys()	0	9	3
A	sortKeysWithFlags()	0	6	2

<?php

namespace Cocur\Chain\Link;

/**
 * Class SortKeys.
 *
 * @author      Christoph Rosse
 * @author      Florian Eckerstorfer <florian@eckerstorfer.co>
 */
trait SortKeys
{
    /**
     * Sort a Chain by its keys.
     *
     * @param int|callable $sortBy
     * @param array        $options
     *
     * @return self
     */
    public function sortKeys($sortBy = SORT_REGULAR, array $options = []): self
    {
        if ($sortBy && is_callable($sortBy)) {
            uksort($this->array, $sortBy);

It seems like $sortBy can also be of type integer; however, parameter $cmp_function of uksort() does only seem to accept callable, maybe add an additional type check?

        } else {
            $this->sortKeysWithFlags($sortBy, $options);

It seems like $sortBy can also be of type callable; however, parameter $sortFlags of Cocur\Chain\Link\SortKeys::sortKeysWithFlags() does only seem to accept integer, maybe add an additional type check?

        }

        return $this;
    }

    /**
     * @param int   $sortFlags
     * @param array $options
     */
    private function sortKeysWithFlags(int $sortFlags = SORT_REGULAR, array $options = []): void
    {
        if (!empty($options['reverse'])) {
            krsort($this->array, $sortFlags);
        } else {
            ksort($this->array, $sortFlags);
        }
    }
}