NominalColumn::renderClasses() - Code Metrics - Inspection of "Add ARFF reader" - cocur/arff - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 301313...fef224 )

by Florian

created 2017-09-02 19:32 UTC

NominalColumn::renderClasses() A

↳ Parent: NominalColumn

Complexity

Conditions	3
Paths	3

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
dl	0
loc	16
ccs	0
cts	0
cp	0
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	9
nc	3
nop	0
crap	12

<?php

namespace Cocur\Arff\Column;

/**
 * NominalColumn.
 *
 * @author    Florian Eckerstorfer
 * @copyright 2015 Florian Eckerstorfer
 */
class NominalColumn extends AbstractColumn
{
    /**
     * @var string[]
     */
    protected $classes = [];

    /**
     * @param string|null $name
     * @param string[]    $classes
     */
    public function __construct($name = null, array $classes = [])
    {
        if ($name !== null) {
            $this->setName($name);
        }
        $this->setClasses($classes);
    }

    /**
     * @param string[] $classes
     *
     * @return NominalColumn
     */
    public function setClasses(array $classes)
    {
        $this->classes = $classes;

        return $this;
    }

    /**
     * @return string[]
     */
    public function getClasses()
    {
        return $this->classes;
    }

    /**
     * @return string
     */
    public function getType()
    {
        return 'nominal';
    }

    /**
     * @return string
     */
    public function render()
    {
        return sprintf('@ATTRIBUTE %s {%s}', $this->getName(), $this->renderClasses());
    }
    
    /**
     * @return string
     */
    private function renderClasses()
    {
        $classes = $this->getClasses();
$a = "a";
$ab = "ab";
$abc = "abc";
        $strClass = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        for ($i = 0; $i < count($classes); ++$i) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
            $class = $classes[$i];

            if (preg_match('/\s|,|;/', $class)) {
                $class = sprintf("'%s'", $class);
            }
            $classes[$i] = $class;
        }

        return implode(',', $classes);
    }
}


1		<?php
2
3		namespace Cocur\Arff\Column;
4
5		/**
6		* NominalColumn.
7		*
8		* @author Florian Eckerstorfer
9		* @copyright 2015 Florian Eckerstorfer
10		*/
11		class NominalColumn extends AbstractColumn
12		{
13		/**
14		* @var string[]
15		*/
16		protected $classes = [];
17
18		/**
19		* @param string\|null $name
20		* @param string[] $classes
21		*/
22	1	public function __construct($name = null, array $classes = [])
23		{
24	1	if ($name !== null) {
25	1	$this->setName($name);
26		}
27	1	$this->setClasses($classes);
28	1	}
29
30		/**
31		* @param string[] $classes
32		*
33		* @return NominalColumn
34		*/
35	1	public function setClasses(array $classes)
36		{
37	1	$this->classes = $classes;
38
39	1	return $this;
40		}
41
42		/**
43		* @return string[]
44		*/
45	1	public function getClasses()
46		{
47	1	return $this->classes;
48		}
49
50		/**
51		* @return string
52		*/
53	1	public function getType()
54		{
55	1	return 'nominal';
56		}
57
58		/**
59		* @return string
60		*/
61	1	public function render()
62		{
63	1	return sprintf('@ATTRIBUTE %s {%s}', $this->getName(), $this->renderClasses());
64		}
65
66		/**
67		* @return string
68		*/
69		private function renderClasses()
70		{
71		$classes = $this->getClasses();
		0 ignored issues – show Coding Style introduced 2016-11-04 04:23 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
72		$strClass = '';
		0 ignored issues – show Unused Code introduced 2016-11-04 04:23 UTC by Report Bug Copy Issue Report `$strClass` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
73
74		for ($i = 0; $i < count($classes); ++$i) {
		0 ignored issues – show Performance Best Practice introduced 2016-11-04 04:23 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
75		$class = $classes[$i];
76
77		if (preg_match('/\s\|,\|;/', $class)) {
78		$class = sprintf("'%s'", $class);
79		}
80		$classes[$i] = $class;
81		}
82
83		return implode(',', $classes);
84		}
85		}
86

cocur / arff

Push — master ( 301313...fef224 )

NominalColumn::renderClasses() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like