Cocur\Arff\Column\NominalColumn

Complexity

Total Complexity

9

Size/Duplication

Total Lines	75
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

60.87%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	2
A	setClasses()	0	6	1
A	getClasses()	0	4	1
A	getType()	0	4	1
A	render()	0	4	1
A	renderClasses()	0	16	3

<?php

namespace Cocur\Arff\Column;

/**
 * NominalColumn.
 *
 * @author    Florian Eckerstorfer
 * @copyright 2015 Florian Eckerstorfer
 */
class NominalColumn extends AbstractColumn
{
    /**
     * @var string[]
     */
    protected $classes = [];

    /**
     * @param string|null $name
     * @param string[]    $classes
     */
    public function __construct($name = null, array $classes = [])
    {
        if ($name !== null) {
            $this->setName($name);
        }
        $this->setClasses($classes);
    }

    /**
     * @param string[] $classes
     *
     * @return NominalColumn
     */
    public function setClasses(array $classes)
    {
        $this->classes = $classes;

        return $this;
    }

    /**
     * @return string[]
     */
    public function getClasses()
    {
        return $this->classes;
    }

    /**
     * @return string
     */
    public function getType()
    {
        return 'nominal';
    }

    /**
     * @return string
     */
    public function render()
    {
        return sprintf('@ATTRIBUTE %s {%s}', $this->getName(), $this->renderClasses());
    }
    
    /**
     * @return string
     */
    private function renderClasses()
    {
        $classes = $this->getClasses();
        $strClass = '';

$strClass is not used, you could remove the assignment.

        for ($i = 0; $i < count($classes); ++$i) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            $class = $classes[$i];

            if (preg_match('/\s|,|;/', $class)) {
                $class = sprintf("'%s'", $class);
            }
            $classes[$i] = $class;
        }

        return implode(',', $classes);
    }
}