Conditions | 86 |
Paths | 38 |
Total Lines | 181 |
Code Lines | 156 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
74 | protected function parseStaticValueVersionSpecific(ASTValue $value) |
||
75 | { |
||
76 | $expressions = array(); |
||
77 | |||
78 | while (($tokenType = $this->tokenizer->peek()) != Tokenizer::T_EOF) { |
||
79 | switch ($tokenType) { |
||
80 | case Tokens::T_COMMA: |
||
81 | case Tokens::T_CLOSE_TAG: |
||
82 | case Tokens::T_COLON: |
||
83 | case Tokens::T_DOUBLE_ARROW: |
||
84 | case Tokens::T_END_HEREDOC: |
||
85 | case Tokens::T_PARENTHESIS_CLOSE: |
||
86 | case Tokens::T_SEMICOLON: |
||
87 | case Tokens::T_SQUARED_BRACKET_CLOSE: |
||
88 | break 2; |
||
89 | case Tokens::T_SELF: |
||
90 | case Tokens::T_STRING: |
||
91 | case Tokens::T_PARENT: |
||
92 | case Tokens::T_STATIC: |
||
93 | case Tokens::T_DOLLAR: |
||
94 | case Tokens::T_VARIABLE: |
||
95 | case Tokens::T_BACKSLASH: |
||
96 | case Tokens::T_NAMESPACE: |
||
97 | $expressions[] = $this->parseVariableOrConstantOrPrimaryPrefix(); |
||
98 | break; |
||
99 | case ($this->isArrayStartDelimiter()): |
||
100 | $expressions[] = $this->doParseArray(true); |
||
101 | break; |
||
102 | case Tokens::T_NULL: |
||
103 | case Tokens::T_TRUE: |
||
104 | case Tokens::T_FALSE: |
||
105 | case Tokens::T_LNUMBER: |
||
106 | case Tokens::T_DNUMBER: |
||
107 | case Tokens::T_BACKTICK: |
||
108 | case Tokens::T_DOUBLE_QUOTE: |
||
109 | case Tokens::T_CONSTANT_ENCAPSED_STRING: |
||
110 | $expressions[] = $this->parseLiteralOrString(); |
||
111 | break; |
||
112 | case Tokens::T_QUESTION_MARK: |
||
113 | $expressions[] = $this->parseConditionalExpression(); |
||
114 | break; |
||
115 | case Tokens::T_BOOLEAN_AND: |
||
116 | $expressions[] = $this->parseBooleanAndExpression(); |
||
117 | break; |
||
118 | case Tokens::T_BOOLEAN_OR: |
||
119 | $expressions[] = $this->parseBooleanOrExpression(); |
||
120 | break; |
||
121 | case Tokens::T_LOGICAL_AND: |
||
122 | $expressions[] = $this->parseLogicalAndExpression(); |
||
123 | break; |
||
124 | case Tokens::T_LOGICAL_OR: |
||
125 | $expressions[] = $this->parseLogicalOrExpression(); |
||
126 | break; |
||
127 | case Tokens::T_LOGICAL_XOR: |
||
128 | $expressions[] = $this->parseLogicalXorExpression(); |
||
129 | break; |
||
130 | case Tokens::T_PARENTHESIS_OPEN: |
||
131 | $expressions[] = $this->parseParenthesisExpressionOrPrimaryPrefix(); |
||
132 | break; |
||
133 | case Tokens::T_START_HEREDOC: |
||
134 | $expressions[] = $this->parseHeredoc(); |
||
135 | break; |
||
136 | case Tokens::T_SL: |
||
137 | $expressions[] = $this->parseShiftLeftExpression(); |
||
138 | break; |
||
139 | case Tokens::T_SR: |
||
140 | $expressions[] = $this->parseShiftRightExpression(); |
||
141 | break; |
||
142 | case Tokens::T_ELLIPSIS: |
||
143 | $this->checkEllipsisInExpressionSupport(); |
||
144 | // no break |
||
145 | case Tokens::T_STRING_VARNAME: // TODO: Implement this |
||
146 | case Tokens::T_PLUS: // TODO: Make this a arithmetic expression |
||
147 | case Tokens::T_MINUS: |
||
148 | case Tokens::T_MUL: |
||
149 | case Tokens::T_DIV: |
||
150 | case Tokens::T_MOD: |
||
151 | case Tokens::T_POW: |
||
152 | case Tokens::T_IS_EQUAL: // TODO: Implement compare expressions |
||
153 | case Tokens::T_IS_NOT_EQUAL: |
||
154 | case Tokens::T_IS_IDENTICAL: |
||
155 | case Tokens::T_IS_NOT_IDENTICAL: |
||
156 | case Tokens::T_BITWISE_OR: |
||
157 | case Tokens::T_BITWISE_AND: |
||
158 | case Tokens::T_BITWISE_NOT: |
||
159 | case Tokens::T_BITWISE_XOR: |
||
160 | case Tokens::T_IS_GREATER_OR_EQUAL: |
||
161 | case Tokens::T_IS_SMALLER_OR_EQUAL: |
||
162 | case Tokens::T_ANGLE_BRACKET_OPEN: |
||
163 | case Tokens::T_ANGLE_BRACKET_CLOSE: |
||
164 | case Tokens::T_EMPTY: |
||
165 | case Tokens::T_CONCAT: |
||
166 | $token = $this->consumeToken($tokenType); |
||
167 | |||
168 | $expr = $this->builder->buildAstExpression($token->image); |
||
169 | $expr->configureLinesAndColumns( |
||
170 | $token->startLine, |
||
171 | $token->endLine, |
||
172 | $token->startColumn, |
||
173 | $token->endColumn |
||
174 | ); |
||
175 | |||
176 | $expressions[] = $expr; |
||
177 | break; |
||
178 | case Tokens::T_EQUAL: |
||
179 | case Tokens::T_OR_EQUAL: |
||
180 | case Tokens::T_SL_EQUAL: |
||
181 | case Tokens::T_SR_EQUAL: |
||
182 | case Tokens::T_AND_EQUAL: |
||
183 | case Tokens::T_DIV_EQUAL: |
||
184 | case Tokens::T_MOD_EQUAL: |
||
185 | case Tokens::T_MUL_EQUAL: |
||
186 | case Tokens::T_XOR_EQUAL: |
||
187 | case Tokens::T_PLUS_EQUAL: |
||
188 | case Tokens::T_MINUS_EQUAL: |
||
189 | case Tokens::T_CONCAT_EQUAL: |
||
190 | case Tokens::T_COALESCE_EQUAL: |
||
191 | $expressions[] = $this->parseAssignmentExpression( |
||
192 | array_pop($expressions) |
||
193 | ); |
||
194 | break; |
||
195 | case Tokens::T_DIR: |
||
196 | case Tokens::T_FILE: |
||
197 | case Tokens::T_LINE: |
||
198 | case Tokens::T_NS_C: |
||
199 | case Tokens::T_FUNC_C: |
||
200 | case Tokens::T_CLASS_C: |
||
201 | case Tokens::T_METHOD_C: |
||
202 | $expressions[] = $this->parseConstant(); |
||
203 | break; |
||
204 | // TODO: Handle comments here |
||
205 | case Tokens::T_COMMENT: |
||
206 | case Tokens::T_DOC_COMMENT: |
||
207 | $this->consumeToken($tokenType); |
||
208 | break; |
||
209 | case Tokens::T_AT: |
||
210 | case Tokens::T_EXCLAMATION_MARK: |
||
211 | $token = $this->consumeToken($tokenType); |
||
212 | |||
213 | $expr = $this->builder->buildAstUnaryExpression($token->image); |
||
214 | $expr->configureLinesAndColumns( |
||
215 | $token->startLine, |
||
216 | $token->endLine, |
||
217 | $token->startColumn, |
||
218 | $token->endColumn |
||
219 | ); |
||
220 | |||
221 | $expressions[] = $expr; |
||
222 | break; |
||
223 | default: |
||
224 | throw $this->getUnexpectedNextTokenException(); |
||
225 | } |
||
226 | } |
||
227 | |||
228 | $expressions = $this->reduce($expressions); |
||
229 | |||
230 | $count = count($expressions); |
||
231 | if ($count == 0) { |
||
232 | return null; |
||
233 | } elseif ($count == 1) { |
||
234 | // @todo ASTValue must be a valid node. |
||
235 | $value->setValue($expressions[0]); |
||
236 | |||
237 | return $value; |
||
238 | } |
||
239 | |||
240 | $expr = $this->builder->buildAstExpression(); |
||
241 | foreach ($expressions as $node) { |
||
242 | $expr->addChild($node); |
||
243 | } |
||
244 | $expr->configureLinesAndColumns( |
||
245 | $expressions[0]->getStartLine(), |
||
246 | $expressions[$count - 1]->getEndLine(), |
||
247 | $expressions[0]->getStartColumn(), |
||
248 | $expressions[$count - 1]->getEndColumn() |
||
249 | ); |
||
250 | |||
251 | // @todo ASTValue must be a valid node. |
||
252 | $value->setValue($expr); |
||
253 | |||
254 | return $value; |
||
255 | } |
||
444 |
This check looks for parameters that have been defined for a function or method, but which are not used in the method body.