DistributionRequirement.install_command() - Code Metrics - Inspection of "Add DistributionRequirement" - coala-analyzer/coala - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2542)

by Zatreanu

created 2016-07-24 09:43 UTC

DistributionRequirement.install_command() A

↳ Parent: DistributionRequirement

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
c	1
b	0
f	0
dl	0
loc	22
rs	9.2

from coalib.bears.requirements.PackageRequirement import PackageRequirement
import platform


class DistributionRequirement(PackageRequirement):
    """
    This class is a subclass of ``PackageRequirement``, and helps specifying
    distribution specific requirements, without using the manager name.
    """

    def __init__(self, package, version=""):
        """
        Constructs a new ``DistributionRequirement``, using the
        ``PackageRequirement`` constructor.

        :param package: A string with the name of the package to be installed.
        :param version: A version string. Leave empty to specify latest version.
        """
        PackageRequirement.__init__(self, manager, package, version)

        self.manager = ""

    def install_command(self):
        """
        Creates the installation command for the instance of the class.

        :param return: A string with the installation command.
        """
        manager_dict = {'Fedora': 'dnf',
                        'Ubuntu': 'apt-get',
                        'Debian': 'apt-get',
                        'SuSE': 'zypper',
                        'redhat': 'yum',
                        'arch': 'pacman'}

        if platform.linux_distribution()[0] in manager_dict:
            self.manager = manager_dict[platform.linux_distribution()]
        else:
            print('The package could not be automatically installed on your'
                  'operating system. Please try installing '
                  + self.package + 'manually.')

        result = "{} install {}".format(self.manager, self.package)
        return result


1			from coalib.bears.requirements.PackageRequirement import PackageRequirement
2			import platform
3
4
5			class DistributionRequirement(PackageRequirement):
6			"""
7			This class is a subclass of ``PackageRequirement``, and helps specifying
8			distribution specific requirements, without using the manager name.
9			"""
10
11			def __init__(self, package, version=""):
12			"""
13			Constructs a new ``DistributionRequirement``, using the
14			``PackageRequirement`` constructor.
15
16			:param package: A string with the name of the package to be installed.
17			:param version: A version string. Leave empty to specify latest version.
18			"""
19			PackageRequirement.__init__(self, manager, package, version)
			0 ignored issues – show Comprehensibility Best Practice introduced 2016-07-24 09:45 UTC by Report Bug Copy Issue Report Undefined variable 'manager' Loading history...
20			self.manager = ""
21
22			def install_command(self):
23			"""
24			Creates the installation command for the instance of the class.
25
26			:param return: A string with the installation command.
27			"""
28			manager_dict = {'Fedora': 'dnf',
29			'Ubuntu': 'apt-get',
30			'Debian': 'apt-get',
31			'SuSE': 'zypper',
32			'redhat': 'yum',
33			'arch': 'pacman'}
34
35			if platform.linux_distribution()[0] in manager_dict:
36			self.manager = manager_dict[platform.linux_distribution()]
37			else:
38			print('The package could not be automatically installed on your'
39			'operating system. Please try installing '
40			+ self.package + 'manually.')
41
42			result = "{} install {}".format(self.manager, self.package)
43			return result
44

coala-analyzer / coala

Pull Request — master (#2542)

DistributionRequirement.install_command() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like