Completed
Pull Request — master (#2408)
by Zatreanu
02:20
created

GemRequirement   A

Complexity

Total Complexity 5

Size/Duplication

Total Lines 56
Duplicated Lines 100 %

Importance

Changes 3
Bugs 0 Features 0
Metric Value
c 3
b 0
f 0
dl 56
loc 56
rs 10
wmc 5

3 Methods

Rating   Name   Duplication   Size   Complexity  
A __init__() 22 22 1
A install_command() 16 16 2
A is_installed() 10 10 2

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
from coalib.bears.requirements.PackageRequirement import PackageRequirement
2
from coalib.misc.Shell import call_without_output
3
import platform
4
5
6 View Code Duplication
class GemRequirement(PackageRequirement):
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated in your project.
Loading history...
7
    """
8
    This class is a subclass of ``PackageRequirement``, and helps specifying
9
    requirements from ``gem``, without using the manager name.
10
    """
11
12
    def __init__(self, package, version="", require=""):
13
        """
14
        Constructs a new ``GemRequirement``, using the ``PackageRequirement``
15
        constructor.
16
17
        >>> pr = GemRequirement('setuptools', '19.2', 'flag')
18
        >>> pr.manager
19
        'gem'
20
        >>> pr.package
21
        'setuptools'
22
        >>> pr.version
23
        '19.2'
24
        >>> pr.require
25
        'flag'
26
27
        :param package: A string with the name of the package to be installed.
28
        :param version: A version string. Leave empty to specify latest version.
29
        :param require: A string that specifies any additional flags, that
30
                        would be used with ``require``.
31
        """
32
        PackageRequirement.__init__(self, 'gem', package, version)
33
        self.require = require
34
35
    def install_command(self):
36
        """
37
        Creates the installation command for the instance of the class.
38
39
        >>> GemRequirement('rubocop').install_command()
40
        'gem install rubocop'
41
42
        >>> GemRequirement('scss_lint', '', 'false').install_command()
43
        "gem install 'scss_lint', require: false"
44
45
        :param return: A string with the installation command.
46
        """
47
        if self.require:
48
            return "gem install '{}', require: {}".format(self.package,
49
                                                          self.require)
50
        return "gem install {}".format(self.package)
51
52
    def is_installed(self):
53
        """
54
        Checks if the dependency is installed.
55
56
        :param return: True if dependency is installed, false otherwise.
57
        """
58
        cmd = ['gem', 'list', '-i', self.package]
59
        if platform.system() == 'Windows':  # pragma: no cover
60
            cmd = ['cmd', '/c'] + cmd
61
        return not call_without_output(cmd)
62