coala-analyzer /
coala
| Conditions | 15 |
| Total Lines | 122 |
| Lines | 0 |
| Ratio | 0 % |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like coalib.misc.run_coala() often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
| 1 | from collections import Iterable, OrderedDict |
||
| 19 | for dictionary in dicts: |
||
| 20 | for key, value in dictionary.items(): |
||
| 21 | if isinstance(value, Iterable): |
||
| 22 | for item in value: |
||
| 23 | add_pair_to_dict(item, key, inverse) |
||
| 24 | else: |
||
| 25 | add_pair_to_dict(value, key, inverse) |
||
| 26 | |||
| 27 | return inverse |
||
| 28 | |||
| 29 | |||
| 30 | def add_pair_to_dict(key, value, dictionary): |
||
| 31 | """ |
||
| 32 | Add (key, value) pair to the dictionary. The value is added to a list of |
||
| 33 | values for the key. |
||
| 34 | """ |
||
| 35 | if key in dictionary: |
||
| 36 | dictionary[key].append(value) |
||
| 37 | else: |
||
| 38 | dictionary[key] = [value] |
||
| 39 | |||
| 40 | |||
| 41 | def update_ordered_dict_key(dictionary, old_key, new_key): |
||
| 42 | return OrderedDict(((new_key if k == old_key else k), v) |
||
| 43 | for k, v in dictionary.items()) |
||
| 44 |
