CircularDependencyError.for_bears() - Code Metrics - Inspection of "Better mocking" - coala-analyzer/coala - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#2076)

by Abdeali

created 2016-04-26 07:56 UTC

CircularDependencyError.for_bears() A

↳ Parent: CircularDependencyError

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
c	1
b	0
f	0
dl	0
loc	9
rs	9.6666

class CircularDependencyError(Exception):


    @classmethod

    def for_bears(cls, bears):
        """
        Creates the CircularDependencyError with a helpful message about the
        dependency.
        """
        bear_names = [bear.name for bear in bears]


        return cls("Circular dependency detected: " + " -> ".join(bear_names))



def _resolve(bears, resolved_bears, seen):
    for bear in bears:
        if bear in resolved_bears:
            continue

        missing = bear.missing_dependencies(resolved_bears)
        if missing == []:
            resolved_bears.append(bear)
            continue

        if bear in seen:
            seen.append(bear)
            raise CircularDependencyError.for_bears(seen)

        seen.append(bear)
        resolved_bears = _resolve(missing, resolved_bears, seen)
        resolved_bears.append(bear)
        seen.remove(bear)  # Already resolved, no candidate for circular dep

    return resolved_bears


def resolve(bears):
    """
    Collects all dependencies of the given bears. This will also remove
    duplicates.

    :param bears: The given bears. Will not be modified.
    :return:      The new list of bears, sorted so that it can be executed
                  sequentially without dependency issues.
    """
    return _resolve(bears, [], [])


1			class CircularDependencyError(Exception):
			0 ignored issues – show Comprehensibility Best Practice introduced 2016-04-26 06:36 UTC by Report Bug Copy Issue Report The variable `Exception` does not seem to be defined. Loading history...
2
3			@classmethod
			0 ignored issues – show Comprehensibility Best Practice introduced 2016-04-26 06:36 UTC by Report Bug Copy Issue Report The variable `classmethod` does not seem to be defined. Loading history...
4			def for_bears(cls, bears):
5			"""
6			Creates the CircularDependencyError with a helpful message about the
7			dependency.
8			"""
9			bear_names = [bear.name for bear in bears]
			0 ignored issues – show Comprehensibility Best Practice introduced 2016-04-26 06:36 UTC by Report Bug Copy Issue Report The variable `bears` does not seem to be defined. Loading history... Comprehensibility Best Practice introduced 2016-04-26 06:36 UTC by Report Bug Copy Issue Report The variable `bear` does not seem to be defined. Loading history...
10
11			return cls("Circular dependency detected: " + " -> ".join(bear_names))
			0 ignored issues – show Comprehensibility Best Practice introduced 2016-04-26 06:36 UTC by Report Bug Copy Issue Report The variable `bear_names` does not seem to be defined. Loading history...
12
13
14			def _resolve(bears, resolved_bears, seen):
15			for bear in bears:
16			if bear in resolved_bears:
17			continue
18
19			missing = bear.missing_dependencies(resolved_bears)
20			if missing == []:
21			resolved_bears.append(bear)
22			continue
23
24			if bear in seen:
25			seen.append(bear)
26			raise CircularDependencyError.for_bears(seen)
27
28			seen.append(bear)
29			resolved_bears = _resolve(missing, resolved_bears, seen)
30			resolved_bears.append(bear)
31			seen.remove(bear) # Already resolved, no candidate for circular dep
32
33			return resolved_bears
34
35
36			def resolve(bears):
37			"""
38			Collects all dependencies of the given bears. This will also remove
39			duplicates.
40
41			:param bears: The given bears. Will not be modified.
42			:return: The new list of bears, sorted so that it can be executed
43			sequentially without dependency issues.
44			"""
45			return _resolve(bears, [], [])
46

coala-analyzer / coala

Pull Request — master (#2076)

CircularDependencyError.for_bears() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like