Conditions | 4 |
Total Lines | 53 |
Lines | 0 |
Ratio | 0 % |
Changes | 3 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | from coalib.bears.requirements.PackageRequirement import PackageRequirement |
||
28 | @classmethod |
||
29 | def multiple(cls, *args): |
||
30 | """ |
||
31 | Creates a tuple of multiple ``PythonRequirements``. |
||
32 | |||
33 | You should use the ``multiple`` method if you have more |
||
34 | requirements from the same manager. This can receive both tuples of |
||
35 | strings, in case you want a specific version, or a simple string, in |
||
36 | case you want the latest version to be specified. |
||
37 | |||
38 | This is the case where you would provide strings only, to specify the |
||
39 | latest version automatically: |
||
40 | |||
41 | >>> REQUIREMENTS = PythonRequirement.multiple( |
||
42 | ... 'coala_decorators', 'setuptools') |
||
43 | |||
44 | And if you choose to mix them, specifying version for some and for some |
||
45 | not: |
||
46 | |||
47 | >>> REQUIREMENTS = PythonRequirement.multiple( |
||
48 | ... 'coala_decorators', ('setuptools', '19.2')) |
||
49 | |||
50 | Lists are also valid arguments: |
||
51 | |||
52 | >>> REQUIREMENTS = PythonRequirement.multiple( |
||
53 | ... ['coala_decorators', '19.2'],) |
||
54 | |||
55 | In case you provide too many arguments into the tuple, an error will be |
||
56 | raised: |
||
57 | |||
58 | >>> REQUIREMENTS = PythonRequirement.multiple( |
||
59 | ... 'coala_decorators', ('setuptools', '19.2', 'colorama')) |
||
60 | Traceback (most recent call last): |
||
61 | ... |
||
62 | TypeError: Too many elements provided. |
||
63 | |||
64 | :param args: Should be iterables with two elements: |
||
65 | ``('packageName', 'version')`` or strings: |
||
66 | ``'packageName'`` if latest version is wanted. |
||
67 | :return: A tuple containing ``PythonRequirements``. |
||
68 | :raises TypeError: In case the iterables contain more than two |
||
69 | elements. |
||
70 | """ |
||
71 | reqs = [] |
||
72 | for requirement in args: |
||
73 | if isinstance(requirement, str): |
||
74 | reqs.append(cls(requirement)) |
||
75 | elif len(requirement) == 2: |
||
76 | name, version = requirement |
||
77 | reqs.append(cls(name, version)) |
||
78 | else: |
||
79 | raise TypeError('Too many elements provided.') |
||
80 | return tuple(reqs) |
||
81 |