| Conditions | 1 |
| Total Lines | 413 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | from contextlib import contextmanager |
||
| 117 | def _create_linter(klass, options): |
||
| 118 | class LinterMeta(type): |
||
| 119 | |||
| 120 | def __repr__(cls): |
||
| 121 | return "<{} linter class (wrapping {!r})>".format( |
||
| 122 | cls.__name__, options["executable"]) |
||
| 123 | |||
| 124 | class LinterBase(LocalBear, metaclass=LinterMeta): |
||
|
|
|||
| 125 | |||
| 126 | @staticmethod |
||
| 127 | def generate_config(filename, file): |
||
| 128 | """ |
||
| 129 | Generates the content of a config-file the linter-tool might need. |
||
| 130 | |||
| 131 | The contents generated from this function are written to a |
||
| 132 | temporary file and the path is provided inside |
||
| 133 | ``create_arguments()``. |
||
| 134 | |||
| 135 | By default no configuration is generated. |
||
| 136 | |||
| 137 | You can provide additional keyword arguments and defaults. These |
||
| 138 | will be interpreted as required settings that need to be provided |
||
| 139 | through a coafile-section. |
||
| 140 | |||
| 141 | :param filename: |
||
| 142 | The name of the file currently processed. |
||
| 143 | :param file: |
||
| 144 | The contents of the file currently processed. |
||
| 145 | :return: |
||
| 146 | The config-file-contents as a string or ``None``. |
||
| 147 | """ |
||
| 148 | return None |
||
| 149 | |||
| 150 | @staticmethod |
||
| 151 | def create_arguments(filename, file, config_file): |
||
| 152 | """ |
||
| 153 | Creates the arguments for the linter. |
||
| 154 | |||
| 155 | You can provide additional keyword arguments and defaults. These |
||
| 156 | will be interpreted as required settings that need to be provided |
||
| 157 | through a coafile-section. |
||
| 158 | |||
| 159 | :param filename: |
||
| 160 | The name of the file the linter-tool shall process. |
||
| 161 | :param file: |
||
| 162 | The contents of the file. |
||
| 163 | :param config_file: |
||
| 164 | The path of the config-file if used. ``None`` if unused. |
||
| 165 | :return: |
||
| 166 | A sequence of arguments to feed the linter-tool with. |
||
| 167 | """ |
||
| 168 | raise NotImplementedError |
||
| 169 | |||
| 170 | @staticmethod |
||
| 171 | def get_executable(): |
||
| 172 | """ |
||
| 173 | Returns the executable of this class. |
||
| 174 | |||
| 175 | :return: |
||
| 176 | The executable name. |
||
| 177 | """ |
||
| 178 | return options["executable"] |
||
| 179 | |||
| 180 | @classmethod |
||
| 181 | def check_prerequisites(cls): |
||
| 182 | """ |
||
| 183 | Checks whether the linter-tool the bear uses is operational. |
||
| 184 | |||
| 185 | :return: |
||
| 186 | True if operational, otherwise a string containing more info. |
||
| 187 | """ |
||
| 188 | if shutil.which(cls.get_executable()) is None: |
||
| 189 | return (repr(cls.get_executable()) + " is not installed." + |
||
| 190 | (" " + options["executable_check_fail_info"] |
||
| 191 | if options["executable_check_fail_info"] else |
||
| 192 | "")) |
||
| 193 | else: |
||
| 194 | if options["prerequisite_check_command"]: |
||
| 195 | try: |
||
| 196 | check_call(options["prerequisite_check_command"], |
||
| 197 | stdout=DEVNULL, |
||
| 198 | stderr=DEVNULL) |
||
| 199 | return True |
||
| 200 | except (OSError, CalledProcessError): |
||
| 201 | return options["prerequisite_check_fail_message"] |
||
| 202 | return True |
||
| 203 | |||
| 204 | @classmethod |
||
| 205 | def _get_create_arguments_metadata(cls): |
||
| 206 | return FunctionMetadata.from_function( |
||
| 207 | cls.create_arguments, |
||
| 208 | omit={"self", "filename", "file", "config_file"}) |
||
| 209 | |||
| 210 | @classmethod |
||
| 211 | def _get_generate_config_metadata(cls): |
||
| 212 | return FunctionMetadata.from_function( |
||
| 213 | cls.generate_config, |
||
| 214 | omit={"filename", "file"}) |
||
| 215 | |||
| 216 | @classmethod |
||
| 217 | def _get_process_output_metadata(cls): |
||
| 218 | metadata = FunctionMetadata.from_function(cls.process_output) |
||
| 219 | |||
| 220 | if options["output_format"] is None: |
||
| 221 | omitted = {"self", "output", "filename", "file"} |
||
| 222 | else: |
||
| 223 | # If a specific output format is provided, function signatures |
||
| 224 | # from process_output functions should not appear in the help. |
||
| 225 | omitted = set(chain(metadata.non_optional_params, |
||
| 226 | metadata.optional_params)) |
||
| 227 | |||
| 228 | metadata.omit = omitted |
||
| 229 | return metadata |
||
| 230 | |||
| 231 | @classmethod |
||
| 232 | def get_metadata(cls): |
||
| 233 | merged_metadata = FunctionMetadata.merge( |
||
| 234 | cls._get_process_output_metadata(), |
||
| 235 | cls._get_generate_config_metadata(), |
||
| 236 | cls._get_create_arguments_metadata()) |
||
| 237 | merged_metadata.desc = inspect.getdoc(cls) |
||
| 238 | return merged_metadata |
||
| 239 | |||
| 240 | def _convert_output_regex_match_to_result(self, |
||
| 241 | match, |
||
| 242 | filename, |
||
| 243 | severity_map, |
||
| 244 | result_message): |
||
| 245 | """ |
||
| 246 | Converts the matched named-groups of ``output_regex`` to an actual |
||
| 247 | ``Result``. |
||
| 248 | |||
| 249 | :param match: |
||
| 250 | The regex match object. |
||
| 251 | :param filename: |
||
| 252 | The name of the file this match belongs to. |
||
| 253 | :param severity_map: |
||
| 254 | The dict to use to map the severity-match to an actual |
||
| 255 | ``RESULT_SEVERITY``. |
||
| 256 | :param result_message: |
||
| 257 | The static message to use for results instead of grabbing it |
||
| 258 | from the executable output via the ``message`` named regex |
||
| 259 | group. |
||
| 260 | """ |
||
| 261 | # Pre process the groups |
||
| 262 | groups = match.groupdict() |
||
| 263 | |||
| 264 | if 'severity' in groups: |
||
| 265 | try: |
||
| 266 | groups["severity"] = severity_map[ |
||
| 267 | groups["severity"].lower()] |
||
| 268 | except KeyError: |
||
| 269 | self.warn( |
||
| 270 | repr(groups["severity"]) + " not found in " |
||
| 271 | "severity-map. Assuming `RESULT_SEVERITY.NORMAL`.") |
||
| 272 | groups["severity"] = RESULT_SEVERITY.NORMAL |
||
| 273 | else: |
||
| 274 | groups['severity'] = RESULT_SEVERITY.NORMAL |
||
| 275 | |||
| 276 | for variable in ("line", "column", "end_line", "end_column"): |
||
| 277 | groups[variable] = (None |
||
| 278 | if groups.get(variable, None) is None else |
||
| 279 | int(groups[variable])) |
||
| 280 | |||
| 281 | if "origin" in groups: |
||
| 282 | groups["origin"] = "{} ({})".format(klass.__name__, |
||
| 283 | groups["origin"].strip()) |
||
| 284 | |||
| 285 | # Construct the result. |
||
| 286 | return Result.from_values( |
||
| 287 | origin=groups.get("origin", self), |
||
| 288 | message=(groups.get("message", "").strip() |
||
| 289 | if result_message is None else result_message), |
||
| 290 | file=filename, |
||
| 291 | severity=groups["severity"], |
||
| 292 | line=groups["line"], |
||
| 293 | column=groups["column"], |
||
| 294 | end_line=groups["end_line"], |
||
| 295 | end_column=groups["end_column"], |
||
| 296 | additional_info=groups.get("additional_info", "").strip()) |
||
| 297 | |||
| 298 | def process_output_corrected(self, |
||
| 299 | output, |
||
| 300 | filename, |
||
| 301 | file, |
||
| 302 | diff_severity=RESULT_SEVERITY.NORMAL, |
||
| 303 | result_message="Inconsistency found.", |
||
| 304 | diff_distance=1): |
||
| 305 | """ |
||
| 306 | Processes the executable's output as a corrected file. |
||
| 307 | |||
| 308 | :param output: |
||
| 309 | The output of the program as a string. |
||
| 310 | :param filename: |
||
| 311 | The filename of the file currently being corrected. |
||
| 312 | :param file: |
||
| 313 | The contents of the file currently being corrected. |
||
| 314 | :param diff_severity: |
||
| 315 | The severity to use for generating results. |
||
| 316 | :param result_message: |
||
| 317 | The message to use for generating results. |
||
| 318 | :param diff_distance: |
||
| 319 | Number of unchanged lines that are allowed in between two |
||
| 320 | changed lines so they get yielded as one diff. If a negative |
||
| 321 | distance is given, every change will be yielded as an own diff, |
||
| 322 | even if they are right beneath each other. |
||
| 323 | :return: |
||
| 324 | An iterator returning results containing patches for the |
||
| 325 | file to correct. |
||
| 326 | """ |
||
| 327 | for diff in Diff.from_string_arrays( |
||
| 328 | file, |
||
| 329 | output.splitlines(keepends=True)).split_diff( |
||
| 330 | distance=diff_distance): |
||
| 331 | yield Result(self, |
||
| 332 | result_message, |
||
| 333 | affected_code=diff.affected_code(filename), |
||
| 334 | diffs={filename: diff}, |
||
| 335 | severity=diff_severity) |
||
| 336 | |||
| 337 | def process_output_regex( |
||
| 338 | self, output, filename, file, output_regex, |
||
| 339 | severity_map=MappingProxyType({ |
||
| 340 | "critical": RESULT_SEVERITY.MAJOR, |
||
| 341 | "c": RESULT_SEVERITY.MAJOR, |
||
| 342 | "fatal": RESULT_SEVERITY.MAJOR, |
||
| 343 | "fail": RESULT_SEVERITY.MAJOR, |
||
| 344 | "f": RESULT_SEVERITY.MAJOR, |
||
| 345 | "error": RESULT_SEVERITY.MAJOR, |
||
| 346 | "err": RESULT_SEVERITY.MAJOR, |
||
| 347 | "e": RESULT_SEVERITY.MAJOR, |
||
| 348 | "warning": RESULT_SEVERITY.NORMAL, |
||
| 349 | "warn": RESULT_SEVERITY.NORMAL, |
||
| 350 | "w": RESULT_SEVERITY.NORMAL, |
||
| 351 | "information": RESULT_SEVERITY.INFO, |
||
| 352 | "info": RESULT_SEVERITY.INFO, |
||
| 353 | "i": RESULT_SEVERITY.INFO, |
||
| 354 | "note": RESULT_SEVERITY.INFO, |
||
| 355 | "suggestion": RESULT_SEVERITY.INFO}), |
||
| 356 | result_message=None): |
||
| 357 | """ |
||
| 358 | Processes the executable's output using a regex. |
||
| 359 | |||
| 360 | :param output: |
||
| 361 | The output of the program as a string. |
||
| 362 | :param filename: |
||
| 363 | The filename of the file currently being corrected. |
||
| 364 | :param file: |
||
| 365 | The contents of the file currently being corrected. |
||
| 366 | :param output_regex: |
||
| 367 | The regex to parse the output with. It should use as many |
||
| 368 | of the following named groups (via ``(?P<name>...)``) to |
||
| 369 | provide a good result: |
||
| 370 | |||
| 371 | - line - The line where the issue starts. |
||
| 372 | - column - The column where the issue starts. |
||
| 373 | - end_line - The line where the issue ends. |
||
| 374 | - end_column - The column where the issue ends. |
||
| 375 | - severity - The severity of the issue. |
||
| 376 | - message - The message of the result. |
||
| 377 | - origin - The origin of the issue. |
||
| 378 | - additional_info - Additional info provided by the issue. |
||
| 379 | |||
| 380 | The groups ``line``, ``column``, ``end_line`` and |
||
| 381 | ``end_column`` don't have to match numbers only, they can |
||
| 382 | also match nothing, the generated ``Result`` is filled |
||
| 383 | automatically with ``None`` then for the appropriate |
||
| 384 | properties. |
||
| 385 | :param severity_map: |
||
| 386 | A dict used to map a severity string (captured from the |
||
| 387 | ``output_regex`` with the named group ``severity``) to an |
||
| 388 | actual ``coalib.results.RESULT_SEVERITY`` for a result. |
||
| 389 | :param result_message: |
||
| 390 | The static message to use for results instead of grabbing it |
||
| 391 | from the executable output via the ``message`` named regex |
||
| 392 | group. |
||
| 393 | :return: |
||
| 394 | An iterator returning results. |
||
| 395 | """ |
||
| 396 | for match in re.finditer(output_regex, output): |
||
| 397 | yield self._convert_output_regex_match_to_result( |
||
| 398 | match, filename, severity_map=severity_map, |
||
| 399 | result_message=result_message) |
||
| 400 | |||
| 401 | if options["output_format"] is None: |
||
| 402 | # Check if user supplied a `process_output` override. |
||
| 403 | if not callable(getattr(klass, "process_output", None)): |
||
| 404 | raise ValueError("`process_output` not provided by given " |
||
| 405 | "class {!r}.".format(klass.__name__)) |
||
| 406 | # No need to assign to `process_output` here, the class mixing |
||
| 407 | # below automatically does that. |
||
| 408 | else: |
||
| 409 | # Prevent people from accidentally defining `process_output` |
||
| 410 | # manually, as this would implicitly override the internally |
||
| 411 | # set-up `process_output`. |
||
| 412 | if hasattr(klass, "process_output"): |
||
| 413 | raise ValueError("Found `process_output` already defined " |
||
| 414 | "by class {!r}, but {!r} output-format is " |
||
| 415 | "specified.".format(klass.__name__, |
||
| 416 | options["output_format"])) |
||
| 417 | |||
| 418 | if options["output_format"] == "corrected": |
||
| 419 | _process_output_args = { |
||
| 420 | key: options[key] |
||
| 421 | for key in ("result_message", "diff_severity", |
||
| 422 | "diff_distance") |
||
| 423 | if key in options} |
||
| 424 | |||
| 425 | _processing_function = partialmethod( |
||
| 426 | process_output_corrected, **_process_output_args) |
||
| 427 | |||
| 428 | else: |
||
| 429 | assert options["output_format"] == "regex" |
||
| 430 | |||
| 431 | _process_output_args = { |
||
| 432 | key: options[key] |
||
| 433 | for key in ("output_regex", "severity_map", |
||
| 434 | "result_message") |
||
| 435 | if key in options} |
||
| 436 | |||
| 437 | _processing_function = partialmethod( |
||
| 438 | process_output_regex, **_process_output_args) |
||
| 439 | |||
| 440 | def process_output(self, output, filename, file): |
||
| 441 | if isinstance(output, str): |
||
| 442 | output = (output,) |
||
| 443 | |||
| 444 | for string in output: |
||
| 445 | yield from self._processing_function( |
||
| 446 | string, filename, file) |
||
| 447 | |||
| 448 | @classmethod |
||
| 449 | @contextmanager |
||
| 450 | def _create_config(cls, filename, file, **kwargs): |
||
| 451 | """ |
||
| 452 | Provides a context-manager that creates the config file if the |
||
| 453 | user provides one and cleans it up when done with linting. |
||
| 454 | |||
| 455 | :param filename: |
||
| 456 | The filename of the file. |
||
| 457 | :param file: |
||
| 458 | The file contents. |
||
| 459 | :param kwargs: |
||
| 460 | Section settings passed from ``run()``. |
||
| 461 | :return: |
||
| 462 | A context-manager handling the config-file. |
||
| 463 | """ |
||
| 464 | content = cls.generate_config(filename, file, **kwargs) |
||
| 465 | if content is None: |
||
| 466 | yield None |
||
| 467 | else: |
||
| 468 | with make_temp( |
||
| 469 | suffix=options["config_suffix"]) as config_file: |
||
| 470 | with open(config_file, mode="w") as fl: |
||
| 471 | fl.write(content) |
||
| 472 | yield config_file |
||
| 473 | |||
| 474 | def run(self, filename, file, **kwargs): |
||
| 475 | # Get the **kwargs params to forward to `generate_config()` |
||
| 476 | # (from `_create_config()`). |
||
| 477 | generate_config_kwargs = FunctionMetadata.filter_parameters( |
||
| 478 | self._get_generate_config_metadata(), kwargs) |
||
| 479 | |||
| 480 | with self._create_config( |
||
| 481 | filename, |
||
| 482 | file, |
||
| 483 | **generate_config_kwargs) as config_file: |
||
| 484 | # And now retrieve the **kwargs for `create_arguments()`. |
||
| 485 | create_arguments_kwargs = ( |
||
| 486 | FunctionMetadata.filter_parameters( |
||
| 487 | self._get_create_arguments_metadata(), kwargs)) |
||
| 488 | |||
| 489 | args = self.create_arguments(filename, file, config_file, |
||
| 490 | **create_arguments_kwargs) |
||
| 491 | |||
| 492 | try: |
||
| 493 | args = tuple(args) |
||
| 494 | except TypeError: |
||
| 495 | self.err("The given arguments " |
||
| 496 | "{!r} are not iterable.".format(args)) |
||
| 497 | return |
||
| 498 | |||
| 499 | arguments = (self.get_executable(),) + args |
||
| 500 | self.debug("Running '{}'".format(' '.join(arguments))) |
||
| 501 | |||
| 502 | output = run_shell_command( |
||
| 503 | arguments, |
||
| 504 | stdin="".join(file) if options["use_stdin"] else None, |
||
| 505 | cwd=self.get_config_dir()) |
||
| 506 | |||
| 507 | output = tuple(compress( |
||
| 508 | output, |
||
| 509 | (options["use_stdout"], options["use_stderr"]))) |
||
| 510 | if len(output) == 1: |
||
| 511 | output = output[0] |
||
| 512 | |||
| 513 | process_output_kwargs = FunctionMetadata.filter_parameters( |
||
| 514 | self._get_process_output_metadata(), kwargs) |
||
| 515 | return self.process_output(output, filename, file, |
||
| 516 | **process_output_kwargs) |
||
| 517 | |||
| 518 | def __repr__(self): |
||
| 519 | return "<{} linter object (wrapping {!r}) at {}>".format( |
||
| 520 | type(self).__name__, self.get_executable(), hex(id(self))) |
||
| 521 | |||
| 522 | # Mixin the linter into the user-defined interface, otherwise |
||
| 523 | # `create_arguments` and other methods would be overridden by the |
||
| 524 | # default version. |
||
| 525 | result_klass = type(klass.__name__, (klass, LinterBase), {}) |
||
| 526 | result_klass.__doc__ = klass.__doc__ or "" |
||
| 527 | return result_klass |
||
| 528 | |||
| 529 | |||
| 530 | @enforce_signature |
||
| 729 |