DistributionRequirement - Code Metrics - Inspection of "Add DistributionRequirement" - coala-analyzer/coala - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2542)

by Zatreanu

created 2016-07-24 12:46 UTC

DistributionRequirement A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	45
rs	10
wmc	3

2 Methods

Rating	Name	Duplication	Size	Complexity
B	install_command()	0	24	2
A	__init__()	0	14	1

from coalib.bears.requirements.PackageRequirement import PackageRequirement
import platform


class DistributionRequirement(PackageRequirement):
    """
    This class is a subclass of ``PackageRequirement``, and helps specifying
    distribution specific requirements, without using the manager name.
    """

    def __init__(self, **manager_commands):
class SomeParent:
    def __init__(self):
        self.x = 1

class SomeChild(SomeParent):
    def __init__(self):
        # Initialize the super class
        SomeParent.__init__(self)
        """
        Constructs a new ``DistributionRequirement``, using the
        ``PackageRequirement`` constructor.

        >>> dr =  DistributionRequirement(apt_get='libclang', dnf='libclangg')
        >>> dr.package['apt_get']
        'libclang'
        >>> dr.package['dnf']
        'libclangg'

        :param manager_commands: comma separated (manager='package') pairs.
        """
        self.package = manager_commands

    def install_command(self):  # pragma: no cover
        """
        Creates the installation command for the instance of the class.

        :param return: A string with the installation command. An empty string
                       if the command could not be supplied.
        """
        manager_dict = {'Fedora': 'dnf',
                        'Ubuntu': 'apt_get',
                        'Debian': 'apt_get',
                        'SuSE': 'zypper',
                        'redhat': 'yum',
                        'arch': 'pacman'}

        manager = manager_dict[platform.linux_distribution()[0]]
        if manager in self.package.keys():
            result = "{} install {}".format(manager.replace("_", "-"),
                self.package[manager])
            return result
        else:
            print('The package could not be automatically installed on your'
                  'operating system. Please try installing '
                  + self.package + 'manually.')
            return ""


1			from coalib.bears.requirements.PackageRequirement import PackageRequirement
2			import platform
3
4
5			class DistributionRequirement(PackageRequirement):
6			"""
7			This class is a subclass of ``PackageRequirement``, and helps specifying
8			distribution specific requirements, without using the manager name.
9			"""
10
11			def __init__(self, **manager_commands):
			0 ignored issues – show Bug introduced 2016-07-24 12:08 UTC by Report Bug Copy Issue Report The `__init__` method of the super-class `PackageRequirement` is not called. It is generally advisable to initialize the super-class by calling its `__init__` method: class SomeParent: def __init__(self): self.x = 1 class SomeChild(SomeParent): def __init__(self): # Initialize the super class SomeParent.__init__(self) Loading history...
12			"""
13			Constructs a new ``DistributionRequirement``, using the
14			``PackageRequirement`` constructor.
15
16			>>> dr = DistributionRequirement(apt_get='libclang', dnf='libclangg')
17			>>> dr.package['apt_get']
18			'libclang'
19			>>> dr.package['dnf']
20			'libclangg'
21
22			:param manager_commands: comma separated (manager='package') pairs.
23			"""
24			self.package = manager_commands
25
26			def install_command(self): # pragma: no cover
27			"""
28			Creates the installation command for the instance of the class.
29
30			:param return: A string with the installation command. An empty string
31			if the command could not be supplied.
32			"""
33			manager_dict = {'Fedora': 'dnf',
34			'Ubuntu': 'apt_get',
35			'Debian': 'apt_get',
36			'SuSE': 'zypper',
37			'redhat': 'yum',
38			'arch': 'pacman'}
39
40			manager = manager_dict[platform.linux_distribution()[0]]
41			if manager in self.package.keys():
42			result = "{} install {}".format(manager.replace("_", "-"),
43			self.package[manager])
44			return result
45			else:
46			print('The package could not be automatically installed on your'
47			'operating system. Please try installing '
48			+ self.package + 'manually.')
49			return ""
50

coala-analyzer / coala

Pull Request — master (#2542)

DistributionRequirement A

Complexity

Size/Duplication

Importance

2 Methods

Duplication Side-by-Side

Filter issues like