PackageRequirement.__init__() - Code Metrics - Inspection of "Bear.py: Add requirements property" - coala-analyzer/coala - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2166)

by Zatreanu

created 2016-05-21 23:04 UTC

PackageRequirement.init() A

↳ Parent: PackageRequirement

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
c	1
b	0
f	0
dl	0
loc	9
rs	9.6666

class PackageRequirement:

    def __init__(self, manager: str, package: str, version):
        """
        :param manager: A string with the name of the manager (pip, npm, etc).
        :param package: A string with the name of the package to be installed.
        :param version: A number that contains the version.
        """
        self.manager = manager
        self.package = package
        self.version = version

    def __str__(self):
        return "{.package} version {.version} (for {.manager})".format(self)

    def check(self):
        """
        Check if the requirement is satisfied.
        """
        raise NotImplementedError


class PythonRequirement(PackageRequirement):

    def __init__(self, package: str, version):
class SomeParent:
    def __init__(self):
        self.x = 1

class SomeChild(SomeParent):
    def __init__(self):
        # Initialize the super class
        SomeParent.__init__(self)
        """
        :param package: A string with the name of the package to be installed.
        :param version: A number that contains the version.
        """
        self.package = package
        self.version = version

    def __str__(self):
        return "{.package} version {.version}".format(self)

    def multiple(self, *args):
class Foo:
    def some_method(self, x, y):
        return x + y;
        return args


1			class PackageRequirement:
2
3			def __init__(self, manager: str, package: str, version):
4			"""
5			:param manager: A string with the name of the manager (pip, npm, etc).
6			:param package: A string with the name of the package to be installed.
7			:param version: A number that contains the version.
8			"""
9			self.manager = manager
10			self.package = package
11			self.version = version
12
13			def __str__(self):
14			return "{.package} version {.version} (for {.manager})".format(self)
15
16			def check(self):
17			"""
18			Check if the requirement is satisfied.
19			"""
20			raise NotImplementedError
21
22
23			class PythonRequirement(PackageRequirement):
24
25			def __init__(self, package: str, version):
			0 ignored issues – show Bug introduced 2016-05-21 23:06 UTC by Report Bug Copy Issue Report The `__init__` method of the super-class `PackageRequirement` is not called. It is generally advisable to initialize the super-class by calling its `__init__` method: class SomeParent: def __init__(self): self.x = 1 class SomeChild(SomeParent): def __init__(self): # Initialize the super class SomeParent.__init__(self) Loading history...
26			"""
27			:param package: A string with the name of the package to be installed.
28			:param version: A number that contains the version.
29			"""
30			self.package = package
31			self.version = version
32
33			def __str__(self):
34			return "{.package} version {.version}".format(self)
35
36			def multiple(self, *args):
			0 ignored issues – show Coding Style introduced 2016-05-21 23:06 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
37			return args
38

coala-analyzer / coala

Pull Request — master (#2166)

PackageRequirement.__init__() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

PackageRequirement.init() A