PackageRequirement.__init__() - Code Metrics - Inspection of "Add PackageRequirements" - coala-analyzer/coala - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2166)

by Zatreanu

created 2016-05-22 20:55 UTC

PackageRequirement.init() A

↳ Parent: PackageRequirement

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
c	1
b	0
f	0
dl	0
loc	9
rs	9.6666

from coala_decorators.decorators import generate_repr


@generate_repr()
class PackageRequirement:

    def __init__(self, manager: str, package: str, version: str):
        """
        :param manager: A string with the name of the manager (pip, npm, etc).
        :param package: A string with the name of the package to be installed.
        :param version: A number that contains the version.
        """
        self.manager = manager
        self.package = package
        self.version = version

    def check(self):
        """
        Check if the requirement is satisfied.
        """
        raise NotImplementedError


class PythonRequirement(PackageRequirement):

    def __init__(self, package, version):
        PackageRequirement.__init__(self, 'pip', package, version)

    def multiple(self, *args):
class Foo:
    def some_method(self, x, y):
        return x + y;
        return args


1			from coala_decorators.decorators import generate_repr
2
3
4			@generate_repr()
5			class PackageRequirement:
6
7			def __init__(self, manager: str, package: str, version: str):
8			"""
9			:param manager: A string with the name of the manager (pip, npm, etc).
10			:param package: A string with the name of the package to be installed.
11			:param version: A number that contains the version.
12			"""
13			self.manager = manager
14			self.package = package
15			self.version = version
16
17			def check(self):
18			"""
19			Check if the requirement is satisfied.
20			"""
21			raise NotImplementedError
22
23
24			class PythonRequirement(PackageRequirement):
25
26			def __init__(self, package, version):
27			PackageRequirement.__init__(self, 'pip', package, version)
28
29			def multiple(self, *args):
			0 ignored issues – show Coding Style introduced 2016-05-21 23:06 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
30			return args
31

coala-analyzer / coala

Pull Request — master (#2166)

PackageRequirement.__init__() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

PackageRequirement.init() A