excel.tasks

Complexity

Total Complexity

3

Size/Duplication

Total Lines	87
Duplicated Lines	68.97 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	ImportTemplateTask.run()	30	30	2
A	ImportTemplateTask.on_failure()	19	19	1

#!/usr/bin/env python3
# -*- coding: utf-8 -*-
"""
Created on Tue Jul  9 11:50:39 2019

@author: Paolo Cozzi <cozzi@ibba.cnr.it>
"""

from celery.utils.log import get_task_logger

from common.constants import ERROR
from image.celery import app as celery_app, MyTask
from image_app.models import Submission
from submissions.helpers import send_message

from .helpers import upload_template

# Get an instance of a logger
logger = get_task_logger(__name__)


class ImportTemplateTask(MyTask):

This code seems to be duplicated in your project.

    name = "Import Template"
    description = """Import Template data from Excel file"""

    # Ovverride default on failure method
    # This is not a failed validation for a wrong value, this is an
    # error in task that mean an error in coding
    def on_failure(self, exc, task_id, args, kwargs, einfo):
        logger.error('{0!r} failed: {1!r}'.format(task_id, exc))

        # get submissio object
        submission_obj = Submission.objects.get(pk=args[0])

        # mark submission with ERROR
        submission_obj.status = ERROR
        submission_obj.message = ("Error in Template loading: %s" % (str(exc)))
        submission_obj.save()

        # send async message
        send_message(submission_obj)

        # send a mail to the user with the stacktrace (einfo)
        submission_obj.owner.email_user(
            "Error in Template loading: %s" % (args[0]),
            ("Something goes wrong with template loading. Please report "
             "this to InjectTool team\n\n %s" % str(einfo)),
        )

        # TODO: submit mail to admin

    def run(self, submission_id):
        """a function to upload data into UID"""

        logger.info(
            "Start import from Template for submission: %s" % submission_id)

        # get a submission object
        submission = Submission.objects.get(pk=submission_id)

        # upload data into UID
        status = upload_template(submission)

        # if something went wrong, uploaded_cryoweb has token the exception
        # ad update submission.message field
        if status is False:
            message = "Error in uploading Template data"
            logger.error(message)

            # this a failure in my import, not the task itself
            return message

        else:
            message = "Template import completed for submission: %s" % (
                submission_id)

            # debug
            logger.info(message)

            # always return something
            return "success"


# register explicitly tasks
# https://github.com/celery/celery/issues/3744#issuecomment-271366923
celery_app.tasks.register(ImportTemplateTask)