biosample.tasks.retrieval.RetrievalCompleteTask.run() - Code Metrics - Inspection of ":zap: Batch submission to Biosamples" - cnr-ibba/IMAGE-InjectTool - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#44)

by Paolo

created 2019-07-25 13:31 UTC

RetrievalCompleteTask.run() B

↳ Parent: biosample.tasks.retrieval

Complexity

Conditions

Size

Total Lines	67
Code Lines	33

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	33
dl	0
loc	67
rs	7.688
c	0
b	0
f	0
cc	7
nop	3

How to fix Long Method

#!/usr/bin/env python3
# -*- coding: utf-8 -*-
"""
Created on Tue Jul 16 11:25:03 2019

@author: Paolo Cozzi <[email protected]>
"""

import os
import json

from decouple import AutoConfig
from celery.utils.log import get_task_logger

import pyUSIrest.client

from django.conf import settings
from django.db.models import Count
from django.utils import timezone

from image.celery import app as celery_app, MyTask
from image_app.helpers import parse_image_alias, get_model_object
from image_app.models import Submission
from common.tasks import redis_lock
from common.constants import (
    ERROR, NEED_REVISION, SUBMITTED, COMPLETED)
from submissions.helpers import send_message

from ..helpers import get_manager_auth
from ..models import Submission as USISubmission
from .submission import TaskFailureMixin

# Get an instance of a logger
logger = get_task_logger(__name__)

# define a decouple config object
settings_dir = os.path.join(settings.BASE_DIR, 'image')
config = AutoConfig(search_path=settings_dir)

# a threshold of days to determine a very long task
MAX_DAYS = 5


# HINT: how this class could be similar to SubmissionHelper?
class FetchStatusHelper():
    """Helper class to deal with submission data"""

    # define my class attributes
    def __init__(self, usi_submission):
        """
        Helper function to have info for a biosample.models.Submission

        Args:
            usi_submission (biosample.models.Submission): a biosample
                model Submission instance
        """

        # ok those are my default class attributes
        self.usi_submission = usi_submission
        self.uid_submission = usi_submission.uid_submission

        # here are pyUSIrest object
        self.auth = get_manager_auth()
        self.root = pyUSIrest.client.Root(self.auth)

        # here I will track the biosample submission
        self.submission_name = self.usi_submission.usi_submission_name
        self.submission = self.root.get_submission_by_name(
            submission_name=self.submission_name)

    def check_submission_status(self):
        logger.debug("Checking status for '%s'" % (
            self.submission_name))

        # Update submission status if completed
        if self.submission.status == 'Completed':
            # fetch biosample ids with a proper function
            self.complete()

        elif self.submission.status == 'Draft':
            # check for a long task
            if self.submission_has_issues():
                # return to the caller. I've just marked the submission with
                # errors and sent a mail to the user
                return

            # check validation. If it is ok, finalize submission
            status = self.submission.get_status()

            # this mean validation statuses, I want to see completed in all
            # samples
            if len(status) == 1 and 'Complete' in status:
                # check for errors and eventually finalize
                self.finalize()

            else:
                logger.warning(
                    "Biosample validation is not completed yet (%s)" %
                    (status))

        elif self.submission.status == 'Submitted':
            # check for a long task
            if self.submission_has_issues():
                # return to the caller. I've just marked the submission with
                # errors and sent a mail to the user
                return

            logger.info(
                "Submission '%s' is '%s'. Waiting for biosample ids" % (
                    self.submission_name,
                    self.submission.status))

            # debug submission status
            document = self.submission.follow_url(
                "processingStatusSummary", self.auth)

            logger.debug(
                "Current status for submission '%s' is '%s'" % (
                    self.submission_name, document.data))

        else:
            # HINT: thrown an exception?
            logger.warning("Unknown status '%s' for submission '%s'" % (
                self.submission.status,
                self.submission_name))

        logger.debug("Checking status for '%s' completed" % (
            self.submission_name))

    def submission_has_issues(self):
        """
        Check that biosample submission has not issues. For example, that
        it will remain in the same status for a long time

        Returns:
            bool: True if an issue is detected
        """

        logger.debug(
            "Check if submission '%s' remained in the same status "
            "for a long time" % (
                self.submission_name))

        if (timezone.now() - self.usi_submission.updated_at).days > MAX_DAYS:
            message = (
                "Biosample submission '%s' remained with the same status "
                "for more than %s days. Please report it to InjectTool "
                "team" % (self.submission_name, MAX_DAYS))

            self.usi_submission.status = ERROR
            self.usi_submission.message = message
            self.usi_submission.save()

            logger.error(
                "Errors for submission: %s" % (
                    self.submission_name))
            logger.error(message)

            return True

        else:
            return False

    def __sample_has_errors(self, sample, table, pk):
        """
        Helper metod to mark a (animal/sample) with its own errors. Table
        sould be Animal or Sample to update the approriate object. Sample
        is a USI sample object

        Args:
            sample (pyUSIrest.client.sample): a USI sample object
            table (str): ``Animal`` or ``Sample``, mean the table where this
                object should be searched
            pk (int): table primary key
        """

        # get sample/animal object relying on table name and pk
        sample_obj = get_model_object(table, pk)

        sample_obj.name.status = NEED_REVISION
        sample_obj.name.save()

        # get a USI validation result
        validation_result = sample.get_validation_result()

        # TODO: should I store validation_result error in validation tables?
        errorMessages = validation_result.errorMessages

        # return an error for each object
        return {str(sample_obj): errorMessages}

    def finalize(self):
        """Finalize a submission by closing document and send it to
        biosample"""

        logger.debug("Finalizing submission '%s'" % (
            self.submission_name))

        # get errors for a submission
        errors = self.submission.has_errors()

        # collect all error messages in a list
        messages = []

        if True in errors:
            # get sample with errors then update database
            samples = self.submission.get_samples(has_errors=True)

            for sample in samples:
                # derive pk and table from alias
                table, pk = parse_image_alias(sample.alias)

                # need to check if this sample/animals has errors or not
                if sample.has_errors():
                    logger.warning(
                        "%s in table %s has errors!!!" % (sample, table))

                    # mark this sample since has problems
                    errorMessages = self.__sample_has_errors(
                        sample, table, pk)

                    # append this into error messages list
                    messages.append(errorMessages)

                # if a sample has no errors, status will be the same

            logger.error(
                "Errors for submission: '%s'" % (self.submission_name))
            logger.error("Fix them, then finalize")

            # report error
            message = "Some items needs revision:\n\n" + \
                json.dumps(messages, indent=2)

            # Update status for biosample.models.Submission
            self.usi_submission.status = NEED_REVISION
            self.usi_submission.message = message
            self.usi_submission.save()

        else:
            # raising an exception while finalizing will result
            # in a failed task.
            # TODO: model and test exception in finalization
            self.submission.finalize()

    def complete(self):
        """Complete a submission and fetch name objects"""

        logger.debug("Completing submission '%s'" % (
            self.submission_name))

        for sample in self.submission.get_samples():
            # derive pk and table from alias
            table, pk = parse_image_alias(sample.alias)

            # if no accession, return without doing anything
            if sample.accession is None:
                logger.error("No accession found for sample '%s'" % (sample))
                logger.error("Ignoring submission '%s'" % (self.submission))
                return

            # get sample/animal object relying on table name and pk
            sample_obj = get_model_object(table, pk)

            # update statuses
            sample_obj.name.status = COMPLETED
            sample_obj.name.biosample_id = sample.accession
            sample_obj.name.save()

        # update submission
        self.usi_submission.status = COMPLETED
        self.usi_submission.message = "Successful submission into biosample"
        self.usi_submission.save()

        logger.info(
            "Submission %s is now completed and recorded into UID" % (
                self.submission))


class FetchStatusTask(MyTask):
    name = "Fetch USI status"
    description = """Fetch biosample using USI API"""
    lock_id = "FetchStatusTask"

    def run(self):
        """
        This function is called when delay is called. It will acquire a lock
        in redis, so those tasks are mutually exclusive

        Returns:
            str: success if everything is ok. Different messages if task is
            already running or exception is caught"""

        # debugging instance
        self.debug_task()

        # forcing blocking condition: Wait until a get a lock object
        with redis_lock(self.lock_id, blocking=False) as acquired:
            if acquired:
                # do stuff and return something
                return self.fetch_status()

        message = "%s already running!" % (self.name)

        logger.warning(message)

        return message

    def fetch_status(self):
        """
        Fetch status from pending submissions. Called from
        :py:meth:`run`, handles exceptions from USI, select
        all :py:class:`Submission <image_app.models.Submission>` objects
        with :py:const:`SUBMITTED <common.constants.SUBMITTED>` status
        from :ref:`UID <The Unified Internal Database>` and call
        :py:meth:`fetch_queryset` with this data
        """

        logger.info("fetch_status started")

        # search for submission with SUBMITTED status. Other submission are
        # not yet finalized. This function need to be called by exclusives
        # tasks
        qs = Submission.objects.filter(status=SUBMITTED)

        # check for queryset length
        if qs.count() != 0:
            try:
                # fetch biosample status
                self.fetch_queryset(qs)

            # retry a task under errors
            # http://docs.celeryproject.org/en/latest/userguide/tasks.html#retrying
            except ConnectionError as exc:
                raise self.retry(exc=exc)

        else:
            logger.debug("No pending submission in UID database")

        # debug
        logger.info("fetch_status completed")

        return "success"

    # a function to retrieve biosample submission
    def fetch_queryset(self, queryset):
        """Fetch biosample against a queryset (a list of
        :py:const:`SUBMITTED <common.constants.SUBMITTED>`
        :py:class:`Submission <image_app.models.Submission>` objects). Iterate
        through submission to get USI info. Calls
        :py:class:`FetchStatusHelper`
        """

        logger.info("Searching for submissions into biosample")

        for uid_submission in queryset:
            usi_submissions = USISubmission.objects.filter(
                uid_submission=uid_submission,
                status=SUBMITTED)

            # HINT: fetch statuses using tasks?
            for usi_submission in usi_submissions:
                status_helper = FetchStatusHelper(usi_submission)
                status_helper.check_submission_status()

            # set the final status for a submission like SubmissionCompleteTask
            retrievalcomplete = RetrievalCompleteTask()

            # assign kwargs to chord
            res = retrievalcomplete.s(uid_submission_id=uid_submission.id)

            logger.info(
                "Start RetrievalCompleteTask process for %s with task %s" % (
                    uid_submission,
                    res.task_id))

        logger.info("fetch_queryset completed")


class RetrievalCompleteTask(TaskFailureMixin, MyTask):
    """Update submission status after fetching status"""

    name = "Complete Retrieval Process"
    description = """Check submission status after retrieval nd update stuff"""

    def run(self, *args, **kwargs):
        """Fetch submission data and then update UID submission status"""

        # get UID submission
        uid_submission = Submission.objects.get(
            pk=kwargs['uid_submission_id'])

        # fetch data from database
        submission_qs = USISubmission.objects.filter(
            uid_submission=uid_submission)

        # annotate biosample submission by statuses
        statuses = {}

        for res in submission_qs.values('status').annotate(
                count=Count('status')):
            statuses[res['status']] = res['count']

        if SUBMITTED in statuses:
            # ignoring the other models. No errors thrown until there is
            # as SUBMITTED USISubmission
            logger.info("Submission %s not yet finished" % uid_submission)

            return "success"

        # if there is ANY errors in biosample.models.Submission for a
        # particoular submission, I will mark it as ERROR
        elif ERROR in statuses:
            # submission failed
            logger.info("Submission %s failed" % uid_submission)

            self.__update_message(uid_submission, submission_qs, ERROR)

            # send a mail to the user
            uid_submission.owner.email_user(
                "Error in biosample submission %s" % (
                    uid_submission.id),
                ("Something goes wrong with biosample submission. Please "
                 "report this to InjectTool team\n\n"
                 "%s" % uid_submission.message),
            )

        # check if submission need revision
        elif NEED_REVISION in statuses:
            # submission failed
            logger.info("Submission %s failed" % uid_submission)

            self.__update_message(uid_submission, submission_qs, NEED_REVISION)

            # send a mail to the user
            uid_submission.owner.email_user(
                "Error in biosample submission %s" % (
                    uid_submission.id),
                uid_submission.message,
            )

        elif COMPLETED in statuses and len(statuses) == 1:
            # if all status are complete, the submission is completed
            logger.info(
                "Submission %s completed with success" % uid_submission)

            self.__update_message(uid_submission, submission_qs, COMPLETED)

        # send async message
        send_message(uid_submission)

        return "success"

    def __update_message(self, uid_submission, submission_qs, status):
        """Read biosample.models.Submission message and set
        image_app.models.Submission message"""

        # get error messages for submission
        message = []

        for submission in submission_qs.filter(status=status):
            message.append(submission.message)

        uid_submission.status = status
        uid_submission.message = "\n".join(set(message))
        uid_submission.save()


# register explicitly tasks
# https://github.com/celery/celery/issues/3744#issuecomment-271366923
celery_app.tasks.register(FetchStatusTask)
celery_app.tasks.register(RetrievalCompleteTask)


1			#!/usr/bin/env python3
2			# -- coding: utf-8 --
3			"""
4			Created on Tue Jul 16 11:25:03 2019
5
6			@author: Paolo Cozzi <[email protected]>
7			"""
8
9			import os
10			import json
11
12			from decouple import AutoConfig
13			from celery.utils.log import get_task_logger
14
15			import pyUSIrest.client
16
17			from django.conf import settings
18			from django.db.models import Count
19			from django.utils import timezone
20
21			from image.celery import app as celery_app, MyTask
22			from image_app.helpers import parse_image_alias, get_model_object
23			from image_app.models import Submission
24			from common.tasks import redis_lock
25			from common.constants import (
26			ERROR, NEED_REVISION, SUBMITTED, COMPLETED)
27			from submissions.helpers import send_message
28
29			from ..helpers import get_manager_auth
30			from ..models import Submission as USISubmission
31			from .submission import TaskFailureMixin
32
33			# Get an instance of a logger
34			logger = get_task_logger(__name__)
35
36			# define a decouple config object
37			settings_dir = os.path.join(settings.BASE_DIR, 'image')
38			config = AutoConfig(search_path=settings_dir)
39
40			# a threshold of days to determine a very long task
41			MAX_DAYS = 5
42
43
44			# HINT: how this class could be similar to SubmissionHelper?
45			class FetchStatusHelper():
46			"""Helper class to deal with submission data"""
47
48			# define my class attributes
49			def __init__(self, usi_submission):
50			"""
51			Helper function to have info for a biosample.models.Submission
52
53			Args:
54			usi_submission (biosample.models.Submission): a biosample
55			model Submission instance
56			"""
57
58			# ok those are my default class attributes
59			self.usi_submission = usi_submission
60			self.uid_submission = usi_submission.uid_submission
61
62			# here are pyUSIrest object
63			self.auth = get_manager_auth()
64			self.root = pyUSIrest.client.Root(self.auth)
65
66			# here I will track the biosample submission
67			self.submission_name = self.usi_submission.usi_submission_name
68			self.submission = self.root.get_submission_by_name(
69			submission_name=self.submission_name)
70
71			def check_submission_status(self):
72			logger.debug("Checking status for '%s'" % (
73			self.submission_name))
74
75			# Update submission status if completed
76			if self.submission.status == 'Completed':
77			# fetch biosample ids with a proper function
78			self.complete()
79
80			elif self.submission.status == 'Draft':
81			# check for a long task
82			if self.submission_has_issues():
83			# return to the caller. I've just marked the submission with
84			# errors and sent a mail to the user
85			return
86
87			# check validation. If it is ok, finalize submission
88			status = self.submission.get_status()
89
90			# this mean validation statuses, I want to see completed in all
91			# samples
92			if len(status) == 1 and 'Complete' in status:
93			# check for errors and eventually finalize
94			self.finalize()
95
96			else:
97			logger.warning(
98			"Biosample validation is not completed yet (%s)" %
99			(status))
100
101			elif self.submission.status == 'Submitted':
102			# check for a long task
103			if self.submission_has_issues():
104			# return to the caller. I've just marked the submission with
105			# errors and sent a mail to the user
106			return
107
108			logger.info(
109			"Submission '%s' is '%s'. Waiting for biosample ids" % (
110			self.submission_name,
111			self.submission.status))
112
113			# debug submission status
114			document = self.submission.follow_url(
115			"processingStatusSummary", self.auth)
116
117			logger.debug(
118			"Current status for submission '%s' is '%s'" % (
119			self.submission_name, document.data))
120
121			else:
122			# HINT: thrown an exception?
123			logger.warning("Unknown status '%s' for submission '%s'" % (
124			self.submission.status,
125			self.submission_name))
126
127			logger.debug("Checking status for '%s' completed" % (
128			self.submission_name))
129
130			def submission_has_issues(self):
131			"""
132			Check that biosample submission has not issues. For example, that
133			it will remain in the same status for a long time
134
135			Returns:
136			bool: True if an issue is detected
137			"""
138
139			logger.debug(
140			"Check if submission '%s' remained in the same status "
141			"for a long time" % (
142			self.submission_name))
143
144			if (timezone.now() - self.usi_submission.updated_at).days > MAX_DAYS:
145			message = (
146			"Biosample submission '%s' remained with the same status "
147			"for more than %s days. Please report it to InjectTool "
148			"team" % (self.submission_name, MAX_DAYS))
149
150			self.usi_submission.status = ERROR
151			self.usi_submission.message = message
152			self.usi_submission.save()
153
154			logger.error(
155			"Errors for submission: %s" % (
156			self.submission_name))
157			logger.error(message)
158
159			return True
160
161			else:
162			return False
163
164			def __sample_has_errors(self, sample, table, pk):
165			"""
166			Helper metod to mark a (animal/sample) with its own errors. Table
167			sould be Animal or Sample to update the approriate object. Sample
168			is a USI sample object
169
170			Args:
171			sample (pyUSIrest.client.sample): a USI sample object
172			table (str): ``Animal`` or ``Sample``, mean the table where this
173			object should be searched
174			pk (int): table primary key
175			"""
176
177			# get sample/animal object relying on table name and pk
178			sample_obj = get_model_object(table, pk)
179
180			sample_obj.name.status = NEED_REVISION
181			sample_obj.name.save()
182
183			# get a USI validation result
184			validation_result = sample.get_validation_result()
185
186			# TODO: should I store validation_result error in validation tables?
187			errorMessages = validation_result.errorMessages
188
189			# return an error for each object
190			return {str(sample_obj): errorMessages}
191
192			def finalize(self):
193			"""Finalize a submission by closing document and send it to
194			biosample"""
195
196			logger.debug("Finalizing submission '%s'" % (
197			self.submission_name))
198
199			# get errors for a submission
200			errors = self.submission.has_errors()
201
202			# collect all error messages in a list
203			messages = []
204
205			if True in errors:
206			# get sample with errors then update database
207			samples = self.submission.get_samples(has_errors=True)
208
209			for sample in samples:
210			# derive pk and table from alias
211			table, pk = parse_image_alias(sample.alias)
212
213			# need to check if this sample/animals has errors or not
214			if sample.has_errors():
215			logger.warning(
216			"%s in table %s has errors!!!" % (sample, table))
217
218			# mark this sample since has problems
219			errorMessages = self.__sample_has_errors(
220			sample, table, pk)
221
222			# append this into error messages list
223			messages.append(errorMessages)
224
225			# if a sample has no errors, status will be the same
226
227			logger.error(
228			"Errors for submission: '%s'" % (self.submission_name))
229			logger.error("Fix them, then finalize")
230
231			# report error
232			message = "Some items needs revision:\n\n" + \
233			json.dumps(messages, indent=2)
234
235			# Update status for biosample.models.Submission
236			self.usi_submission.status = NEED_REVISION
237			self.usi_submission.message = message
238			self.usi_submission.save()
239
240			else:
241			# raising an exception while finalizing will result
242			# in a failed task.
243			# TODO: model and test exception in finalization
244			self.submission.finalize()
245
246			def complete(self):
247			"""Complete a submission and fetch name objects"""
248
249			logger.debug("Completing submission '%s'" % (
250			self.submission_name))
251
252			for sample in self.submission.get_samples():
253			# derive pk and table from alias
254			table, pk = parse_image_alias(sample.alias)
255
256			# if no accession, return without doing anything
257			if sample.accession is None:
258			logger.error("No accession found for sample '%s'" % (sample))
259			logger.error("Ignoring submission '%s'" % (self.submission))
260			return
261
262			# get sample/animal object relying on table name and pk
263			sample_obj = get_model_object(table, pk)
264
265			# update statuses
266			sample_obj.name.status = COMPLETED
267			sample_obj.name.biosample_id = sample.accession
268			sample_obj.name.save()
269
270			# update submission
271			self.usi_submission.status = COMPLETED
272			self.usi_submission.message = "Successful submission into biosample"
273			self.usi_submission.save()
274
275			logger.info(
276			"Submission %s is now completed and recorded into UID" % (
277			self.submission))
278
279
280			class FetchStatusTask(MyTask):
281			name = "Fetch USI status"
282			description = """Fetch biosample using USI API"""
283			lock_id = "FetchStatusTask"
284
285			def run(self):
286			"""
287			This function is called when delay is called. It will acquire a lock
288			in redis, so those tasks are mutually exclusive
289
290			Returns:
291			str: success if everything is ok. Different messages if task is
292			already running or exception is caught"""
293
294			# debugging instance
295			self.debug_task()
296
297			# forcing blocking condition: Wait until a get a lock object
298			with redis_lock(self.lock_id, blocking=False) as acquired:
299			if acquired:
300			# do stuff and return something
301			return self.fetch_status()
302
303			message = "%s already running!" % (self.name)
304
305			logger.warning(message)
306
307			return message
308
309			def fetch_status(self):
310			"""
311			Fetch status from pending submissions. Called from
312			:py:meth:`run`, handles exceptions from USI, select
313			all :py:class:`Submission <image_app.models.Submission>` objects
314			with :py:const:`SUBMITTED <common.constants.SUBMITTED>` status
315			from :ref:`UID <The Unified Internal Database>` and call
316			:py:meth:`fetch_queryset` with this data
317			"""
318
319			logger.info("fetch_status started")
320
321			# search for submission with SUBMITTED status. Other submission are
322			# not yet finalized. This function need to be called by exclusives
323			# tasks
324			qs = Submission.objects.filter(status=SUBMITTED)
325
326			# check for queryset length
327			if qs.count() != 0:
328			try:
329			# fetch biosample status
330			self.fetch_queryset(qs)
331
332			# retry a task under errors
333			# http://docs.celeryproject.org/en/latest/userguide/tasks.html#retrying
334			except ConnectionError as exc:
335			raise self.retry(exc=exc)
336
337			else:
338			logger.debug("No pending submission in UID database")
339
340			# debug
341			logger.info("fetch_status completed")
342
343			return "success"
344
345			# a function to retrieve biosample submission
346			def fetch_queryset(self, queryset):
347			"""Fetch biosample against a queryset (a list of
348			:py:const:`SUBMITTED <common.constants.SUBMITTED>`
349			:py:class:`Submission <image_app.models.Submission>` objects). Iterate
350			through submission to get USI info. Calls
351			:py:class:`FetchStatusHelper`
352			"""
353
354			logger.info("Searching for submissions into biosample")
355
356			for uid_submission in queryset:
357			usi_submissions = USISubmission.objects.filter(
358			uid_submission=uid_submission,
359			status=SUBMITTED)
360
361			# HINT: fetch statuses using tasks?
362			for usi_submission in usi_submissions:
363			status_helper = FetchStatusHelper(usi_submission)
364			status_helper.check_submission_status()
365
366			# set the final status for a submission like SubmissionCompleteTask
367			retrievalcomplete = RetrievalCompleteTask()
368
369			# assign kwargs to chord
370			res = retrievalcomplete.s(uid_submission_id=uid_submission.id)
371
372			logger.info(
373			"Start RetrievalCompleteTask process for %s with task %s" % (
374			uid_submission,
375			res.task_id))
376
377			logger.info("fetch_queryset completed")
378
379
380			class RetrievalCompleteTask(TaskFailureMixin, MyTask):
381			"""Update submission status after fetching status"""
382
383			name = "Complete Retrieval Process"
384			description = """Check submission status after retrieval nd update stuff"""
385
386			def run(self, args, *kwargs):
387			"""Fetch submission data and then update UID submission status"""
388
389			# get UID submission
390			uid_submission = Submission.objects.get(
391			pk=kwargs['uid_submission_id'])
392
393			# fetch data from database
394			submission_qs = USISubmission.objects.filter(
395			uid_submission=uid_submission)
396
397			# annotate biosample submission by statuses
398			statuses = {}
399
400			for res in submission_qs.values('status').annotate(
401			count=Count('status')):
402			statuses[res['status']] = res['count']
403
404			if SUBMITTED in statuses:
405			# ignoring the other models. No errors thrown until there is
406			# as SUBMITTED USISubmission
407			logger.info("Submission %s not yet finished" % uid_submission)
408
409			return "success"
410
411			# if there is ANY errors in biosample.models.Submission for a
412			# particoular submission, I will mark it as ERROR
413			elif ERROR in statuses:
414			# submission failed
415			logger.info("Submission %s failed" % uid_submission)
416
417			self.__update_message(uid_submission, submission_qs, ERROR)
418
419			# send a mail to the user
420			uid_submission.owner.email_user(
421			"Error in biosample submission %s" % (
422			uid_submission.id),
423			("Something goes wrong with biosample submission. Please "
424			"report this to InjectTool team\n\n"
425			"%s" % uid_submission.message),
426			)
427
428			# check if submission need revision
429			elif NEED_REVISION in statuses:
430			# submission failed
431			logger.info("Submission %s failed" % uid_submission)
432
433			self.__update_message(uid_submission, submission_qs, NEED_REVISION)
434
435			# send a mail to the user
436			uid_submission.owner.email_user(
437			"Error in biosample submission %s" % (
438			uid_submission.id),
439			uid_submission.message,
440			)
441
442			elif COMPLETED in statuses and len(statuses) == 1:
443			# if all status are complete, the submission is completed
444			logger.info(
445			"Submission %s completed with success" % uid_submission)
446
447			self.__update_message(uid_submission, submission_qs, COMPLETED)
448
449			# send async message
450			send_message(uid_submission)
451
452			return "success"
453
454			def __update_message(self, uid_submission, submission_qs, status):
455			"""Read biosample.models.Submission message and set
456			image_app.models.Submission message"""
457
458			# get error messages for submission
459			message = []
460
461			for submission in submission_qs.filter(status=status):
462			message.append(submission.message)
463
464			uid_submission.status = status
465			uid_submission.message = "\n".join(set(message))
466			uid_submission.save()
467
468
469			# register explicitly tasks
470			# https://github.com/celery/celery/issues/3744#issuecomment-271366923
471			celery_app.tasks.register(FetchStatusTask)
472			celery_app.tasks.register(RetrievalCompleteTask)
473

cnr-ibba / IMAGE-InjectTool

Pull Request — master (#44)

RetrievalCompleteTask.run() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like