DirectDebitPayment::toArray() - Code Metrics - cmpayments/payments-sdk-php - Measure and Improve Code Quality continuously with Scrutinizer

DirectDebitPayment::toArray() A
last analyzed 2017-11-07 08:22 UTC

↳ Parent: DirectDebitPayment

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	15
ccs	11
cts	11
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	10
nc	2
nop	0
crap	2

<?php

namespace CMPayments\PaymentSdk\Entities;

use Money\Money;

/**
 * Class DirectDebitPayment
 * @package CMPayments\PaymentSdk\Entities
 * @author Jory Geerts <[email protected]>
 */
class DirectDebitPayment extends Payment
{
    /**
     * @var string
     */
    private $description;
    /**
     * @var string
     */
    private $iban;
    /**
     * @var string
     */
    private $name;
    /**
     * @var string
     */
    private $mandateId;
    /**
     * @var \DateTime
     */
    private $mandateStartDate;
    /**
     * @var null|string
     */
    private $transactionDescription;

    /**
     * IdealPayment constructor.
     * @param Money $money
     * @param string $purchaseId
     * @param string $iban
     * @param string $name
     * @param string $mandateId
     * @param \DateTime $mandateStartDate
     * @param string $description
     * @param string $transactionDescription = null
     * @internal param string $bic
     */
    public function __construct(
        Money $money,
        $purchaseId,
        $iban,
        $name,
        $mandateId,
        \DateTime $mandateStartDate,
        $description,
        $transactionDescription = null
    ) {
        parent::__construct($money, 'DirectDebit', $purchaseId);

        $this->description = $description;
        $this->iban = $iban;
        $this->name = $name;
        $this->mandateId = $mandateId;
        $this->mandateStartDate = $mandateStartDate;
        $this->transactionDescription = $transactionDescription;
    }

    /** @inheritdoc */
    public function toArray()
    {
        $array = parent::toArray();
        $array['payment_details']['bank_account_number'] = $this->iban;
        $array['payment_details']['name'] = $this->name;
        $array['payment_details']['mandate_id'] = $this->mandateId;
        $array['payment_details']['mandate_start_date'] = $this->mandateStartDate->format('Y-m-d');
        $array['payment_details']['description'] = $this->description;

        if ($this->transactionDescription) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $array['payment_details']['transaction_description'] = $this->transactionDescription;
        }

        return $array;
    }
}


1		<?php
2
3		namespace CMPayments\PaymentSdk\Entities;
4
5		use Money\Money;
6
7		/**
8		* Class DirectDebitPayment
9		* @package CMPayments\PaymentSdk\Entities
10		* @author Jory Geerts <[email protected]>
11		*/
12		class DirectDebitPayment extends Payment
13		{
14		/**
15		* @var string
16		*/
17		private $description;
18		/**
19		* @var string
20		*/
21		private $iban;
22		/**
23		* @var string
24		*/
25		private $name;
26		/**
27		* @var string
28		*/
29		private $mandateId;
30		/**
31		* @var \DateTime
32		*/
33		private $mandateStartDate;
34		/**
35		* @var null\|string
36		*/
37		private $transactionDescription;
38
39		/**
40		* IdealPayment constructor.
41		* @param Money $money
42		* @param string $purchaseId
43		* @param string $iban
44		* @param string $name
45		* @param string $mandateId
46		* @param \DateTime $mandateStartDate
47		* @param string $description
48		* @param string $transactionDescription = null
49		* @internal param string $bic
50		*/
51	1	public function __construct(
52		Money $money,
53		$purchaseId,
54		$iban,
55		$name,
56		$mandateId,
57		\DateTime $mandateStartDate,
58		$description,
59		$transactionDescription = null
60		) {
61	1	parent::__construct($money, 'DirectDebit', $purchaseId);
62
63	1	$this->description = $description;
64	1	$this->iban = $iban;
65	1	$this->name = $name;
66	1	$this->mandateId = $mandateId;
67	1	$this->mandateStartDate = $mandateStartDate;
68	1	$this->transactionDescription = $transactionDescription;
69	1	}
70
71		/** @inheritdoc */
72	1	public function toArray()
73		{
74	1	$array = parent::toArray();
75	1	$array['payment_details']['bank_account_number'] = $this->iban;
76	1	$array['payment_details']['name'] = $this->name;
77	1	$array['payment_details']['mandate_id'] = $this->mandateId;
78	1	$array['payment_details']['mandate_start_date'] = $this->mandateStartDate->format('Y-m-d');
79	1	$array['payment_details']['description'] = $this->description;
80
81	1	if ($this->transactionDescription) {
		0 ignored issues – show Bug Best Practice introduced 2017-11-06 12:46 UTC by Report Bug Copy Issue Report The expression `$this->transactionDescription` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
82	1	$array['payment_details']['transaction_description'] = $this->transactionDescription;
83	1	}
84
85	1	return $array;
86		}
87		}
88

cmpayments / payments-sdk-php

GitHub Access Token became invalid

DirectDebitPayment::toArray() A last analyzed 2017-11-07 08:22 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

DirectDebitPayment::toArray() A
last analyzed 2017-11-07 08:22 UTC