FormatTrait::validateFormat() - Code Metrics - cmpayments/json-schema-validator - Measure and Improve Code Quality continuously with Scrutinizer

FormatTrait::validateFormat() C
last analyzed 2017-02-02 15:24 UTC

↳ Parent: FormatTrait

Complexity

Conditions	17
Paths	14

Size

Total Lines	61
Code Lines	31

Duplication

Lines	18
Ratio	29.51 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	17
eloc	31
nc	14
nop	3
dl	18
loc	61
rs	6.1902
c	1
b	0
f	1

How to fix Long Method Complexity

<?php namespace CMPayments\SchemaValidator\Validators;

use CMPayments\SchemaValidator\BaseValidator;
use CMPayments\SchemaValidator\Exceptions\ValidateException;

/**
 * Class FormatTrait
 *
 * @package CMPayments\SchemaValidator\Validators
 * @Author  Boy Wijnmaalen <[email protected]>
 */
trait FormatTrait
{
    /**
     * Validates $data against a specific $schema->format
     *
     * @param $data
     * @param $schema
     * @param string $path
     */
    public function validateFormat($data, $schema, $path)
    {
        if (!isset($schema->format)) {
            return;
        }

        switch ($schema->format) {

            // DATE
            case BaseValidator::DATE:

                if (!$date = $this->validateDateTime($data, 'Y-m-d')) {

                    $this->addError(ValidateException::ERROR_USER_FORMAT_INVALID_DATE, [$data, $path]);
                }
                break;

            // DATETIME
            case BaseValidator::DATETIME:
                if (!$this->validateDateTime($data, 'Y-m-d\TH:i:s\Z')
                    && !$this->validateDateTime($data, 'Y-m-d\TH:i:s.u\Z')
                    && !$this->validateDateTime($data, \DateTime::RFC3339)
                    && !$this->validateDateTime($data, \DateTime::ISO8601)
                ) {
                    $this->addError(ValidateException::ERROR_USER_FORMAT_INVALID_DATETIME, [$data, $path]);
                }
                break;

            // EMAIL
            case BaseValidator::EMAIL:
                if (is_null(filter_var($data, FILTER_VALIDATE_EMAIL, FILTER_NULL_ON_FAILURE))) {

                    $this->addError(ValidateException::ERROR_USER_FORMAT_INVALID_EMAIL, [$data, $path]);
                }
                break;

            // TIME
            case BaseValidator::TIME:

                if (!$this->validateDateTime($data, 'H:i:s')) {

                    $this->addError(ValidateException::ERROR_USER_FORMAT_INVALID_TIME, [$data, $path]);
                }
                break;

            // UTC_SECONDS (in epoch seconds)
            case BaseValidator::UTC_SECONDS:

                if (!$this->validateDateTime((string)$data, 'U')) { // U = Seconds since the Unix Epoch

                    $this->addError(ValidateException::ERROR_USER_FORMAT_INVALID_UTC_SECONDS, [$data, $path]);
                }
                break;

            // URL
            case BaseValidator::URL:
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

                if (filter_var($data, FILTER_VALIDATE_URL, FILTER_FLAG_SCHEME_REQUIRED | FILTER_FLAG_HOST_REQUIRED) === false) {

                    $this->addError(ValidateException::ERROR_USER_FORMAT_INVALID_URL, [$data, $path]);
                }
                break;
        }
    }

    /**
     * Validate a $datetime string and match it againt a $format
     *
     * @param $datetime
     * @param string $format
     *
     * @return bool
     */
    protected function validateDateTime($datetime, $format)
    {
        $dt = \DateTime::createFromFormat($format, $datetime);

        if (!$dt) {
            return false;
        }

        return $datetime === $dt->format($format);
    }

    /**
     * @param int   $code
     * @param array $args
     *
     * @return mixed
     */
    abstract public function addError($code, array $args = []);
}


1		<?php namespace CMPayments\SchemaValidator\Validators;
2
3		use CMPayments\SchemaValidator\BaseValidator;
4		use CMPayments\SchemaValidator\Exceptions\ValidateException;
5
6		/**
7		* Class FormatTrait
8		*
9		* @package CMPayments\SchemaValidator\Validators
10		* @Author Boy Wijnmaalen <[email protected]>
11		*/
12		trait FormatTrait
13		{
14		/**
15		* Validates $data against a specific $schema->format
16		*
17		* @param $data
18		* @param $schema
19		* @param string $path
20		*/
21		public function validateFormat($data, $schema, $path)
22		{
23		if (!isset($schema->format)) {
24		return;
25		}
26
27		switch ($schema->format) {
28
29		// DATE
30	View Code Duplication	case BaseValidator::DATE:
		0 ignored issues – show Duplication introduced 2016-03-25 13:19 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
31		if (!$date = $this->validateDateTime($data, 'Y-m-d')) {
32
33		$this->addError(ValidateException::ERROR_USER_FORMAT_INVALID_DATE, [$data, $path]);
34		}
35		break;
36
37		// DATETIME
38		case BaseValidator::DATETIME:
39		if (!$this->validateDateTime($data, 'Y-m-d\TH:i:s\Z')
40		&& !$this->validateDateTime($data, 'Y-m-d\TH:i:s.u\Z')
41		&& !$this->validateDateTime($data, \DateTime::RFC3339)
42		&& !$this->validateDateTime($data, \DateTime::ISO8601)
43		) {
44		$this->addError(ValidateException::ERROR_USER_FORMAT_INVALID_DATETIME, [$data, $path]);
45		}
46		break;
47
48		// EMAIL
49		case BaseValidator::EMAIL:
50		if (is_null(filter_var($data, FILTER_VALIDATE_EMAIL, FILTER_NULL_ON_FAILURE))) {
51
52		$this->addError(ValidateException::ERROR_USER_FORMAT_INVALID_EMAIL, [$data, $path]);
53		}
54		break;
55
56		// TIME
57	View Code Duplication	case BaseValidator::TIME:
		0 ignored issues – show Duplication introduced 2016-03-25 13:19 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
58		if (!$this->validateDateTime($data, 'H:i:s')) {
59
60		$this->addError(ValidateException::ERROR_USER_FORMAT_INVALID_TIME, [$data, $path]);
61		}
62		break;
63
64		// UTC_SECONDS (in epoch seconds)
65	View Code Duplication	case BaseValidator::UTC_SECONDS:
		0 ignored issues – show Duplication introduced 2016-03-25 13:19 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
66		if (!$this->validateDateTime((string)$data, 'U')) { // U = Seconds since the Unix Epoch
67
68		$this->addError(ValidateException::ERROR_USER_FORMAT_INVALID_UTC_SECONDS, [$data, $path]);
69		}
70		break;
71
72		// URL
73		case BaseValidator::URL:
		0 ignored issues – show Coding Style introduced 2016-03-25 13:19 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
74
75		if (filter_var($data, FILTER_VALIDATE_URL, FILTER_FLAG_SCHEME_REQUIRED \| FILTER_FLAG_HOST_REQUIRED) === false) {
76
77		$this->addError(ValidateException::ERROR_USER_FORMAT_INVALID_URL, [$data, $path]);
78		}
79		break;
80		}
81		}
82
83		/**
84		* Validate a $datetime string and match it againt a $format
85		*
86		* @param $datetime
87		* @param string $format
88		*
89		* @return bool
90		*/
91		protected function validateDateTime($datetime, $format)
92		{
93		$dt = \DateTime::createFromFormat($format, $datetime);
94
95		if (!$dt) {
96		return false;
97		}
98
99		return $datetime === $dt->format($format);
100		}
101
102		/**
103		* @param int $code
104		* @param array $args
105		*
106		* @return mixed
107		*/
108		abstract public function addError($code, array $args = []);
109		}
110

cmpayments / json-schema-validator

FormatTrait::validateFormat() C last analyzed 2017-02-02 15:24 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like

FormatTrait::validateFormat() C
last analyzed 2017-02-02 15:24 UTC