Executable::__construct() - Code Metrics - cmpayments/atreyu - Measure and Improve Code Quality continuously with Scrutinizer

Executable::__construct() A
last analyzed 2017-02-08 16:25 UTC

↳ Parent: Executable

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	7
nc	2
nop	2

<?php

namespace Atreyu;

class Executable
{
    private $callableReflection;
    private $invocationObject;
    private $isInstanceMethod;

    public function __construct(\ReflectionFunctionAbstract $reflFunc, $invocationObject = null)
    {
        if ($reflFunc instanceof \ReflectionMethod) {
            $this->isInstanceMethod = true;
            $this->setMethodCallable($reflFunc, $invocationObject);
        } else {
            $this->isInstanceMethod = false;
            $this->callableReflection = $reflFunc;
        }
    }

    private function setMethodCallable(\ReflectionMethod $reflection, $invocationObject)
    {
        if (is_object($invocationObject)) {
            $this->callableReflection = $reflection;
            $this->invocationObject = $invocationObject;
        } elseif ($reflection->isStatic()) {
            $this->callableReflection = $reflection;
        } else {
            throw new \InvalidArgumentException(
                'ReflectionMethod callables must specify an invocation object'
            );
        }
    }

    public function __invoke()
    {
        $args = func_get_args();
        $reflection = $this->callableReflection;

        if ($this->isInstanceMethod) {
            return $reflection->invokeArgs($this->invocationObject, $args);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        }

        return $this->callableReflection->isClosure()
            ? $this->invokeClosureCompat($reflection, $args)
            : $reflection->invokeArgs($args);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    /**
     * @TODO Remove this extra indirection when 5.3 support is dropped
     * @param $reflection
     * @param $args
     *
     * @return mixed
     */
    private function invokeClosureCompat($reflection, $args)
    {
        if (version_compare(PHP_VERSION, '5.4.0') >= 0) {
            $scope = $reflection->getClosureScopeClass();
            $closure = \Closure::bind(
                $reflection->getClosure(),
                $reflection->getClosureThis(),
                $scope ? $scope->name : null
            );
            return call_user_func_array($closure, $args);
        } else {
            return $reflection->invokeArgs($args);
        }
    }

    public function getCallableReflection()
    {
        return $this->callableReflection;
    }

    public function getInvocationObject()
    {
        return $this->invocationObject;
    }

    public function isInstanceMethod()
    {
        return $this->isInstanceMethod;
    }
}


1			<?php
2
3			namespace Atreyu;
4
5			class Executable
6			{
7			private $callableReflection;
8			private $invocationObject;
9			private $isInstanceMethod;
10
11			public function __construct(\ReflectionFunctionAbstract $reflFunc, $invocationObject = null)
12			{
13			if ($reflFunc instanceof \ReflectionMethod) {
14			$this->isInstanceMethod = true;
15			$this->setMethodCallable($reflFunc, $invocationObject);
16			} else {
17			$this->isInstanceMethod = false;
18			$this->callableReflection = $reflFunc;
19			}
20			}
21
22			private function setMethodCallable(\ReflectionMethod $reflection, $invocationObject)
23			{
24			if (is_object($invocationObject)) {
25			$this->callableReflection = $reflection;
26			$this->invocationObject = $invocationObject;
27			} elseif ($reflection->isStatic()) {
28			$this->callableReflection = $reflection;
29			} else {
30			throw new \InvalidArgumentException(
31			'ReflectionMethod callables must specify an invocation object'
32			);
33			}
34			}
35
36			public function __invoke()
37			{
38			$args = func_get_args();
39			$reflection = $this->callableReflection;
40
41			if ($this->isInstanceMethod) {
42			return $reflection->invokeArgs($this->invocationObject, $args);
			0 ignored issues – show Bug introduced 2016-03-25 15:23 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `ReflectionFunctionAbstract` as the method `invokeArgs()` does only exist in the following sub-classes of `ReflectionFunctionAbstract`: `ReflectionFunction`, `ReflectionMethod`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
43			}
44
45			return $this->callableReflection->isClosure()
46			? $this->invokeClosureCompat($reflection, $args)
47			: $reflection->invokeArgs($args);
			0 ignored issues – show Bug introduced 2016-03-25 15:23 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `ReflectionFunctionAbstract` as the method `invokeArgs()` does only exist in the following sub-classes of `ReflectionFunctionAbstract`: `ReflectionFunction`, `ReflectionMethod`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
48			}
49
50			/**
51			* @TODO Remove this extra indirection when 5.3 support is dropped
52			* @param $reflection
53			* @param $args
54			*
55			* @return mixed
56			*/
57			private function invokeClosureCompat($reflection, $args)
58			{
59			if (version_compare(PHP_VERSION, '5.4.0') >= 0) {
60			$scope = $reflection->getClosureScopeClass();
61			$closure = \Closure::bind(
62			$reflection->getClosure(),
63			$reflection->getClosureThis(),
64			$scope ? $scope->name : null
65			);
66			return call_user_func_array($closure, $args);
67			} else {
68			return $reflection->invokeArgs($args);
69			}
70			}
71
72			public function getCallableReflection()
73			{
74			return $this->callableReflection;
75			}
76
77			public function getInvocationObject()
78			{
79			return $this->invocationObject;
80			}
81
82			public function isInstanceMethod()
83			{
84			return $this->isInstanceMethod;
85			}
86			}
87

cmpayments / atreyu

Executable::__construct() A last analyzed 2017-02-08 16:25 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

Executable::__construct() A
last analyzed 2017-02-08 16:25 UTC