Completed
Push — peter279k-master ( fcaf21 )
by Christian
13:01
created

OpenWeatherMapExceptionTest   A

Complexity

Total Complexity 15

Size/Duplication

Total Lines 145
Duplicated Lines 11.03 %

Coupling/Cohesion

Components 1
Dependencies 2

Importance

Changes 0
Metric Value
wmc 15
lcom 1
cbo 2
dl 16
loc 145
rs 10
c 0
b 0
f 0

15 Methods

Rating   Name   Duplication   Size   Complexity  
A setUp() 0 5 1
A testCacheException() 0 4 1
A testSecondNotNumericException() 0 4 1
A testGetWeatherForecastException() 0 5 1
A testGetDailyWeatherForecastException() 0 5 1
A testGetWeatherHistoryException() 0 4 1
A testGetWeatherHistoryWithEndException() 0 4 1
A testGetWeatherHistoryInvalidArgumentException() 0 4 1
A testGetRawDailyForecastDataInvalidArgumentException() 0 4 1
A testGetRawWeatherHistoryException() 0 4 1
A testGetRawWeatherHistoryWithEndDateException() 0 4 1
A testBuildQueryUrlParameterException() 0 4 1
A testParseXMLException() 8 8 1
A testParseXMLWithIsJsonException() 0 9 1
A testParseJsonException() 8 8 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
/**
3
 * Copyright Zikula Foundation 2014 - Zikula Application Framework
4
 *
5
 * This work is contributed to the Zikula Foundation under one or more
6
 * Contributor Agreements and licensed to You under the following license:
7
 *
8
 * @license GNU/LGPv3 (or at your option any later version).
9
 * @package OpenWeatherMap-PHP-Api
10
 *
11
 * Please see the NOTICE file distributed with this source code for further
12
 * information regarding copyright and licensing.
13
 */
14
15
namespace Cmfcmf\OpenWeatherMap\Tests\OpenWeatherMap;
16
17
use \Cmfcmf\OpenWeatherMap;
18
use Cmfcmf\OpenWeatherMap\Tests\TestFetcher;
19
20
class OpenWeatherMapExceptionTest extends \PHPUnit_Framework_TestCase
21
{
22
    /**
23
     * @var string
24
     */
25
    protected $apiKey;
26
27
    /**
28
     * @var OpenWeatherMap
29
     */
30
    protected $owm;
31
32
    protected function setUp()
33
    {
34
        $this->apiKey = 'unicorn-rainbow';
35
        $this->owm = new OpenWeatherMap($this->apiKey, new TestFetcher(), false, 600);
36
    }
37
38
    /**
39
     * @expectedException \InvalidArgumentException
40
     */
41
    public function testCacheException()
42
    {
43
        new OpenWeatherMap($this->apiKey, null, true, 600);
44
    }
45
46
    /**
47
     * @expectedException \InvalidArgumentException
48
     */
49
    public function testSecondNotNumericException()
50
    {
51
        new OpenWeatherMap($this->apiKey, null, false, 'I am not numeric');
52
    }
53
54
    /**
55
     * @expectedException \InvalidArgumentException
56
     */
57
    public function testGetWeatherForecastException()
58
    {
59
        $days = 20;
60
        $this->owm->getWeatherForecast('Berlin', 'imperial', 'en', '', $days);
61
    }
62
63
    /**
64
     * @expectedException \InvalidArgumentException
65
     */
66
    public function testGetDailyWeatherForecastException()
67
    {
68
        $days = 20;
69
        $this->owm->getDailyWeatherForecast('Berlin', 'imperial', 'en', '', $days);
70
    }
71
72
    /**
73
     * @expectedException \Cmfcmf\OpenWeatherMap\Exception
74
     */
75
    public function testGetWeatherHistoryException()
76
    {
77
        $this->owm->getWeatherHistory('Berlin', new \DateTime('2015-11-01 00:00:00'), 1, 'hour', 'imperial', 'en', '');
78
    }
79
80
    /**
81
     * @expectedException \Cmfcmf\OpenWeatherMap\Exception
82
     */
83
    public function testGetWeatherHistoryWithEndException()
84
    {
85
        $this->owm->getWeatherHistory('Berlin', new \DateTime('2015-11-01 00:00:00'), new \DateTime('now'), 'hour', 'imperial', 'en', '');
0 ignored issues
show
Documentation introduced by
new \DateTime('now') is of type object<DateTime>, but the function expects a integer.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
86
    }
87
88
     /**
89
      * @expectedException \InvalidArgumentException
90
      */
91
    public function testGetWeatherHistoryInvalidArgumentException()
92
    {
93
        $this->owm->getWeatherHistory('Berlin', new \DateTime('now'), 1, 'wrong-type', 'imperial', 'en', '');
94
    }
95
96
    /**
97
     * @expectedException \InvalidArgumentException
98
     */
99
    public function testGetRawDailyForecastDataInvalidArgumentException()
100
    {
101
        $this->owm->getRawDailyForecastData('Berlin', 'imperial', 'en', '', 'xml', 20);
102
    }
103
104
    /**
105
     * @expectedException \InvalidArgumentException
106
     */
107
    public function testGetRawWeatherHistoryException()
108
    {
109
        $this->owm->getRawWeatherHistory('Berlin', new \DateTime('now'), 1, 'wrong-type', 'imperial', 'en', '');
110
    }
111
112
    /**
113
     * @expectedException \InvalidArgumentException
114
     */
115
    public function testGetRawWeatherHistoryWithEndDateException()
116
    {
117
        $this->owm->getRawWeatherHistory('Berlin', new \DateTime('now'), 'wrong-endOrCount', 'hour', 'imperial', 'en', '');
118
    }
119
     
120
    /**
121
     * @expectedException \InvalidArgumentException
122
     */
123
    public function testBuildQueryUrlParameterException()
124
    {
125
        $this->owm->getWeather(true, 'imperial', 'en', '');
0 ignored issues
show
Documentation introduced by
true is of type boolean, but the function expects a array|integer|string.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
126
    }
127
128
    /**
129
     * @expectedException \Cmfcmf\OpenWeatherMap\Exception
130
     */
131 View Code Duplication
    public function testParseXMLException()
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
132
    {
133
        $answer = 'I am not XML formatted data';
134
        $method = new \ReflectionMethod($this->owm, 'parseXML');
135
        $method->setAccessible(true);
136
        
137
        $method->invoke($this->owm, $answer);
138
    }
139
140
    /**
141
     * @expectedException \Cmfcmf\OpenWeatherMap\Exception
142
     */
143
    public function testParseXMLWithIsJsonException()
144
    {
145
        $answer = array('message' => 'simple json data');
146
        $answer = json_encode($answer);
147
        $method = new \ReflectionMethod($this->owm, 'parseXML');
148
        $method->setAccessible(true);
149
150
        $method->invoke($this->owm, $answer);
151
    }
152
153
    /**
154
     * @expectedException \Cmfcmf\OpenWeatherMap\Exception
155
     */
156 View Code Duplication
    public function testParseJsonException()
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
157
    {
158
        $answer = 'I am not a json format data';
159
        $method = new \ReflectionMethod($this->owm, 'parseJson');
160
        $method->setAccessible(true);
161
        
162
        $method->invoke($this->owm, $answer);
163
    }
164
}
165