Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
20 | class OpenWeatherMapExceptionTest extends \PHPUnit_Framework_TestCase |
||
21 | { |
||
22 | /** |
||
23 | * @var string |
||
24 | */ |
||
25 | protected $apiKey; |
||
26 | |||
27 | /** |
||
28 | * @var OpenWeatherMap |
||
29 | */ |
||
30 | protected $owm; |
||
31 | |||
32 | protected function setUp() |
||
37 | |||
38 | /** |
||
39 | * @expectedException \InvalidArgumentException |
||
40 | */ |
||
41 | public function testCacheException() |
||
45 | |||
46 | /** |
||
47 | * @expectedException \InvalidArgumentException |
||
48 | */ |
||
49 | public function testSecondNotNumericException() |
||
53 | |||
54 | /** |
||
55 | * @expectedException \InvalidArgumentException |
||
56 | */ |
||
57 | public function testGetWeatherForecastException() |
||
62 | |||
63 | /** |
||
64 | * @expectedException \InvalidArgumentException |
||
65 | */ |
||
66 | public function testGetDailyWeatherForecastException() |
||
71 | |||
72 | /** |
||
73 | * @expectedException \Cmfcmf\OpenWeatherMap\Exception |
||
74 | */ |
||
75 | public function testGetWeatherHistoryException() |
||
79 | |||
80 | /** |
||
81 | * @expectedException \Cmfcmf\OpenWeatherMap\Exception |
||
82 | */ |
||
83 | public function testGetWeatherHistoryWithEndException() |
||
87 | |||
88 | /** |
||
89 | * @expectedException \InvalidArgumentException |
||
90 | */ |
||
91 | public function testGetWeatherHistoryInvalidArgumentException() |
||
95 | |||
96 | /** |
||
97 | * @expectedException \InvalidArgumentException |
||
98 | */ |
||
99 | public function testGetRawDailyForecastDataInvalidArgumentException() |
||
103 | |||
104 | /** |
||
105 | * @expectedException \InvalidArgumentException |
||
106 | */ |
||
107 | public function testGetRawWeatherHistoryException() |
||
111 | |||
112 | /** |
||
113 | * @expectedException \InvalidArgumentException |
||
114 | */ |
||
115 | public function testGetRawWeatherHistoryWithEndDateException() |
||
119 | |||
120 | /** |
||
121 | * @expectedException \InvalidArgumentException |
||
122 | */ |
||
123 | public function testBuildQueryUrlParameterException() |
||
127 | |||
128 | /** |
||
129 | * @expectedException \Cmfcmf\OpenWeatherMap\Exception |
||
130 | */ |
||
131 | View Code Duplication | public function testParseXMLException() |
|
139 | |||
140 | /** |
||
141 | * @expectedException \Cmfcmf\OpenWeatherMap\Exception |
||
142 | */ |
||
143 | public function testParseXMLWithIsJsonException() |
||
152 | |||
153 | /** |
||
154 | * @expectedException \Cmfcmf\OpenWeatherMap\Exception |
||
155 | */ |
||
156 | View Code Duplication | public function testParseJsonException() |
|
164 | } |
||
165 |
It seems like the type of the argument is not accepted by the function/method which you are calling.
In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.
We suggest to add an explicit type cast like in the following example: