OpenWeatherMapExceptionTest - Code Metrics - Inspection of "Complete the unit testing and add some features" - cmfcmf/OpenWeatherMap-PHP-API - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#93)

by lee

created 2017-01-02 12:49 UTC

OpenWeatherMapExceptionTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	227
Duplicated Lines	55.07 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
wmc	29
lcom	1
cbo	0
dl	125
loc	227
rs	10
c	0
b	0
f	0

15 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	7	7	1
A	testCacheException()	8	8	2
A	testSecondNotNumbericException()	8	8	2
A	testGetWeatherForecastException()	11	11	2
A	testGetDailyWeatherForecastException()	11	11	2
A	testGetWeatherHistoryException()	0	10	2
A	testGetWeatherHistoryWithEndException()	0	10	2
A	testGetWeatherHistoryInvalidArgumentException()	10	10	2
A	testGetRawDailyForecastDataInvalidArgumentException()	10	10	2
A	testGetRawWeatherHistoryException()	10	10	2
A	testGetRawWeatherHistoryWithEndDateException()	10	10	2
A	testBuildQueryUrlParameterException()	10	10	2
A	testParseXMLException()	15	15	2
A	testParseXMLWithIsJsonException()	0	16	2
A	testParseJsonException()	15	15	2

How to fix Duplicated Code

<?php
/**
 * Copyright Zikula Foundation 2014 - Zikula Application Framework
 *
 * This work is contributed to the Zikula Foundation under one or more
 * Contributor Agreements and licensed to You under the following license:
 *
 * @license GNU/LGPv3 (or at your option any later version).
 * @package OpenWeatherMap-PHP-Api
 *
 * Please see the NOTICE file distributed with this source code for further
 * information regarding copyright and licensing.
 */

namespace Cmfcmf\OpenWeatherMap\Tests\OpenWeatherMap;

use \Cmfcmf\OpenWeatherMap;

class OpenWeatherMapExceptionTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @var apiKey
     * @var weather
     */
    protected $apiKey;
    protected $weather;

    protected function setUp()

    {
        $ini = parse_ini_file(__DIR__ . '/../ApiKey.ini');
        $apiKey = $ini['api_key'];
        $this->apiKey = $apiKey;
        $this->weather = new OpenWeatherMap($this->apiKey, null, false, 600);
    }

    /**
     * @expectedException Exception
     */
    public function testCacheException()

    {
        try {
            $exception = new OpenWeatherMap($this->apiKey, null, true, 600);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } catch (\Eception $e) {

            throw $e;
        }
    }

    /**
     * @expectedException Exception
     */
    public function testSecondNotNumbericException()

    {
        try {
            $exception = new OpenWeatherMap($this->apiKey, null, false, 'I am not numberic');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } catch (\Exception $e) {
            throw $e;
        }
    }

    /**
     * @expectedException InvalidArgumentException
     */
    public function testGetWeatherForecastException()

    {
        $days = 20;
        $weather = $this->weather;

        try {
            $argException = $weather->getWeatherForecast('Berlin', 'imperial', 'en', '', $days);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } catch (\InvalidArgumentException $e) {
            throw $e;
        }
    }

    /**
     * @expectedException InvalidArgumentException
     */
    public function testGetDailyWeatherForecastException()

    {
        $days = 20;
        $weather = $this->weather;

        try {
            $argException = $weather->getDailyWeatherForecast('Berlin', 'imperial', 'en', '', $days);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } catch (\InvalidArgumentException $e) {
            throw $e;
        }
    }

    /**
     * @expectedException \Cmfcmf\OpenWeatherMap\Exception
     */
    public function testGetWeatherHistoryException()
    {
        $weather = $this->weather;

        try {
            $oWMException = $weather->getWeatherHistory('Berlin', new \DateTime('2015-11-01 00:00:00'), 1, 'hour', 'imperial', 'en', '');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } catch (\Exception $e) {
            throw $e;
        }
    }

    /**
     * @expectedException \Cmfcmf\OpenWeatherMap\Exception
     */
    public function testGetWeatherHistoryWithEndException()
    {
        $weather = $this->weather;

        try {
            $oWMException = $weather->getWeatherHistory('Berlin', new \DateTime('2015-11-01 00:00:00'), new \DateTime('NOW'), 'hour', 'imperial', 'en', '');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        } catch (\Exception $e) {
            throw $e;
        }
    }

     /**
      * @expectedException InvalidArgumentException
      */
    public function testGetWeatherHistoryInvalidArgumentException()

    {
        $weather = $this->weather;

        try {
            $argException = $weather->getWeatherHistory('Berlin', new \DateTime('NOW'), 1, 'wrong-type', 'imperial', 'en', '');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } catch (\InvalidArgumentException $e) {
            throw $e;
        }
    }

    /**
     * @expectedException InvalidArgumentException
     */
    public function testGetRawDailyForecastDataInvalidArgumentException()

    {
        $weather = $this->weather;
        
        try {
            $argException = $weather->getRawDailyForecastData('Berlin', 'imperial', 'en', '', 'xml', 20);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } catch (\InvalidArgumentException $e) {
            throw $e;
        }
    }

    /**
     * @expectedException InvalidArgumentException
     */
    public function testGetRawWeatherHistoryException()

    {
        $weather = $this->weather;
        
        try {
            $argException = $weather->getRawWeatherHistory('Berlin', new \DateTime('NOW'), 1, 'wrong-type', 'imperial', 'en', '');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } catch (\InvalidArgumentException $e) {
            throw $e;
        }
    }

    /**
     * @expectedException InvalidArgumentException
     */
    public function testGetRawWeatherHistoryWithEndDateException()

    {
        $weather = $this->weather;
        
        try {
            $argException = $weather->getRawWeatherHistory('Berlin', new \DateTime('NOW'), 'wrong-endOrCount', 'hour', 'imperial', 'en', '');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } catch (\InvalidArgumentException $e) {
            throw $e;
        }
    }
     
    /**
     * @expectedException InvalidArgumentException
     */
    public function testBuildQueryUrlParameterException()

    {
        $weather = $this->weather;
        
        try {
            $argException = $weather->getWeather(true, new \DateTime('NOW'), 'wrong-endOrCount', 'hour', 'imperial', 'en', '');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        } catch (\InvalidArgumentException $e) {
            throw $e;
        }
    }

    /**
     * @expectedException Exception
     */
    public function testParseXMLException()

    {
        $answer = 'I am not a XML fromat data';
        $weather = $this->weather;
        $method = new \ReflectionMethod(
            $weather, 'parseXML'
        );
        $method->setAccessible(true);
        
        try {
            $method->invoke($weather, $answer);
        } catch (\Exception $e) {
            throw $e;
        }
    }

    /**
     * @expectedException Exception
     */
    public function testParseXMLWithIsJsonException()
    {
        $answer = array('message' => 'simple json data');
        $answer = json_encode($answer);
        $weather = $this->weather;
        $method = new \ReflectionMethod(
            $weather, 'parseXML'
        );
        $method->setAccessible(true);

        try {
            $method->invoke($weather, $answer);
        } catch (\Exception $e) {
            throw $e;
        }
    }

    /**
     * @expectedException \Cmfcmf\OpenWeatherMap\Exception
     */
    public function testParseJsonException()

    {
        $weather = $this->weather;
        $answer = 'I am not a json format data';
        $method = new \ReflectionMethod(
            $weather, 'parseJson'
        );
        $method->setAccessible(true);
        
        try {
            $method->invoke($weather, $answer);
        } catch (\Exception $e) {
            throw $e;
        }
    }
}


1		<?php
2		/**
3		* Copyright Zikula Foundation 2014 - Zikula Application Framework
4		*
5		* This work is contributed to the Zikula Foundation under one or more
6		* Contributor Agreements and licensed to You under the following license:
7		*
8		* @license GNU/LGPv3 (or at your option any later version).
9		* @package OpenWeatherMap-PHP-Api
10		*
11		* Please see the NOTICE file distributed with this source code for further
12		* information regarding copyright and licensing.
13		*/
14
15		namespace Cmfcmf\OpenWeatherMap\Tests\OpenWeatherMap;
16
17		use \Cmfcmf\OpenWeatherMap;
18
19		class OpenWeatherMapExceptionTest extends \PHPUnit_Framework_TestCase
20		{
21		/**
22		* @var apiKey
23		* @var weather
24		*/
25		protected $apiKey;
26		protected $weather;
27
28	View Code Duplication	protected function setUp()
		0 ignored issues – show Duplication introduced 2016-12-30 20:39 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
29		{
30		$ini = parse_ini_file(__DIR__ . '/../ApiKey.ini');
31		$apiKey = $ini['api_key'];
32		$this->apiKey = $apiKey;
33		$this->weather = new OpenWeatherMap($this->apiKey, null, false, 600);
34		}
35
36		/**
37		* @expectedException Exception
38		*/
39	View Code Duplication	public function testCacheException()

cmfcmf / OpenWeatherMap-PHP-API

Pull Request — master (#93)

OpenWeatherMapExceptionTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

15 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like