cmen / CMENGoogleChartsBundle

GoogleCharts/Charts/Diff/DiffPieChart.php

<?php

namespace CMEN\GoogleChartsBundle\GoogleCharts\Charts\Diff;

use CMEN\GoogleChartsBundle\GoogleCharts\Charts\PieChart;
use CMEN\GoogleChartsBundle\GoogleCharts\Options\ChartOptionsInterface;
use CMEN\GoogleChartsBundle\GoogleCharts\Options\Diff\DiffPieChart\DiffPieChartOptions;

/**
 * @author Christophe Meneses
 */
class DiffPieChart extends PieChart implements DiffChart
{
    /**
     * @var DiffPieChartOptions
     */
    protected ChartOptionsInterface $options;

    public function __construct(private readonly PieChart $oldChart, private readonly PieChart $newChart)
    {
        parent::__construct();

        $this->options = new DiffPieChartOptions();
    }

    public function getOptions(): DiffPieChartOptions
    {
        return $this->options;

The expression return $this->options returns the type CMEN\GoogleChartsBundle\GoogleCharts\Options\ChartOptionsInterface which includes types incompatible with the type-hinted return CMEN\GoogleChartsBundle\GoogleCharts\Options\Diff\DiffPieChart\DiffPieChartOptions.

    }

    /**
     * @param DiffPieChartOptions $options
     */
    public function setOptions(ChartOptionsInterface $options): DiffPieChart
    {
        $this->options = $options;

$options is of type CMEN\GoogleChartsBundle\GoogleCharts\Options\ChartOptionsInterface, but the property $options was declared to be of type CMEN\GoogleChartsBundle\GoogleCharts\Options\Diff\DiffPieChart\DiffPieChartOptions. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        return $this;
    }

    public function getOldChart(): PieChart
    {
        return $this->oldChart;
    }

    public function getNewChart(): PieChart
    {
        return $this->newChart;
    }
}