ComboChart::getType() - Code Metrics - Inspection of "Improve QA" - cmen/CMENGoogleChartsBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#38)

by Christophe

created 2019-12-06 15:35 UTC

ComboChart::getType() A

↳ Parent: ComboChart

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
ccs	0
cts	2
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php

namespace CMEN\GoogleChartsBundle\GoogleCharts\Charts;

use CMEN\GoogleChartsBundle\GoogleCharts\Chart;
use CMEN\GoogleChartsBundle\GoogleCharts\EventType;
use CMEN\GoogleChartsBundle\GoogleCharts\Options\ComboChart\ComboChartOptions;

/**
 * @author Christophe Meneses
 */
class ComboChart extends Chart
{
    /**
     * @var ComboChartOptions
     */
    protected $options;

    public function __construct()
    {
        parent::__construct();

        $this->options = new ComboChartOptions();
    }

    public function getType()
    {
        return 'ComboChart';
    }

    public function getPackage()
    {
        return 'corechart';
    }

    public function getAvailableEventTypes()
    {
        return [
            EventType::ANIMATION_FINISH,
            EventType::CLICK,
            EventType::ERROR,
            EventType::ON_MOUSE_OUT,
            EventType::ON_MOUSE_OVER,
            EventType::READY,
            EventType::SELECT,
        ];
    }

    /**
     * @return ComboChartOptions
     */
    public function getOptions()
    {
        return $this->options;
    }

    /**
     * @param ComboChartOptions $options
     *
     * @return ComboChart
     */
    public function setOptions($options)
    {
        $this->options = $options;

        return $this;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }
}


1		<?php
2
3		namespace CMEN\GoogleChartsBundle\GoogleCharts\Charts;
4
5		use CMEN\GoogleChartsBundle\GoogleCharts\Chart;
6		use CMEN\GoogleChartsBundle\GoogleCharts\EventType;
7		use CMEN\GoogleChartsBundle\GoogleCharts\Options\ComboChart\ComboChartOptions;
8
9		/**
10		* @author Christophe Meneses
11		*/
12		class ComboChart extends Chart
13		{
14		/**
15		* @var ComboChartOptions
16		*/
17		protected $options;
18
19	1	public function __construct()
20		{
21	1	parent::__construct();
22
23	1	$this->options = new ComboChartOptions();
24	1	}
25
26		public function getType()
27		{
28		return 'ComboChart';
29		}
30
31		public function getPackage()
32		{
33		return 'corechart';
34		}
35
36	1	public function getAvailableEventTypes()
37		{
38		return [
39	1	EventType::ANIMATION_FINISH,
40		EventType::CLICK,
41		EventType::ERROR,
42		EventType::ON_MOUSE_OUT,
43		EventType::ON_MOUSE_OVER,
44		EventType::READY,
45		EventType::SELECT,
46		];
47		}
48
49		/**
50		* @return ComboChartOptions
51		*/
52		public function getOptions()
53		{
54		return $this->options;
55		}
56
57		/**
58		* @param ComboChartOptions $options
59		*
60		* @return ComboChart
61		*/
62		public function setOptions($options)
63		{
64		$this->options = $options;
65
66		return $this;
		0 ignored issues – show Bug Best Practice introduced 2019-12-06 15:40 UTC by Report Bug Copy Issue Report The expression `return $this` returns the type `CMEN\GoogleChartsBundle\...harts\Charts\ComboChart` which is incompatible with the return type mandated by `CMEN\GoogleChartsBundle\...rts\Chart::setOptions()` of `CMEN\GoogleChartsBundle\...s\ChartOptionsInterface`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
67		}
68		}
69

cmen / CMENGoogleChartsBundle

Pull Request — master (#38)

ComboChart::getType() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like