AreaChart - Code Metrics - Inspection of "Allow all available events" - cmen/CMENGoogleChartsBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#26)

by Christophe

created 2019-03-02 09:51 UTC

AreaChart A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	73
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	6
lcom	0
cbo	2
dl	0
loc	73
ccs	0
cts	34
cp	0
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Size	Complexity
A	__construct()	6	1
A	getType()	4	1
A	getPackage()	4	1
A	getAvailableEventTypes()	12	1
A	getOptions()	4	1
A	setOptions()	6	1

<?php

namespace CMEN\GoogleChartsBundle\GoogleCharts\Charts;

use CMEN\GoogleChartsBundle\GoogleCharts\Chart;
use CMEN\GoogleChartsBundle\GoogleCharts\EventType;
use CMEN\GoogleChartsBundle\GoogleCharts\Options\AreaChart\AreaChartOptions;

/**
 * @author Christophe Meneses
 */
class AreaChart extends Chart
{
    /**
     * @var AreaChartOptions
     */
    protected $options;

    /**
     * AreaChart constructor.
     */
    public function __construct()
    {
        parent::__construct();

        $this->options = new AreaChartOptions();
    }

    /**
     * Returns the chart type.
     *
     * @return string
     */
    public function getType()
    {
        return 'AreaChart';
    }

    /**
     * Returns the chart package.
     *
     * @return string
     */
    public function getPackage()
    {
        return 'corechart';
    }

    /**
     * {@inheritdoc}
     */
    public function getAvailableEventTypes()
    {
        return [
            EventType::ANIMATION_FINISH,
            EventType::CLICK,
            EventType::ERROR,
            EventType::ON_MOUSE_OUT,
            EventType::ON_MOUSE_OVER,
            EventType::READY,
            EventType::SELECT,
        ];
    }

    /**
     * @return AreaChartOptions
     */
    public function getOptions()
    {
        return $this->options;
    }

    /**
     * @param $options AreaChartOptions
     *
     * @return AreaChart
     */
    public function setOptions($options)
    {
        $this->options = $options;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}

        return $this;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
}


1			<?php
2
3			namespace CMEN\GoogleChartsBundle\GoogleCharts\Charts;
4
5			use CMEN\GoogleChartsBundle\GoogleCharts\Chart;
6			use CMEN\GoogleChartsBundle\GoogleCharts\EventType;
7			use CMEN\GoogleChartsBundle\GoogleCharts\Options\AreaChart\AreaChartOptions;
8
9			/**
10			* @author Christophe Meneses
11			*/
12			class AreaChart extends Chart
13			{
14			/**
15			* @var AreaChartOptions
16			*/
17			protected $options;
18
19			/**
20			* AreaChart constructor.
21			*/
22			public function __construct()
23			{
24			parent::__construct();
25
26			$this->options = new AreaChartOptions();
27			}
28
29			/**
30			* Returns the chart type.
31			*
32			* @return string
33			*/
34			public function getType()
35			{
36			return 'AreaChart';
37			}
38
39			/**
40			* Returns the chart package.
41			*
42			* @return string
43			*/
44			public function getPackage()
45			{
46			return 'corechart';
47			}
48
49			/**
50			* {@inheritdoc}
51			*/
52			public function getAvailableEventTypes()
53			{
54			return [
55			EventType::ANIMATION_FINISH,
56			EventType::CLICK,
57			EventType::ERROR,
58			EventType::ON_MOUSE_OUT,
59			EventType::ON_MOUSE_OVER,
60			EventType::READY,
61			EventType::SELECT,
62			];
63			}
64
65			/**
66			* @return AreaChartOptions
67			*/
68			public function getOptions()
69			{
70			return $this->options;
71			}
72
73			/**
74			* @param $options AreaChartOptions
75			*
76			* @return AreaChart
77			*/
78			public function setOptions($options)
79			{
80			$this->options = $options;
			0 ignored issues – show Documentation Bug introduced 2017-12-16 17:28 UTC by Report Bug Copy Issue Report `$options` is of type `object<CMEN\GoogleCharts...\ChartOptionsInterface>`, but the property `$options` was declared to be of type `object<CMEN\GoogleCharts...Chart\AreaChartOptions>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
81
82			return $this;
			0 ignored issues – show Bug Best Practice introduced 2017-12-16 17:28 UTC by Report Bug Copy Issue Report The return type of `return $this;` (`CMEN\GoogleChartsBundle\...Charts\Charts\AreaChart`) is incompatible with the return type declared by the abstract method `CMEN\GoogleChartsBundle\...harts\Chart::setOptions` of type `CMEN\GoogleChartsBundle\...s\ChartOptionsInterface`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
83			}
84			}
85

cmen / CMENGoogleChartsBundle

Pull Request — master (#26)

AreaChart A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

6 Methods

Duplication Side-by-Side

Filter issues like