CMEN\GoogleChartsBundle\GoogleCharts\Charts\ComboChart

Complexity

Total Complexity

6

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Test Coverage

Coverage

35.7%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getType()	0	3	1
A	setOptions()	0	5	1
A	getAvailableEventTypes()	0	10	1
A	getPackage()	0	3	1
A	getOptions()	0	3	1

<?php

namespace CMEN\GoogleChartsBundle\GoogleCharts\Charts;

use CMEN\GoogleChartsBundle\GoogleCharts\Chart;
use CMEN\GoogleChartsBundle\GoogleCharts\EventType;
use CMEN\GoogleChartsBundle\GoogleCharts\Options\ChartOptionsInterface;
use CMEN\GoogleChartsBundle\GoogleCharts\Options\ComboChart\ComboChartOptions;

/**
 * @author Christophe Meneses
 */
class ComboChart extends Chart
{
    /**
     * @var ComboChartOptions
     */
    protected ChartOptionsInterface $options;

    public function __construct()
    {
        parent::__construct();

        $this->options = new ComboChartOptions();
    }

    public function getType(): string
    {
        return 'ComboChart';
    }

    public function getPackage(): string
    {
        return 'corechart';
    }

    public function getAvailableEventTypes(): array
    {
        return [
            EventType::ANIMATION_FINISH,
            EventType::CLICK,
            EventType::ERROR,
            EventType::ON_MOUSE_OUT,
            EventType::ON_MOUSE_OVER,
            EventType::READY,
            EventType::SELECT,
        ];
    }

    public function getOptions(): ComboChartOptions
    {
        return $this->options;

The expression return $this->options returns the type CMEN\GoogleChartsBundle\GoogleCharts\Options\ChartOptionsInterface which includes types incompatible with the type-hinted return CMEN\GoogleChartsBundle\GoogleCharts\Options\ComboChart\ComboChartOptions.

    }

    /**
     * @param ComboChartOptions $options
     */
    public function setOptions(ChartOptionsInterface $options): ComboChart
    {
        $this->options = $options;

$options is of type CMEN\GoogleChartsBundle\GoogleCharts\Options\ChartOptionsInterface, but the property $options was declared to be of type CMEN\GoogleChartsBundle\GoogleCharts\Options\ComboChart\ComboChartOptions. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        return $this;
    }
}