CMEN\GoogleChartsBundle\GoogleCharts\Charts\Diff\DiffScatterChart

Complexity

Total Complexity

5

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getOldChart()	0	3	1
A	__construct()	0	5	1
A	getOptions()	0	3	1
A	getNewChart()	0	3	1
A	setOptions()	0	5	1

<?php

namespace CMEN\GoogleChartsBundle\GoogleCharts\Charts\Diff;

use CMEN\GoogleChartsBundle\GoogleCharts\Charts\ScatterChart;
use CMEN\GoogleChartsBundle\GoogleCharts\Options\ChartOptionsInterface;
use CMEN\GoogleChartsBundle\GoogleCharts\Options\Diff\DiffScatterChart\DiffScatterChartOptions;

/**
 * @author Christophe Meneses
 */
class DiffScatterChart extends ScatterChart implements DiffChart
{
    /**
     * @var DiffScatterChartOptions
     */
    protected ChartOptionsInterface $options;

    public function __construct(private readonly ScatterChart $oldChart, private readonly ScatterChart $newChart)
    {
        parent::__construct();

        $this->options = new DiffScatterChartOptions();
    }

    public function getOptions(): DiffScatterChartOptions
    {
        return $this->options;

The expression return $this->options returns the type CMEN\GoogleChartsBundle\GoogleCharts\Options\ChartOptionsInterface which includes types incompatible with the type-hinted return CMEN\GoogleChartsBundle\GoogleCharts\Options\Diff\DiffScatterChart\DiffScatterChartOptions.

    }

    /**
     * @param DiffScatterChartOptions $options
     */
    public function setOptions(ChartOptionsInterface $options): DiffScatterChart
    {
        $this->options = $options;

$options is of type CMEN\GoogleChartsBundle\GoogleCharts\Options\ChartOptionsInterface, but the property $options was declared to be of type CMEN\GoogleChartsBundle\GoogleCharts\Options\Diff\DiffScatterChart\DiffScatterChartOptions. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        return $this;
    }

    public function getOldChart(): ScatterChart
    {
        return $this->oldChart;
    }

    public function getNewChart(): ScatterChart
    {
        return $this->newChart;
    }
}