Completed
Push — master ( 095da7...67ecf2 )
by Daryl
02:04
created
includes/class-map-view.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
         $markers      = $this->_make_markers_args();
19 19
         $info_windows = $this->_make_info_windows();
20 20
 
21
-        require dirname( __DIR__) . '/templates/map-view.php';
21
+        require dirname( __DIR__ ).'/templates/map-view.php';
22 22
 
23 23
     }
24 24
 
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
         /**
47 47
          * @var Marker $marker
48 48
          */
49
-        foreach( $this->item->markers() as $marker ) {
49
+        foreach ( $this->item->markers() as $marker ) {
50 50
             $info_window = $marker->info_window();
51 51
             $windows[]   = array(
52 52
                 'content'      => $info_window->content(),
Please login to merge, or discard this patch.
includes/class-geocoder.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -118,7 +118,7 @@
 block discarded – undo
118 118
     }
119 119
 
120 120
     /**
121
-     * @param $url
121
+     * @param string $url
122 122
      * @return array|\WP_Error
123 123
      */
124 124
     private function _get_data( $url ) {
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -43,12 +43,12 @@  discard block
 block discarded – undo
43 43
      */
44 44
     function geocode( $address ) {
45 45
 
46
-        $location = new \WP_Error(100, 'No results found', array( 'address' => $address ) );
46
+        $location = new \WP_Error( 100, 'No results found', array( 'address' => $address ) );
47 47
         $url = $this->_make_url( $address );
48 48
 
49 49
         $response = $this->_make_request( $url );
50 50
 
51
-        if ( ! is_wp_error( $response ) && count( $response['results'] ) > 0 ) {
51
+        if ( !is_wp_error( $response ) && count( $response['results'] ) > 0 ) {
52 52
             $location = $this->_make_location( $response['results'][0] );
53 53
         }
54 54
 
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
 
124 124
         $result_value = '';
125 125
 
126
-        if ( isset( $results['address_components'] ) ) {
126
+        if ( isset($results['address_components']) ) {
127 127
             foreach ( $results['address_components'] as $component ) {
128 128
                 if ( $component['types'][0] === $value ) {
129 129
                     $result_value = $component['short_name'];
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
 
168 168
         $cache_key = md5( serialize( $url ) );
169 169
 
170
-        if ( ! $data = wp_cache_get( $cache_key ) ) {
170
+        if ( !$data = wp_cache_get( $cache_key ) ) {
171 171
             $data = wp_remote_get( $url );
172 172
             wp_cache_add( $cache_key, $data, 300 );
173 173
         }
Please login to merge, or discard this patch.
tests/bootstrap.php 1 patch
Spacing   +27 added lines, -27 removed lines patch added patch discarded remove patch
@@ -1,41 +1,41 @@
 block discarded – undo
1 1
 <?php
2
-define('VENDOR_DIRECTORY', dirname(__DIR__) . '/vendor');
3
-define('TEST_INCLUDES_DIR', dirname(__FILE__) . '/includes');
2
+define( 'VENDOR_DIRECTORY', dirname( __DIR__ ).'/vendor' );
3
+define( 'TEST_INCLUDES_DIR', dirname( __FILE__ ).'/includes' );
4 4
 
5
-if (! file_exists( dirname(__DIR__) . '/build' ) ) {
6
-    mkdir(dirname(__DIR__) . '/build');
5
+if ( !file_exists( dirname( __DIR__ ).'/build' ) ) {
6
+    mkdir( dirname( __DIR__ ).'/build' );
7 7
 }
8 8
 
9
-require_once getenv( 'WP_TESTS_DIR' ) . '/tests/phpunit/includes/functions.php';
10
-require getenv( 'WP_TESTS_DIR' ) . '/tests/phpunit/includes/bootstrap.php';
9
+require_once getenv( 'WP_TESTS_DIR' ).'/tests/phpunit/includes/functions.php';
10
+require getenv( 'WP_TESTS_DIR' ).'/tests/phpunit/includes/bootstrap.php';
11 11
 
12 12
 require 'includes/testCase.php';
13 13
 
14
-require VENDOR_DIRECTORY . '/autoload.php';
14
+require VENDOR_DIRECTORY.'/autoload.php';
15 15
 
16
-if ( ! function_exists( 'wplib_define' ) ) {
17
-    require( VENDOR_DIRECTORY . '/wplib/wplib/defines.php' );
16
+if ( !function_exists( 'wplib_define' ) ) {
17
+    require(VENDOR_DIRECTORY.'/wplib/wplib/defines.php');
18 18
     wplib_define( 'WPLib_Runmode', 'PRODUCTION' );
19 19
     wplib_define( 'WPLib_Stability', 'EXPERIMENTAL' );
20 20
 }
21 21
 
22
-require VENDOR_DIRECTORY . '/wplib/wplib/wplib.php';
22
+require VENDOR_DIRECTORY.'/wplib/wplib/wplib.php';
23 23
 WPLib::initialize();
24 24
 
25
-require_once dirname(__DIR__) . '/includes/class-geocoder.php';
26
-require_once dirname(__DIR__) . '/includes/class-info-window-model.php';
27
-require_once dirname(__DIR__) . '/includes/class-info-window-view.php';
28
-require_once dirname(__DIR__) . '/includes/class-info-window.php';
29
-require_once dirname(__DIR__) . '/includes/class-location.php';
30
-require_once dirname(__DIR__) . '/includes/class-location-model.php';
31
-require_once dirname(__DIR__) . '/includes/class-location-view.php';
32
-require_once dirname(__DIR__) . '/includes/class-map.php';
33
-require_once dirname(__DIR__) . '/includes/class-map-model.php';
34
-require_once dirname(__DIR__) . '/includes/class-map-view.php';
35
-require_once dirname(__DIR__) . '/includes/class-marker.php';
36
-require_once dirname(__DIR__) . '/includes/class-marker-label.php';
37
-require_once dirname(__DIR__) . '/includes/class-marker-label-model.php';
38
-require_once dirname(__DIR__) . '/includes/class-marker-label-view.php';
39
-require_once dirname(__DIR__) . '/includes/class-marker-model.php';
40
-require_once dirname(__DIR__) . '/includes/class-marker-view.php';
41
-require_once dirname(__DIR__) . '/component-google-maps.php';
25
+require_once dirname( __DIR__ ).'/includes/class-geocoder.php';
26
+require_once dirname( __DIR__ ).'/includes/class-info-window-model.php';
27
+require_once dirname( __DIR__ ).'/includes/class-info-window-view.php';
28
+require_once dirname( __DIR__ ).'/includes/class-info-window.php';
29
+require_once dirname( __DIR__ ).'/includes/class-location.php';
30
+require_once dirname( __DIR__ ).'/includes/class-location-model.php';
31
+require_once dirname( __DIR__ ).'/includes/class-location-view.php';
32
+require_once dirname( __DIR__ ).'/includes/class-map.php';
33
+require_once dirname( __DIR__ ).'/includes/class-map-model.php';
34
+require_once dirname( __DIR__ ).'/includes/class-map-view.php';
35
+require_once dirname( __DIR__ ).'/includes/class-marker.php';
36
+require_once dirname( __DIR__ ).'/includes/class-marker-label.php';
37
+require_once dirname( __DIR__ ).'/includes/class-marker-label-model.php';
38
+require_once dirname( __DIR__ ).'/includes/class-marker-label-view.php';
39
+require_once dirname( __DIR__ ).'/includes/class-marker-model.php';
40
+require_once dirname( __DIR__ ).'/includes/class-marker-view.php';
41
+require_once dirname( __DIR__ ).'/component-google-maps.php';
Please login to merge, or discard this patch.
includes/class-marker-model.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -94,8 +94,8 @@  discard block
 block discarded – undo
94 94
      */
95 95
     function latitude() {
96 96
 
97
-        if ( is_null( $this->_latitude ) && ! is_wp_error( $this->location() ) ) {
98
-            $this->_latitude =$this->location()->latitude();
97
+        if ( is_null( $this->_latitude ) && !is_wp_error( $this->location() ) ) {
98
+            $this->_latitude = $this->location()->latitude();
99 99
         }
100 100
         return doubleval( $this->_latitude );
101 101
     }
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
      * @return Location|\WP_Error
105 105
      */
106 106
     function location() {
107
-        if ( ! is_object( $this->_location ) ) {
107
+        if ( !is_object( $this->_location ) ) {
108 108
             $this->_location = $this->_geocoder()->geocode( $this->_address );
109 109
         }
110 110
         return $this->_location;
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
      */
116 116
     function longitude() {
117 117
 
118
-        if ( is_null( $this->_longitude ) && ! is_wp_error( $this->location() ) ) {
118
+        if ( is_null( $this->_longitude ) && !is_wp_error( $this->location() ) ) {
119 119
             $this->_longitude = doubleval( $this->location()->longitude() );
120 120
         }
121 121
         return doubleval( $this->_longitude );
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
161 161
      * @return Geocoder
162 162
      */
163 163
     private function _geocoder() {
164
-        if (! is_object( $this->_geocoder ) ) {
164
+        if ( !is_object( $this->_geocoder ) ) {
165 165
             $this->_geocoder = new Geocoder();
166 166
         }
167 167
 
Please login to merge, or discard this patch.
tests/integration/testGeocoder.php 1 patch
Spacing   +31 added lines, -31 removed lines patch added patch discarded remove patch
@@ -20,38 +20,38 @@  discard block
 block discarded – undo
20 20
     private $_geocoder;
21 21
 
22 22
     public function setUp() {
23
-        $this->_geocoder = new Geocoder(['api_key' => '']);
23
+        $this->_geocoder = new Geocoder( ['api_key' => ''] );
24 24
     }
25 25
 
26 26
     /**
27 27
      * @covers ::_make_request
28 28
      */
29 29
     public function testMakeRequest() {
30
-        $url      = $this->reflectionMethodInvokeArgs($this->_geocoder, '_make_url', '1600 Amphitheatre Parkway, Mountain View, CA');
31
-        $response = $this->reflectionMethodInvokeArgs($this->_geocoder, '_make_request', $url);
30
+        $url      = $this->reflectionMethodInvokeArgs( $this->_geocoder, '_make_url', '1600 Amphitheatre Parkway, Mountain View, CA' );
31
+        $response = $this->reflectionMethodInvokeArgs( $this->_geocoder, '_make_request', $url );
32 32
 
33
-        $this->assertInternalType('array', $response);
33
+        $this->assertInternalType( 'array', $response );
34 34
     }
35 35
 
36 36
     /**
37 37
      * @covers ::_make_request
38 38
      */
39 39
     public function testMakeRequestError404() {
40
-        $response = $this->reflectionMethodInvokeArgs($this->_geocoder, '_make_request', 'https://maps.googleapis.com/maps/api/geo');
40
+        $response = $this->reflectionMethodInvokeArgs( $this->_geocoder, '_make_request', 'https://maps.googleapis.com/maps/api/geo' );
41 41
 
42
-        $this->assertInstanceOf('WP_Error', $response);
43
-        $this->assertObjectHasAttribute('errors', $response);
44
-        $this->assertArrayHasKey('404', $response->errors);
42
+        $this->assertInstanceOf( 'WP_Error', $response );
43
+        $this->assertObjectHasAttribute( 'errors', $response );
44
+        $this->assertArrayHasKey( '404', $response->errors );
45 45
     }
46 46
 
47 47
     /**
48 48
      * @covers ::_get_data
49 49
      */
50 50
     public function testGetData() {
51
-        $url      = $this->reflectionMethodInvokeArgs($this->_geocoder, '_make_url', '1600 Amphitheatre Parkway, Mountain View, CA');
52
-        $response = $this->reflectionMethodInvokeArgs($this->_geocoder, '_get_data', $url);
51
+        $url      = $this->reflectionMethodInvokeArgs( $this->_geocoder, '_make_url', '1600 Amphitheatre Parkway, Mountain View, CA' );
52
+        $response = $this->reflectionMethodInvokeArgs( $this->_geocoder, '_get_data', $url );
53 53
 
54
-        $this->assertInternalType('array', $response);
54
+        $this->assertInternalType( 'array', $response );
55 55
     }
56 56
 
57 57
     /**
@@ -59,26 +59,26 @@  discard block
 block discarded – undo
59 59
      * @covers ::_make_location
60 60
      */
61 61
     public function testGeocode() {
62
-        $location = $this->_geocoder->geocode('1600 Amphitheatre Parkway, Mountain View, CA');
62
+        $location = $this->_geocoder->geocode( '1600 Amphitheatre Parkway, Mountain View, CA' );
63 63
 
64
-        $this->assertInstanceOf('\Clubdeuce\WPLib\Components\GoogleMaps\Location', $location);
65
-        $this->assertEquals('1600 Amphitheatre Pkwy, Mountain View, CA 94043, USA', $location->address());
66
-        $this->assertEquals('1600 Amphitheatre Pkwy, Mountain View, CA 94043, USA', $location->formatted_address());
67
-        $this->assertInternalType('double', $location->latitude());
68
-        $this->assertInternalType('double', $location->longitude());
69
-        $this->assertEquals('ChIJ2eUgeAK6j4ARbn5u_wAGqWA', $location->place_id());
70
-        $this->assertInternalType('array', $location->viewport());
71
-        $this->assertArrayHasKey('northeast', $location->viewport());
72
-        $this->assertArrayHasKey('southwest', $location->viewport());
73
-        $this->assertInternalType('array', $location->viewport()['northeast']);
74
-        $this->assertArrayHasKey('lat', $location->viewport()['northeast']);
75
-        $this->assertArrayHasKey('lng', $location->viewport()['northeast']);
76
-        $this->assertInternalType('double', $location->viewport()['northeast']['lat']);
77
-        $this->assertInternalType('double', $location->viewport()['northeast']['lng']);
78
-        $this->assertInternalType('array', $location->viewport()['southwest']);
79
-        $this->assertArrayHasKey('lat', $location->viewport()['southwest']);
80
-        $this->assertArrayHasKey('lng', $location->viewport()['southwest']);
81
-        $this->assertInternalType('double', $location->viewport()['southwest']['lat']);
82
-        $this->assertInternalType('double', $location->viewport()['southwest']['lng']);
64
+        $this->assertInstanceOf( '\Clubdeuce\WPLib\Components\GoogleMaps\Location', $location );
65
+        $this->assertEquals( '1600 Amphitheatre Pkwy, Mountain View, CA 94043, USA', $location->address() );
66
+        $this->assertEquals( '1600 Amphitheatre Pkwy, Mountain View, CA 94043, USA', $location->formatted_address() );
67
+        $this->assertInternalType( 'double', $location->latitude() );
68
+        $this->assertInternalType( 'double', $location->longitude() );
69
+        $this->assertEquals( 'ChIJ2eUgeAK6j4ARbn5u_wAGqWA', $location->place_id() );
70
+        $this->assertInternalType( 'array', $location->viewport() );
71
+        $this->assertArrayHasKey( 'northeast', $location->viewport() );
72
+        $this->assertArrayHasKey( 'southwest', $location->viewport() );
73
+        $this->assertInternalType( 'array', $location->viewport()['northeast'] );
74
+        $this->assertArrayHasKey( 'lat', $location->viewport()['northeast'] );
75
+        $this->assertArrayHasKey( 'lng', $location->viewport()['northeast'] );
76
+        $this->assertInternalType( 'double', $location->viewport()['northeast']['lat'] );
77
+        $this->assertInternalType( 'double', $location->viewport()['northeast']['lng'] );
78
+        $this->assertInternalType( 'array', $location->viewport()['southwest'] );
79
+        $this->assertArrayHasKey( 'lat', $location->viewport()['southwest'] );
80
+        $this->assertArrayHasKey( 'lng', $location->viewport()['southwest'] );
81
+        $this->assertInternalType( 'double', $location->viewport()['southwest']['lat'] );
82
+        $this->assertInternalType( 'double', $location->viewport()['southwest']['lng'] );
83 83
     }
84 84
 }
Please login to merge, or discard this patch.
tests/unit/testGeocoder.php 1 patch
Spacing   +28 added lines, -28 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
      *
28 28
      */
29 29
     public function setUp() {
30
-        $this->_geocoder = new Geocoder(['api_key' => $this->_api_key]);
30
+        $this->_geocoder = new Geocoder( ['api_key' => $this->_api_key] );
31 31
     }
32 32
 
33 33
     /**
@@ -35,54 +35,54 @@  discard block
 block discarded – undo
35 35
      * @covers ::api_key
36 36
      */
37 37
     public function testConstructorWithAPIKey() {
38
-        $this->assertEquals($this->_api_key, $this->_geocoder->api_key());
38
+        $this->assertEquals( $this->_api_key, $this->_geocoder->api_key() );
39 39
     }
40 40
 
41 41
     /**
42 42
      * @covers ::_make_url
43 43
      */
44 44
     public function testMakeUrl() {
45
-        $response = $this->reflectionMethodInvokeArgs($this->_geocoder, '_make_url', '123 Anywhere Street New York 10001');
45
+        $response = $this->reflectionMethodInvokeArgs( $this->_geocoder, '_make_url', '123 Anywhere Street New York 10001' );
46 46
 
47
-        $this->assertInternalType('string', $response);
48
-        $this->assertRegExp('/address\=123\+Anywhere\+Street\+New\+York\+10001/', $response);
49
-        $this->assertRegExp("/key={$this->_api_key}/", $response);
47
+        $this->assertInternalType( 'string', $response );
48
+        $this->assertRegExp( '/address\=123\+Anywhere\+Street\+New\+York\+10001/', $response );
49
+        $this->assertRegExp( "/key={$this->_api_key}/", $response );
50 50
     }
51 51
 
52 52
     /**
53 53
      * @covers ::_get_data
54 54
      */
55 55
     public function testGetDataCache() {
56
-        wp_cache_add( md5(serialize('foo.bar')), 'foobar');
56
+        wp_cache_add( md5( serialize( 'foo.bar' ) ), 'foobar' );
57 57
 
58
-        $this->assertEquals('foobar', $this->reflectionMethodInvokeArgs($this->_geocoder, '_get_data', 'foo.bar'));
58
+        $this->assertEquals( 'foobar', $this->reflectionMethodInvokeArgs( $this->_geocoder, '_get_data', 'foo.bar' ) );
59 59
     }
60 60
 
61 61
     /**
62 62
      * @covers ::_make_location
63 63
      */
64 64
     public function testMakeLocation() {
65
-        $response = json_decode(file_get_contents(TEST_INCLUDES_DIR . '/geocoder-response.json'), true);
66
-        $location = $this->reflectionMethodInvokeArgs($this->_geocoder, '_make_location', $response['results'][0] );
65
+        $response = json_decode( file_get_contents( TEST_INCLUDES_DIR.'/geocoder-response.json' ), true );
66
+        $location = $this->reflectionMethodInvokeArgs( $this->_geocoder, '_make_location', $response['results'][0] );
67 67
 
68
-        $this->assertInstanceOf('\Clubdeuce\WPLib\Components\GoogleMaps\Location', $location);
69
-        $this->assertEquals('1600 Amphitheatre Parkway, Mountain View, CA 94043, USA', $location->address());
70
-        $this->assertEquals('1600 Amphitheatre Parkway, Mountain View, CA 94043, USA', $location->formatted_address());
71
-        $this->assertEquals(37.4224764, $location->latitude());
68
+        $this->assertInstanceOf( '\Clubdeuce\WPLib\Components\GoogleMaps\Location', $location );
69
+        $this->assertEquals( '1600 Amphitheatre Parkway, Mountain View, CA 94043, USA', $location->address() );
70
+        $this->assertEquals( '1600 Amphitheatre Parkway, Mountain View, CA 94043, USA', $location->formatted_address() );
71
+        $this->assertEquals( 37.4224764, $location->latitude() );
72 72
         $this->assertEquals(-122.0842499, $location->longitude());
73
-        $this->assertEquals('ChIJ2eUgeAK6j4ARbn5u_wAGqWA', $location->place_id());
74
-        $this->assertInternalType('array', $location->viewport());
75
-        $this->assertArrayHasKey('northeast', $location->viewport());
76
-        $this->assertArrayHasKey('southwest', $location->viewport());
77
-        $this->assertInternalType('array', $location->viewport()['northeast']);
78
-        $this->assertArrayHasKey('lat', $location->viewport()['northeast']);
79
-        $this->assertArrayHasKey('lng', $location->viewport()['northeast']);
80
-        $this->assertEquals(37.4238253802915, $location->viewport()['northeast']['lat']);
73
+        $this->assertEquals( 'ChIJ2eUgeAK6j4ARbn5u_wAGqWA', $location->place_id() );
74
+        $this->assertInternalType( 'array', $location->viewport() );
75
+        $this->assertArrayHasKey( 'northeast', $location->viewport() );
76
+        $this->assertArrayHasKey( 'southwest', $location->viewport() );
77
+        $this->assertInternalType( 'array', $location->viewport()['northeast'] );
78
+        $this->assertArrayHasKey( 'lat', $location->viewport()['northeast'] );
79
+        $this->assertArrayHasKey( 'lng', $location->viewport()['northeast'] );
80
+        $this->assertEquals( 37.4238253802915, $location->viewport()['northeast']['lat'] );
81 81
         $this->assertEquals(-122.0829009197085, $location->viewport()['northeast']['lng']);
82
-        $this->assertInternalType('array', $location->viewport()['southwest']);
83
-        $this->assertArrayHasKey('lat', $location->viewport()['southwest']);
84
-        $this->assertArrayHasKey('lng', $location->viewport()['southwest']);
85
-        $this->assertEquals(37.4211274197085, $location->viewport()['southwest']['lat']);
82
+        $this->assertInternalType( 'array', $location->viewport()['southwest'] );
83
+        $this->assertArrayHasKey( 'lat', $location->viewport()['southwest'] );
84
+        $this->assertArrayHasKey( 'lng', $location->viewport()['southwest'] );
85
+        $this->assertEquals( 37.4211274197085, $location->viewport()['southwest']['lat'] );
86 86
         $this->assertEquals(-122.0855988802915, $location->viewport()['southwest']['lng']);
87 87
     }
88 88
 
@@ -90,8 +90,8 @@  discard block
 block discarded – undo
90 90
      * @covers ::_make_request
91 91
      */
92 92
     public function testMakeRequestInvalidURL() {
93
-        $response = $this->reflectionMethodInvokeArgs($this->_geocoder, '_make_request', 'foo.bar');
94
-        $this->assertInstanceOf('WP_Error', $response);
93
+        $response = $this->reflectionMethodInvokeArgs( $this->_geocoder, '_make_request', 'foo.bar' );
94
+        $this->assertInstanceOf( 'WP_Error', $response );
95 95
     }
96 96
 
97 97
 }
98 98
\ No newline at end of file
Please login to merge, or discard this patch.