clubdeuce /
wplib-olm-google-maps
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 12 | View Code Duplication | class Marker_Label_Model extends Model_Base { |
|
| 13 | |||
| 14 | /** |
||
| 15 | * @var \Clubdeuce\WPGoogleMaps\Marker_Label |
||
| 16 | */ |
||
| 17 | protected $_label; |
||
| 18 | |||
| 19 | /** |
||
| 20 | * @return bool |
||
| 21 | */ |
||
| 22 | 1 | function has_label() { |
|
| 27 | |||
| 28 | /** |
||
| 29 | * @param string $method_name |
||
| 30 | * @param array $args |
||
| 31 | * |
||
| 32 | * @return mixed |
||
| 33 | */ |
||
| 34 | 1 | function __call( $method_name, $args = array() ) { |
|
| 55 | |||
| 56 | } |
||
| 57 |
Loading history...
Let’s assume that you have a directory layout like this:
. |-- OtherDir | |-- Bar.php | `-- Foo.php `-- SomeDir `-- Foo.phpand let’s assume the following content of
Bar.php:If both files
OtherDir/Foo.phpandSomeDir/Foo.phpare loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.phpHowever, as
OtherDir/Foo.phpdoes not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: