Completed
Pull Request — master (#22)
by Daryl
01:32
created

Info_Window_Model::__construct()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 9
Code Lines 4

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 5
CRAP Score 1

Importance

Changes 0
Metric Value
c 0
b 0
f 0
dl 0
loc 9
ccs 5
cts 5
cp 1
rs 9.6666
cc 1
eloc 4
nc 1
nop 1
crap 1
1
<?php
2
3
namespace Clubdeuce\WPLib\Components\GoogleMaps;
4
use Clubdeuce\WPGoogleMaps\Info_Window;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, Clubdeuce\WPLib\Components\GoogleMaps\Info_Window.

Let’s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let’s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
5
6
/**
7
 * Class Info_Window_Model
8
 * @package Clubdeuce\WPLib\Components\GoogleMaps
9
 *
10
 * @method \Clubdeuce\WPGoogleMaps\Info_Window info_window()
11
 * @method string content()
12
 * @method int    pixel_offset()
13
 * @method array  position()
14
 * @method int    max_width()
15
 *
16
 * @mixin Info_Window
17
 */
18
class Info_Window_Model extends Model_Base {
19
20
	/**
21
	 * @var \Clubdeuce\WPGoogleMaps\Info_Window
22
	 */
23
	protected $_info_window;
24
25
	/**
26
	 * Info_Window constructor.
27
	 *
28
	 * @param array $args
29
	 */
30 1
	function __construct( $args = array() ) {
31
32 1
		$args = wp_parse_args( $args, array(
33 1
			'info_window' => new \Clubdeuce\WPGoogleMaps\Info_Window( $args ),
34
		) );
35
36 1
		parent::__construct( $args );
37
38 1
	}
39
40
	/**
41
	 * @return bool
42
	 */
43 1
	function has_info_window() {
44
45 1
		return $this->_has( '_info_window' );
46
47
	}
48
49
	/**
50
	 * @param string $method_name
51
	 * @param array $args
52
	 *
53
	 * @return mixed|null
54
	 */
55 3 View Code Duplication
	function __call( $method_name, $args ) {
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
56
57 3
		$value = null;
0 ignored issues
show
Unused Code introduced by
$value is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
58
59
		do {
60 3
			$value = parent::__call( $method_name, $args );
0 ignored issues
show
Bug introduced by
Are you sure the assignment to $value is correct as parent::__call($method_name, $args) (which targets Clubdeuce\WPLib\Componen...ps\Model_Base::__call()) seems to always return null.

This check looks for function or method calls that always return null and whose return value is assigned to a variable.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

The method getObject() can return nothing but null, so it makes no sense to assign that value to a variable.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
61
62 3
			if ( $value ) {
63 2
				break;
64
			}
65
66 2
			if ( $this->has_info_window() ) {
67 1
				$value = call_user_func_array( array( $this->info_window(), $method_name ), $args );
68 1
				break;
69
			}
70 1
		} while ( false );
71
72 3
		return $value;
73
74
	}
75
76
}
77