Map_View - Code Metrics - Inspection of "Add title property to Marker_Model" - clubdeuce/wplib-olm-google-maps - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 643987...ab0124 )

by Daryl

created 2016-11-17 21:41 UTC

Map_View A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	4
c	1
b	0
f	0
lcom	1
cbo	1
dl	0
loc	43
rs	10

4 Methods

Rating	Name	Size	Complexity
A	the_map()	8	1
A	_make_map_args()	8	1
A	_make_markers_args()	5	1
A	_make_marker_args()	8	1

<?php

namespace Clubdeuce\WPLib\Components\GoogleMaps;

/**
 * Class Map_View
 * @package  Clubdeuce\GoogleMaps
 * @property Map $item
 */
class Map_View extends \WPLib_View_Base {

    function the_map() {

        wp_localize_script( 'map-control', 'objMapParams',  $this->_make_map_args() );
        wp_localize_script( 'map-control', 'objMapMarkers', $this->_make_markers_args() );

        echo '<div id="map" class="google-map" style="height: 400px; width: 100%"></div>';

    }

    private function _make_map_args() {

        return array(
            'center' => $this->item->center(),
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            'zoom'   => $this->item->zoom(),
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        );

    }

    /**
     * @return array
     */
    private function _make_markers_args() {

        return array_map( array( __CLASS__, '_make_marker_args' ), $this->item->markers() );
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

    }

    /**
     * @param  Marker $marker
     * @return array
     */
    private function _make_marker_args( $marker ) {

        return array(
            'position' => array( 'lat' => $marker->latitude(), 'lng' => $marker->longitude() ),
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            'title'    => $marker->title(),
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        );

    }

}


1			<?php
2
3			namespace Clubdeuce\WPLib\Components\GoogleMaps;
4
5			/**
6			* Class Map_View
7			* @package Clubdeuce\GoogleMaps
8			* @property Map $item
9			*/
10			class Map_View extends \WPLib_View_Base {
11
12			function the_map() {
13
14			wp_localize_script( 'map-control', 'objMapParams', $this->_make_map_args() );
15			wp_localize_script( 'map-control', 'objMapMarkers', $this->_make_markers_args() );
16
17			echo '<div id="map" class="google-map" style="height: 400px; width: 100%"></div>';
18
19			}
20
21			private function _make_map_args() {
22
23			return array(
24			'center' => $this->item->center(),
			0 ignored issues – show Documentation Bug introduced 2016-11-17 21:43 UTC by Report Bug Copy Issue Report The method `center` does not exist on `object<Clubdeuce\WPLib\Components\GoogleMaps\Map>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
25			'zoom' => $this->item->zoom(),
			0 ignored issues – show Documentation Bug introduced 2016-11-17 21:43 UTC by Report Bug Copy Issue Report The method `zoom` does not exist on `object<Clubdeuce\WPLib\Components\GoogleMaps\Map>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
26			);
27
28			}
29
30			/**
31			* @return array
32			*/
33			private function _make_markers_args() {
34
35			return array_map( array( __CLASS__, '_make_marker_args' ), $this->item->markers() );
			0 ignored issues – show Documentation Bug introduced 2016-11-17 21:43 UTC by Report Bug Copy Issue Report The method `markers` does not exist on `object<Clubdeuce\WPLib\Components\GoogleMaps\Map>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
36
37			}
38
39			/**
40			* @param Marker $marker
41			* @return array
42			*/
43			private function _make_marker_args( $marker ) {
44
45			return array(
46			'position' => array( 'lat' => $marker->latitude(), 'lng' => $marker->longitude() ),
			0 ignored issues – show Documentation Bug introduced 2016-11-17 21:43 UTC by Report Bug Copy Issue Report The method `latitude` does not exist on `object<Clubdeuce\WPLib\C...ents\GoogleMaps\Marker>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() / class SomeClass extends ParentClass { } Loading history... Documentation Bug introduced 2016-11-17 21:43 UTC by Report Bug Copy Issue Report The method `longitude` does not exist on `object<Clubdeuce\WPLib\C...ents\GoogleMaps\Marker>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /* * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
47			'title' => $marker->title(),
			0 ignored issues – show Documentation Bug introduced 2016-11-17 21:43 UTC by Report Bug Copy Issue Report The method `title` does not exist on `object<Clubdeuce\WPLib\C...ents\GoogleMaps\Marker>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
48			);
49
50			}
51
52			}
53

clubdeuce / wplib-olm-google-maps

Push — master ( 643987...ab0124 )

Map_View A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like