clubdeuce /
wplib-olm-google-maps
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 12 | class Marker_Model extends Model_Base { |
||
| 13 | |||
| 14 | /** |
||
| 15 | * @var WPMarker |
||
| 16 | */ |
||
| 17 | protected $_marker; |
||
| 18 | |||
| 19 | /** |
||
| 20 | * @return bool |
||
| 21 | */ |
||
| 22 | 1 | function has_marker() { |
|
| 23 | |||
| 24 | 1 | return $this->_has( '_marker' ); |
|
| 25 | |||
| 26 | } |
||
| 27 | |||
| 28 | /** |
||
| 29 | * @return Location |
||
| 30 | */ |
||
| 31 | 2 | function location() { |
|
| 36 | |||
| 37 | /** |
||
| 38 | * @return Marker_Label |
||
| 39 | */ |
||
| 40 | 1 | function label() { |
|
| 45 | |||
| 46 | /** |
||
| 47 | * @return Info_Window |
||
| 48 | */ |
||
| 49 | 1 | function info_window() { |
|
| 57 | |||
| 58 | /** |
||
| 59 | * @param string $method_name |
||
| 60 | * @param array $args |
||
| 61 | * |
||
| 62 | * @return mixed|null |
||
| 63 | */ |
||
| 64 | 1 | View Code Duplication | function __call( $method_name, $args ) { |
| 82 | |||
| 83 | } |
||
| 84 |
Loading history...
This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue.
If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress.
In this case you can add the
@ignorePhpDoc annotation to the duplicate definition and it will be ignored.