Issues in class-marker-model.php - New Issues - Inspection of "Refactor to use wp-google-maps library" - clubdeuce/wplib-olm-google-maps - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#22)

by Daryl

created 2017-11-22 19:53 UTC

includes/class-marker-model.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Clubdeuce\WPLib\Components\GoogleMaps;
use Clubdeuce\WPGoogleMaps\Marker;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

/**
 * Class Marker_Model
 * @package Clubdeuce\WPLib\Components\GoogleMaps
 *
 * @method \Clubdeuce\WPGoogleMaps\Marker marker()
 */
class Marker_Model extends Model_Base {

	/**
	 * @var \Clubdeuce\WPGoogleMaps\Marker
	 */
    protected $_marker;

	/**
	 * @return bool
	 */
	function has_marker() {

		return $this->_has( '_marker' );

	}

	/**
	 * @return Location
	 */
	function location() {

		return new Location( array( 'location' => $this->marker()->location() ) );

	}

	/**
	 * @return Marker_Label
	 */
	function label() {

		return new Marker_Label( array( 'label' => $this->marker()->label() ) );

	}

	/**
	 * @return Info_Window
	 */
	function info_window() {

		return new Info_Window( array( 'info_window' => $this->marker()->info_window() ) );

	}

	/**
	 * @param string $method_name
	 * @param array $args
	 *
	 * @return mixed|null
	 */
	function __call( $method_name, $args ) {


		$value = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

		do {
			$value = parent::__call( $method_name, $args );
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

			if ( $value ) {
				break;
			}

			if ( $this->has_marker() ) {
				$value = call_user_func_array( array( $this->marker(), $method_name ), $args );
				break;
			}
		} while ( false );

		return $value;

	}

}


1			<?php
2
3			namespace Clubdeuce\WPLib\Components\GoogleMaps;
4			use Clubdeuce\WPGoogleMaps\Marker;
			0 ignored issues – show Bug introduced 2017-11-22 16:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `Clubdeuce\WPLib\Components\GoogleMaps\Marker`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
5
6			/**
7			* Class Marker_Model
8			* @package Clubdeuce\WPLib\Components\GoogleMaps
9			*
10			* @method \Clubdeuce\WPGoogleMaps\Marker marker()
11			*/
12			class Marker_Model extends Model_Base {
13
14			/**
15			* @var \Clubdeuce\WPGoogleMaps\Marker
16			*/
17			protected $_marker;
18
19			/**
20			* @return bool
21			*/
22	1		function has_marker() {
23
24	1		return $this->_has( '_marker' );
25
26			}
27
28			/**
29			* @return Location
30			*/
31	2		function location() {
32
33	2		return new Location( array( 'location' => $this->marker()->location() ) );
34
35			}
36
37			/**
38			* @return Marker_Label
39			*/
40	1		function label() {
41
42	1		return new Marker_Label( array( 'label' => $this->marker()->label() ) );
43
44			}
45
46			/**
47			* @return Info_Window
48			*/
49	1		function info_window() {
50
51	1		return new Info_Window( array( 'info_window' => $this->marker()->info_window() ) );
52
53			}
54
55			/**
56			* @param string $method_name
57			* @param array $args
58			*
59			* @return mixed\|null
60			*/
61	1	View Code Duplication	function __call( $method_name, $args ) {
			0 ignored issues – show Duplication introduced 2017-11-22 16:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
62
63	1		$value = null;
			0 ignored issues – show Unused Code introduced 2017-11-22 16:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$value` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
64
65			do {
66	1		$value = parent::__call( $method_name, $args );
			0 ignored issues – show Bug introduced 2017-11-22 16:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$value` is correct as `parent::__call($method_name, $args)` (which targets `Clubdeuce\WPLib\Componen...ps\Model_Base::__call()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
67
68	1		if ( $value ) {
69	1		break;
70			}
71
72	1		if ( $this->has_marker() ) {
73	1		$value = call_user_func_array( array( $this->marker(), $method_name ), $args );
74	1		break;
75			}
76			} while ( false );
77
78	1		return $value;
79
80			}
81
82			}
83

clubdeuce / wplib-olm-google-maps

Pull Request — master (#22)

includes/class-marker-model.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like