Issues in class-map-model.php - New Issues - Inspection of "Refactor to use wp-google-maps library" - clubdeuce/wplib-olm-google-maps - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#22)

by Daryl

created 2017-11-22 19:53 UTC

includes/class-map-model.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Clubdeuce\WPLib\Components\GoogleMaps;
use Clubdeuce\WPGoogleMaps\Map;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php


/**
 * Class Map_Model
 * @package Clubdeuce\WPLib\Components\GoogleMaps
 *
 * @mixin Map
 */
class Map_Model extends Model_Base {


	/**
	 * @var Map
	 */
	protected $_map;

	/**
	 * @return bool
	 */
	function has_map() {

		return $this->_has('_map' );

	}

	/**
	 * @param  string $method_name
	 * @param  array  $args
	 *
	 * @return mixed
	 */
	function __call( $method_name, $args = array() ) {
		$value = null;

		do {

			if ( property_exists( $this, "_{$method_name}" ) ) {
				$property = "_{$method_name}";
				$value = $this->{$property};
				break;
			}

			if ( ! isset( $this->_map ) ) {
				break;
			}

			$value = call_user_func_array( array( $this->_map, $method_name ), $args );

		} while ( false );

		return $value;
	}
}


1			<?php
2
3			namespace Clubdeuce\WPLib\Components\GoogleMaps;
4			use Clubdeuce\WPGoogleMaps\Map;
			0 ignored issues – show Bug introduced 2017-11-22 19:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `Clubdeuce\WPLib\Components\GoogleMaps\Map`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
5
6
7			/**
8			* Class Map_Model
9			* @package Clubdeuce\WPLib\Components\GoogleMaps
10			*
11			* @mixin Map
12			*/
13		View Code Duplication	class Map_Model extends Model_Base {
			0 ignored issues – show Duplication introduced 2017-11-22 16:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
14
15			/**
16			* @var Map
17			*/
18			protected $_map;
19
20			/**
21			* @return bool
22			*/
23	2		function has_map() {
24
25	2		return $this->_has('_map' );
26
27			}
28
29			/**
30			* @param string $method_name
31			* @param array $args
32			*
33			* @return mixed
34			*/
35	2		function __call( $method_name, $args = array() ) {
36	2		$value = null;
37
38			do {
39
40	2		if ( property_exists( $this, "_{$method_name}" ) ) {
41	1		$property = "_{$method_name}";
42	1		$value = $this->{$property};
43	1		break;
44			}
45
46	2		if ( ! isset( $this->_map ) ) {
47			break;
48			}
49
50	2		$value = call_user_func_array( array( $this->_map, $method_name ), $args );
51
52	2		} while ( false );
53
54	2		return $value;
55			}
56			}
57

clubdeuce / wplib-olm-google-maps

Pull Request — master (#22)

includes/class-map-model.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like