RefundRequest::getType() - Code Metrics - clippings/omnipay-paypal - Measure and Improve Code Quality continuously with Scrutinizer

RefundRequest::getType() A
last analyzed 2017-08-02 13:40 UTC

↳ Parent: RefundRequest

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	4
cp	0
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0
crap	2

<?php

namespace Omnipay\PaypalRest\Message;

use Omnipay\Common\Exception\InvalidRequestException;

/**
 * @author    Ivan Kerin <[email protected]>
 * @copyright 2014, Clippings Ltd.
 * @license   http://spdx.org/licenses/BSD-3-Clause
 */
class RefundRequest extends AbstractPaypalRequest
{
    /**
     * @return string
     */
    public function getEndpoint()
    {
        $this->validate('transactionReference', 'type');

        if (false === in_array($this->getType(), array('sale', 'authorization', 'capture'))) {
            throw new InvalidRequestException('Type can only be "sale", "authorization" or "capture"');
        }

        return "/payments/{$this->getType()}/{$this->getTransactionReference()}/refund";
    }

    public function getHttpMethod()
    {
        return 'POST';
    }

    /**
     * @return string
     */
    public function getType()
    {
        return $this->getParameter('type');
    }

    /**
     * @param string $value
     */
    public function setType($value)
    {
        return $this->setParameter('type', $value);
    }

    /**
     * @param  mixed          $data
     * @return RefundResponse
     */
    public function sendData($data)
    {
        $httpResponse = $this->sendHttpRequest($data);

        return $this->response = new RefundResponse(
            $this,
            $httpResponse->json(),
            $httpResponse->getStatusCode()
        );
    }

    /**
     * @return array
     */
    public function getData()
    {
        if ($this->getAmount()) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $this->validate('currency');

            return array(
                'amount' => array(
                    'total' => $this->getAmount(),
                    'currency' => $this->getCurrency(),
                )
            );
        } else {
            return array();
        }
    }
}


1			<?php
2
3			namespace Omnipay\PaypalRest\Message;
4
5			use Omnipay\Common\Exception\InvalidRequestException;
6
7			/**
8			* @author Ivan Kerin <[email protected]>
9			* @copyright 2014, Clippings Ltd.
10			* @license http://spdx.org/licenses/BSD-3-Clause
11			*/
12			class RefundRequest extends AbstractPaypalRequest
13			{
14			/**
15			* @return string
16			*/
17			public function getEndpoint()
18			{
19			$this->validate('transactionReference', 'type');
20
21			if (false === in_array($this->getType(), array('sale', 'authorization', 'capture'))) {
22			throw new InvalidRequestException('Type can only be "sale", "authorization" or "capture"');
23			}
24
25			return "/payments/{$this->getType()}/{$this->getTransactionReference()}/refund";
26			}
27
28			public function getHttpMethod()
29			{
30			return 'POST';
31			}
32
33			/**
34			* @return string
35			*/
36			public function getType()
37			{
38			return $this->getParameter('type');
39			}
40
41			/**
42			* @param string $value
43			*/
44			public function setType($value)
45			{
46			return $this->setParameter('type', $value);
47			}
48
49			/**
50			* @param mixed $data
51			* @return RefundResponse
52			*/
53			public function sendData($data)
54			{
55			$httpResponse = $this->sendHttpRequest($data);
56
57			return $this->response = new RefundResponse(
58			$this,
59			$httpResponse->json(),
60			$httpResponse->getStatusCode()
61			);
62			}
63
64			/**
65			* @return array
66			*/
67			public function getData()
68			{
69			if ($this->getAmount()) {
			0 ignored issues – show Bug Best Practice introduced 2017-03-04 20:29 UTC by Report Bug Copy Issue Report The expression `$this->getAmount()` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
70			$this->validate('currency');
71
72			return array(
73			'amount' => array(
74			'total' => $this->getAmount(),
75			'currency' => $this->getCurrency(),
76			)
77			);
78			} else {
79			return array();
80			}
81			}
82			}
83

clippings / omnipay-paypal

RefundRequest::getType() A last analyzed 2017-08-02 13:40 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

RefundRequest::getType() A
last analyzed 2017-08-02 13:40 UTC